From: Greg KH <gregkh@linuxfoundation.org>
To: Navaneeth K <knavaneeth786@gmail.com>
Cc: Abdun Nihaal <abdun.nihaal@gmail.com>,
parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: dim2: fix missing cleanup on interface registration failure
Date: Wed, 26 Nov 2025 12:32:52 +0100 [thread overview]
Message-ID: <2025112643-wife-repose-d923@gregkh> (raw)
In-Reply-To: <de76ebde-3453-4f4f-a0a4-d054121de553@gmail.com>
On Tue, Nov 25, 2025 at 09:36:16PM +0530, Navaneeth K wrote:
> Hi Nihaal,
> Thank you for the detailed explanation.
> That makes perfect sense. I wasn’t aware that most_register_interface()
> is intended to handle cleanup via the dev.release path even on failure.
> I will analyze most_register_interface() and prepare a follow-up patch
> to address the inconsistency in the early error paths where put_device()
> is missing, as you suggested.
>
> Greg, since this version of the patch would introduce a double-free,
> could you please drop it from staging-testing?
Ok, will go drop it now, thanks.
greg k-h
prev parent reply other threads:[~2025-11-26 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 18:56 [PATCH] staging: most: dim2: fix missing cleanup on interface registration failure Navaneeth K
2025-11-25 15:16 ` Abdun Nihaal
2025-11-25 16:06 ` Navaneeth K
2025-11-26 11:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025112643-wife-repose-d923@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abdun.nihaal@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox