From: Tomasz Sadowski <tsdwski@gmail.com>
To: Dave Penkler <dpenkler@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Tomasz Sadowski <tsdwski@gmail.com>
Subject: [PATCH v3] staging: fluke_gpib: use kzalloc instead of kmalloc + memset
Date: Thu, 27 Nov 2025 10:58:49 +0100 [thread overview]
Message-ID: <20251127101055.8771-1-tsdwski@gmail.com> (raw)
Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
Also use sizeof(*board->private_data) instead of repeating the struct name.
This avoids duplication and keeps the code correct if the struct name
changes in the future.
Signed-off-by: Tomasz Sadowski <tsdwski@gmail.com>
---
v3:
- Move version history below "---"
v2:
- Add proper commit description
- No changes in patch
drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
index 3ae848e3f738..2b6ba7882dba 100644
--- a/drivers/staging/gpib/eastwood/fluke_gpib.c
+++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
{
struct fluke_priv *priv;
- board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+ board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);
if (!board->private_data)
return -ENOMEM;
priv = board->private_data;
- memset(priv, 0, sizeof(struct fluke_priv));
init_nec7210_private(&priv->nec7210_priv);
priv->dma_buffer_size = 0x7ff;
priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
--
2.52.0
next reply other threads:[~2025-11-27 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 9:58 Tomasz Sadowski [this message]
2025-12-13 14:39 ` [PATCH v3] staging: fluke_gpib: use kzalloc instead of kmalloc + memset Dave Penkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127101055.8771-1-tsdwski@gmail.com \
--to=tsdwski@gmail.com \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).