From: Dharanitharan R <dharanitharan725@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dharanitharan R <dharanitharan725@gmail.com>
Subject: [PATCH v1] staging: vme_user: replace (1 << n) with BIT(n)
Date: Sat, 6 Dec 2025 06:36:19 +0000 [thread overview]
Message-ID: <20251206063619.30372-1-dharanitharan725@gmail.com> (raw)
In drivers/staging/vme_user/vme.c, the functions vme_register_bridge()
and vme_unregister_bridge() use bit shifts like (1 << i) and
(1 << bridge->num) to manipulate vme_bus_numbers.
Replace these shifts with the BIT(n) macro for readability,
consistency, and kernel coding style.
Changes:
- vme_register_bridge(): (1 << i) → BIT(i)
- vme_unregister_bridge(): (1 << bridge->num) → BIT(bridge->num)
Signed-off-by: Dharanitharan R <dharanitharan725@gmail.com>
---
drivers/staging/vme_user/vme.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 2095de72596a..f62a94ef35fc 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -1766,8 +1766,8 @@ int vme_register_bridge(struct vme_bridge *bridge)
mutex_lock(&vme_buses_lock);
for (i = 0; i < sizeof(vme_bus_numbers) * 8; i++) {
- if ((vme_bus_numbers & (1 << i)) == 0) {
- vme_bus_numbers |= (1 << i);
+ if ((vme_bus_numbers & BIT(i)) == 0) {
+ vme_bus_numbers |= BIT(i);
bridge->num = i;
INIT_LIST_HEAD(&bridge->devices);
list_add_tail(&bridge->bus_list, &vme_bus_list);
@@ -1787,7 +1787,7 @@ void vme_unregister_bridge(struct vme_bridge *bridge)
struct vme_dev *tmp;
mutex_lock(&vme_buses_lock);
- vme_bus_numbers &= ~(1 << bridge->num);
+ vme_bus_numbers &= ~BIT(bridge->num);
list_for_each_entry_safe(vdev, tmp, &bridge->devices, bridge_list) {
list_del(&vdev->drv_list);
list_del(&vdev->bridge_list);
--
2.43.0
next reply other threads:[~2025-12-06 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 6:36 Dharanitharan R [this message]
2025-12-06 10:10 ` [PATCH v1] staging: vme_user: replace (1 << n) with BIT(n) David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251206063619.30372-1-dharanitharan725@gmail.com \
--to=dharanitharan725@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).