* [PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c
@ 2025-12-15 6:31 Adrish Bora
2025-12-15 7:34 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Adrish Bora @ 2025-12-15 6:31 UTC (permalink / raw)
To: gregkh
Cc: linux-staging, linux-kernel, straube.linux, dan.carpenter,
Adrish Bora
Remove commented-out dead code in netdev_close().
The code was previously commented out and is not needed.
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Adrish Bora <adrishbora@gmail.com>
---
Changes in v2:
- Removed the dead code entirely instead of fixing the comment style,
as suggested by Dan Carpenter.
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548805..df839ea1bf1d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -934,14 +934,6 @@ static int netdev_close(struct net_device *pnetdev)
padapter->net_closed = true;
padapter->netif_up = false;
-/*if (!padapter->hw_init_completed)
- {
-
- padapter->bDriverStopped = true;
-
- rtw_dev_unload(padapter);
- }
- else*/
if (pwrctl->rf_pwrstate == rf_on) {
/* s1. */
if (pnetdev) {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c
2025-12-15 6:31 [PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c Adrish Bora
@ 2025-12-15 7:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-12-15 7:34 UTC (permalink / raw)
To: Adrish Bora; +Cc: gregkh, linux-staging, linux-kernel, straube.linux
On Mon, Dec 15, 2025 at 06:31:02AM +0000, Adrish Bora wrote:
> Remove commented-out dead code in netdev_close().
> The code was previously commented out and is not needed.
>
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Adrish Bora <adrishbora@gmail.com>
> ---
> Changes in v2:
> - Removed the dead code entirely instead of fixing the comment style,
> as suggested by Dan Carpenter.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-15 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-15 6:31 [PATCH v2] staging: rtl8723bs: remove dead code in os_intfs.c Adrish Bora
2025-12-15 7:34 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox