Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Darshil Shah <darshilshah7070@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: clean up redundant parentheses in rtw_mlme.c
Date: Wed, 17 Dec 2025 14:09:50 +0100	[thread overview]
Message-ID: <2025121704-unroasted-faculty-a76f@gregkh> (raw)
In-Reply-To: <20251215210901.12058-1-darshilshah7070@gmail.com>

On Tue, Dec 16, 2025 at 02:39:01AM +0530, Darshil Shah wrote:
> - Removed unnecessary parentheses around if conditions

Only one if condition was changed.

> - Removed redundant '== true' and '== false' comparisons

Ok,I see why you removed this at the same time, but really, it was not
redundant, you just changed the operator to something else.

But why?  It's not really required by anything, what is driving this
change?

thanks,

greg k-h

  reply	other threads:[~2025-12-17 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 21:09 [PATCH] staging: rtl8723bs: clean up redundant parentheses in rtw_mlme.c Darshil Shah
2025-12-17 13:09 ` Greg KH [this message]
     [not found]   ` <CAGQ2yWkLp62n+KbA9fEhGJXxK7o_XiM8Xi0Zu==J+ko45h-QFw@mail.gmail.com>
2025-12-17 13:44     ` Darshil Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025121704-unroasted-faculty-a76f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=darshilshah7070@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox