public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Adrish Bora <adrishbora@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	straube.linux@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: fix block comment coding style
Date: Wed, 17 Dec 2025 14:06:50 +0100	[thread overview]
Message-ID: <2025121724-unshaved-irritable-4c34@gregkh> (raw)
In-Reply-To: <20251214142608.5516-1-adrishbora@gmail.com>

On Sun, Dec 14, 2025 at 02:26:08PM +0000, Adrish Bora wrote:
> Fix the block comment style in os_intfs.c to match the kernel coding style.
> The comment was previously lacking the required asterisks on subsequent lines.
> 
> Signed-off-by: Adrish Bora <adrishbora@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..ca841cc61076 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + *	{
> + *
> + *		padapter->bDriverStopped = true;
> + *
> + *		rtw_dev_unload(padapter);
> + *	}
> + *	else
> + */

If this code has been commented out for a long time, please just delete
it, no need to make it "pretty" with a different style of comment block.

thanks,

greg k-h

  reply	other threads:[~2025-12-17 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-14 14:26 [PATCH] staging: rtl8723bs: fix block comment coding style Adrish Bora
2025-12-17 13:06 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-12-15  4:01 [PATCH] staging: rtl8723bs: Fix " Zixuan Dong
2025-12-15  6:04 ` Dan Carpenter
2025-12-28 19:44 [PATCH] staging: rtl8723bs: fix " Ofir Mirovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025121724-unshaved-irritable-4c34@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=adrishbora@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox