[PATCH] staging: rtl8723bs: fix block comment coding style

[PATCH] staging: rtl8723bs: fix block comment coding style

[Adrish Bora]

Fix the block comment style in os_intfs.c to match the kernel coding style.
The comment was previously lacking the required asterisks on subsequent lines.

Signed-off-by: Adrish Bora <adrishbora@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548805..ca841cc61076 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
 	padapter->net_closed = true;
 	padapter->netif_up = false;
 
-/*if (!padapter->hw_init_completed)
-	{
-
-		padapter->bDriverStopped = true;
-
-		rtw_dev_unload(padapter);
-	}
-	else*/
+/*
+ * if (!padapter->hw_init_completed)
+ *	{
+ *
+ *		padapter->bDriverStopped = true;
+ *
+ *		rtw_dev_unload(padapter);
+ *	}
+ *	else
+ */
 	if (pwrctl->rf_pwrstate == rf_on) {
 		/* s1. */
 		if (pnetdev) {
-- 
2.43.0

[PATCH] staging: rtl8723bs: Fix block comment coding style

[Zixuan Dong]

Fix the following checkpatch warnings in os_intfs.c:

  WARNING: Block comments use * on subsequent lines
  WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548805..cd81d9e4a3d2 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
 	padapter->net_closed = true;
 	padapter->netif_up = false;
 
-/*if (!padapter->hw_init_completed)
-	{
-
-		padapter->bDriverStopped = true;
-
-		rtw_dev_unload(padapter);
-	}
-	else*/
+/*
+ * if (!padapter->hw_init_completed)
+ * {
+ *
+ *	padapter->bDriverStopped = true;
+ *
+ *	rtw_dev_unload(padapter);
+ * }
+ * else
+ */
 	if (pwrctl->rf_pwrstate == rf_on) {
 		/* s1. */
 		if (pnetdev) {
-- 
2.52.0

Re: [PATCH] staging: rtl8723bs: Fix block comment coding style

[Dan Carpenter]

On Mon, Dec 15, 2025 at 12:01:28PM +0800, Zixuan Dong wrote:
> Fix the following checkpatch warnings in os_intfs.c:
> 
>   WARNING: Block comments use * on subsequent lines
>   WARNING: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..cd81d9e4a3d2 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + * {
> + *
> + *	padapter->bDriverStopped = true;
> + *
> + *	rtw_dev_unload(padapter);
> + * }
> + * else
> + */

Just delete this dead code.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: fix block comment coding style

[Greg KH]

On Sun, Dec 14, 2025 at 02:26:08PM +0000, Adrish Bora wrote:
> Fix the block comment style in os_intfs.c to match the kernel coding style.
> The comment was previously lacking the required asterisks on subsequent lines.
> 
> Signed-off-by: Adrish Bora <adrishbora@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..ca841cc61076 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + *	{
> + *
> + *		padapter->bDriverStopped = true;
> + *
> + *		rtw_dev_unload(padapter);
> + *	}
> + *	else
> + */

If this code has been commented out for a long time, please just delete
it, no need to make it "pretty" with a different style of comment block.

thanks,

greg k-h

[PATCH] staging: rtl8723bs: fix block comment coding style

[Ofir Mirovsky]

Fix block comment coding style issues in rtl8723b_rf6052.c reported by checkpatch.pl:
- "Block comments should align the * on each line"
- "Block comments use a trailing */ on a separate line"

Reformat the comment block to adhere to standard kernel coding style.

Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
index ffb35e1ac..f10120d34 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
@@ -24,7 +24,7 @@
  * 11/05/2008	MHC		Add API for tw power setting.
  *
  *
-******************************************************************************/
+ ******************************************************************************/
 
 #include <rtl8723b_hal.h>
 
@@ -40,7 +40,7 @@
 /*  2008/11/20 MH For Debug only, RF */
 /*------------------------Define local variable------------------------------*/
 
-/*-----------------------------------------------------------------------------
+/*
  * Function:    PHY_RF6052SetBandwidth()
  *
  * Overview:    This function is called by SetBWModeCallback8190Pci() only
@@ -53,7 +53,7 @@
  * Return:      NONE
  *
  * Note:		For RF type 0222D
- *---------------------------------------------------------------------------*/
+ */
 void PHY_RF6052SetBandwidth8723B(
 	struct adapter *Adapter, enum channel_width Bandwidth
 ) /* 20M or 40M */
-- 
2.43.0

[PATCH] staging: rtl8723bs: remove unnecessary blank lines

[Ofir Mirovsky]

Remove unnecessary blank lines to fix checkpatch checks:
- "Blank lines aren't necessary before a close brace '}'"
- "Blank lines aren't necessary after an open brace '{'"

This improves code readability and adheres to the kernel coding style.

Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548..e66b9684d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -553,7 +553,6 @@ static void rtw_init_default_value(struct adapter *padapter)
 	padapter->fix_rate = 0xFF;
 	padapter->driver_ampdu_spacing = 0xFF;
 	padapter->driver_rx_ampdu_factor =  0xFF;
-
 }
 
 struct dvobj_priv *devobj_init(void)
@@ -898,7 +897,6 @@ void rtw_ips_pwr_down(struct adapter *padapter)
 
 void rtw_ips_dev_unload(struct adapter *padapter)
 {
-
 	if (!padapter->bSurpriseRemoved)
 		rtw_hal_deinit(padapter);
 }
@@ -980,7 +978,6 @@ void rtw_dev_unload(struct adapter *padapter)
 	u8 cnt = 0;
 
 	if (padapter->bup) {
-
 		padapter->bDriverStopped = true;
 		if (padapter->xmitpriv.ack_tx)
 			rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP);
@@ -1022,7 +1019,6 @@ void rtw_dev_unload(struct adapter *padapter)
 		}
 
 		padapter->bup = false;
-
 	}
 }
 
-- 
2.43.0