* [PATCH] staging: rtl8723bs: fix block comment coding style
@ 2025-12-28 19:44 Ofir Mirovsky
2025-12-28 19:45 ` [PATCH] staging: rtl8723bs: remove unnecessary blank lines Ofir Mirovsky
0 siblings, 1 reply; 3+ messages in thread
From: Ofir Mirovsky @ 2025-12-28 19:44 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Ofir Mirovsky
Fix block comment coding style issues in rtl8723b_rf6052.c reported by checkpatch.pl:
- "Block comments should align the * on each line"
- "Block comments use a trailing */ on a separate line"
Reformat the comment block to adhere to standard kernel coding style.
Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
index ffb35e1ac..f10120d34 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c
@@ -24,7 +24,7 @@
* 11/05/2008 MHC Add API for tw power setting.
*
*
-******************************************************************************/
+ ******************************************************************************/
#include <rtl8723b_hal.h>
@@ -40,7 +40,7 @@
/* 2008/11/20 MH For Debug only, RF */
/*------------------------Define local variable------------------------------*/
-/*-----------------------------------------------------------------------------
+/*
* Function: PHY_RF6052SetBandwidth()
*
* Overview: This function is called by SetBWModeCallback8190Pci() only
@@ -53,7 +53,7 @@
* Return: NONE
*
* Note: For RF type 0222D
- *---------------------------------------------------------------------------*/
+ */
void PHY_RF6052SetBandwidth8723B(
struct adapter *Adapter, enum channel_width Bandwidth
) /* 20M or 40M */
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
2025-12-28 19:44 [PATCH] staging: rtl8723bs: fix block comment coding style Ofir Mirovsky
@ 2025-12-28 19:45 ` Ofir Mirovsky
0 siblings, 0 replies; 3+ messages in thread
From: Ofir Mirovsky @ 2025-12-28 19:45 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Ofir Mirovsky
Remove unnecessary blank lines to fix checkpatch checks:
- "Blank lines aren't necessary before a close brace '}'"
- "Blank lines aren't necessary after an open brace '{'"
This improves code readability and adheres to the kernel coding style.
Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548..e66b9684d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -553,7 +553,6 @@ static void rtw_init_default_value(struct adapter *padapter)
padapter->fix_rate = 0xFF;
padapter->driver_ampdu_spacing = 0xFF;
padapter->driver_rx_ampdu_factor = 0xFF;
-
}
struct dvobj_priv *devobj_init(void)
@@ -898,7 +897,6 @@ void rtw_ips_pwr_down(struct adapter *padapter)
void rtw_ips_dev_unload(struct adapter *padapter)
{
-
if (!padapter->bSurpriseRemoved)
rtw_hal_deinit(padapter);
}
@@ -980,7 +978,6 @@ void rtw_dev_unload(struct adapter *padapter)
u8 cnt = 0;
if (padapter->bup) {
-
padapter->bDriverStopped = true;
if (padapter->xmitpriv.ack_tx)
rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP);
@@ -1022,7 +1019,6 @@ void rtw_dev_unload(struct adapter *padapter)
}
padapter->bup = false;
-
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
@ 2025-12-27 23:45 Ofir Mirovsky
0 siblings, 0 replies; 3+ messages in thread
From: Ofir Mirovsky @ 2025-12-27 23:45 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Ofir Mirovsky
Remove unnecessary blank lines to fix checkpatch checks:
- "Blank lines aren't necessary before a close brace '}'"
- "Blank lines aren't necessary after an open brace '{'"
This improves code readability and adheres to the kernel coding style.
Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548..e66b9684d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -553,7 +553,6 @@ static void rtw_init_default_value(struct adapter *padapter)
padapter->fix_rate = 0xFF;
padapter->driver_ampdu_spacing = 0xFF;
padapter->driver_rx_ampdu_factor = 0xFF;
-
}
struct dvobj_priv *devobj_init(void)
@@ -898,7 +897,6 @@ void rtw_ips_pwr_down(struct adapter *padapter)
void rtw_ips_dev_unload(struct adapter *padapter)
{
-
if (!padapter->bSurpriseRemoved)
rtw_hal_deinit(padapter);
}
@@ -980,7 +978,6 @@ void rtw_dev_unload(struct adapter *padapter)
u8 cnt = 0;
if (padapter->bup) {
-
padapter->bDriverStopped = true;
if (padapter->xmitpriv.ack_tx)
rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP);
@@ -1022,7 +1019,6 @@ void rtw_dev_unload(struct adapter *padapter)
}
padapter->bup = false;
-
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-28 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-28 19:44 [PATCH] staging: rtl8723bs: fix block comment coding style Ofir Mirovsky
2025-12-28 19:45 ` [PATCH] staging: rtl8723bs: remove unnecessary blank lines Ofir Mirovsky
-- strict thread matches above, loose matches on Subject: below --
2025-12-27 23:45 Ofir Mirovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).