* [PATCH] staging: sm750fb: fix const array warning
@ 2025-12-26 12:04 MottiKumar
2025-12-30 7:42 ` Greg KH
2025-12-31 3:31 ` kernel test robot
0 siblings, 2 replies; 7+ messages in thread
From: MottiKumar @ 2025-12-26 12:04 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: skhan, linux-kernel-mentees, linux-fbdev, linux-staging,
linux-kernel, mottikumarbabu
Add a missing const to g_fbmode to fix a checkpatch warning:
"static const char * array should probably be static const char * const"
Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index d100b9e1d3d5..7afb58561a0c 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: sm750fb: fix const array warning
2025-12-26 12:04 [PATCH] staging: sm750fb: fix const array warning MottiKumar
@ 2025-12-30 7:42 ` Greg KH
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
2025-12-31 3:31 ` kernel test robot
1 sibling, 1 reply; 7+ messages in thread
From: Greg KH @ 2025-12-30 7:42 UTC (permalink / raw)
To: MottiKumar
Cc: sudipm.mukherjee, teddy.wang, skhan, linux-kernel-mentees,
linux-fbdev, linux-staging, linux-kernel
On Fri, Dec 26, 2025 at 05:34:17PM +0530, MottiKumar wrote:
> Add a missing const to g_fbmode to fix a checkpatch warning:
> "static const char * array should probably be static const char * const"
>
> Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index d100b9e1d3d5..7afb58561a0c 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.43.0
>
>
Did you test build this change? If not, please do so.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: sm750fb: fix const array warning
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
@ 2025-12-30 12:51 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2025-12-30 12:51 UTC (permalink / raw)
To: Motti Kumar Babu
Cc: sudipm.mukherjee, teddy.wang, skhan, linux-kernel-mentees,
linux-fbdev, linux-staging, linux-kernel
On Tue, Dec 30, 2025 at 05:42:43PM +0530, Motti Kumar Babu wrote:
> Hi Greg KH,
>
> Yes, I have verified this change with a test build.
>
> I ran make defconfig followed by make M=drivers/staging/sm750fb/ on the
> staging-testing branch, and the driver compiled successfully without any
> errors or new warnings.
defconfig will not enable this driver, are you sure you actually built
it?
And please do not top-post, or use html email.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: sm750fb: fix const array warning
2025-12-26 12:04 [PATCH] staging: sm750fb: fix const array warning MottiKumar
2025-12-30 7:42 ` Greg KH
@ 2025-12-31 3:31 ` kernel test robot
2025-12-31 8:41 ` [PATCH v2] staging: sm750fb: fix const array warning for fix_id MottiKumar
1 sibling, 1 reply; 7+ messages in thread
From: kernel test robot @ 2025-12-31 3:31 UTC (permalink / raw)
To: MottiKumar, sudipm.mukherjee, teddy.wang, gregkh
Cc: oe-kbuild-all, skhan, linux-kernel-mentees, linux-fbdev,
linux-staging, linux-kernel, mottikumarbabu
Hi MottiKumar,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/MottiKumar/staging-sm750fb-fix-const-array-warning/20251226-200623
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20251226120417.2599020-1-mottikumarbabu%40gmail.com
patch subject: [PATCH] staging: sm750fb: fix const array warning
config: x86_64-randconfig-002-20250506 (https://download.01.org/0day-ci/archive/20251231/202512311146.XB8ZVrTY-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251231/202512311146.XB8ZVrTY-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512311146.XB8ZVrTY-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/staging/sm750fb/sm750.c: In function 'lynxfb_set_fbinfo':
>> drivers/staging/sm750fb/sm750.c:795:33: error: assignment of read-only location 'g_fbmode[index]'
795 | g_fbmode[index] = g_def_fbmode;
| ^
drivers/staging/sm750fb/sm750.c:797:41: error: assignment of read-only location 'g_fbmode[index]'
797 | g_fbmode[index] = g_fbmode[0];
| ^
drivers/staging/sm750fb/sm750.c: In function 'sm750fb_setup':
>> drivers/staging/sm750fb/sm750.c:958:45: error: assignment of read-only location 'g_fbmode[0]'
958 | g_fbmode[0] = opt;
| ^
drivers/staging/sm750fb/sm750.c:962:45: error: assignment of read-only location 'g_fbmode[1]'
962 | g_fbmode[1] = opt;
| ^
vim +795 drivers/staging/sm750fb/sm750.c
81dee67e215b23f Sudip Mukherjee 2015-03-03 722
81dee67e215b23f Sudip Mukherjee 2015-03-03 723 static int lynxfb_set_fbinfo(struct fb_info *info, int index)
81dee67e215b23f Sudip Mukherjee 2015-03-03 724 {
81dee67e215b23f Sudip Mukherjee 2015-03-03 725 int i;
81dee67e215b23f Sudip Mukherjee 2015-03-03 726 struct lynxfb_par *par;
e359b6a863e19f2 Mike Rapoport 2015-10-26 727 struct sm750_dev *sm750_dev;
81dee67e215b23f Sudip Mukherjee 2015-03-03 728 struct lynxfb_crtc *crtc;
81dee67e215b23f Sudip Mukherjee 2015-03-03 729 struct lynxfb_output *output;
81dee67e215b23f Sudip Mukherjee 2015-03-03 730 struct fb_var_screeninfo *var;
81dee67e215b23f Sudip Mukherjee 2015-03-03 731 struct fb_fix_screeninfo *fix;
81dee67e215b23f Sudip Mukherjee 2015-03-03 732
81dee67e215b23f Sudip Mukherjee 2015-03-03 733 const struct fb_videomode *pdb[] = {
81dee67e215b23f Sudip Mukherjee 2015-03-03 734 lynx750_ext, NULL, vesa_modes,
81dee67e215b23f Sudip Mukherjee 2015-03-03 735 };
81dee67e215b23f Sudip Mukherjee 2015-03-03 736 int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
d5d66cfea2ca281 Kelsey Skunberg 2019-04-27 737 static const char * const mdb_desc[] = {
81dee67e215b23f Sudip Mukherjee 2015-03-03 738 "driver prepared modes",
81dee67e215b23f Sudip Mukherjee 2015-03-03 739 "kernel prepared default modedb",
81dee67e215b23f Sudip Mukherjee 2015-03-03 740 "kernel HELPERS prepared vesa_modes",
81dee67e215b23f Sudip Mukherjee 2015-03-03 741 };
81dee67e215b23f Sudip Mukherjee 2015-03-03 742
8c475735085a7db Tim Wassink 2025-12-21 743 static const char *fix_id[2] = {
81dee67e215b23f Sudip Mukherjee 2015-03-03 744 "sm750_fb1", "sm750_fb2",
81dee67e215b23f Sudip Mukherjee 2015-03-03 745 };
81dee67e215b23f Sudip Mukherjee 2015-03-03 746
81dee67e215b23f Sudip Mukherjee 2015-03-03 747 int ret, line_length;
81dee67e215b23f Sudip Mukherjee 2015-03-03 748
81dee67e215b23f Sudip Mukherjee 2015-03-03 749 ret = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 750 par = (struct lynxfb_par *)info->par;
e359b6a863e19f2 Mike Rapoport 2015-10-26 751 sm750_dev = par->dev;
81dee67e215b23f Sudip Mukherjee 2015-03-03 752 crtc = &par->crtc;
81dee67e215b23f Sudip Mukherjee 2015-03-03 753 output = &par->output;
81dee67e215b23f Sudip Mukherjee 2015-03-03 754 var = &info->var;
81dee67e215b23f Sudip Mukherjee 2015-03-03 755 fix = &info->fix;
81dee67e215b23f Sudip Mukherjee 2015-03-03 756
81dee67e215b23f Sudip Mukherjee 2015-03-03 757 /* set index */
81dee67e215b23f Sudip Mukherjee 2015-03-03 758 par->index = index;
81dee67e215b23f Sudip Mukherjee 2015-03-03 759 output->channel = &crtc->channel;
81dee67e215b23f Sudip Mukherjee 2015-03-03 760 sm750fb_set_drv(par);
81dee67e215b23f Sudip Mukherjee 2015-03-03 761
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 762 /*
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 763 * set current cursor variable and proc pointer,
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 764 * must be set after crtc member initialized
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 765 */
fdc234d85210d91 Benjamin Philip 2021-07-28 766 crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
e359b6a863e19f2 Mike Rapoport 2015-10-26 767 crtc->cursor.mmio = sm750_dev->pvReg +
e359b6a863e19f2 Mike Rapoport 2015-10-26 768 0x800f0 + (int)crtc->channel * 0x140;
81dee67e215b23f Sudip Mukherjee 2015-03-03 769
81dee67e215b23f Sudip Mukherjee 2015-03-03 770 pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio);
cd33da26036ea54 Christopher Carbone 2022-08-23 771 crtc->cursor.max_h = 64;
cd33da26036ea54 Christopher Carbone 2022-08-23 772 crtc->cursor.max_w = 64;
39f9137268ee3df Benjamin Philip 2021-07-26 773 crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8;
e359b6a863e19f2 Mike Rapoport 2015-10-26 774 crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset;
81dee67e215b23f Sudip Mukherjee 2015-03-03 775
3de08a2d14ff8c7 Lorenzo Stoakes 2015-03-20 776 memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
f7c8a046577e09d Thomas Zimmermann 2023-11-27 777 if (!g_hwcursor)
52d0744d751d8f1 Arnd Bergmann 2016-11-09 778 sm750_hw_cursor_disable(&crtc->cursor);
81dee67e215b23f Sudip Mukherjee 2015-03-03 779
81dee67e215b23f Sudip Mukherjee 2015-03-03 780 /* set info->fbops, must be set before fb_find_mode */
e359b6a863e19f2 Mike Rapoport 2015-10-26 781 if (!sm750_dev->accel_off) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 782 /* use 2d acceleration */
f7c8a046577e09d Thomas Zimmermann 2023-11-27 783 if (!g_hwcursor)
f7c8a046577e09d Thomas Zimmermann 2023-11-27 784 info->fbops = &lynxfb_ops_accel;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 785 else
f7c8a046577e09d Thomas Zimmermann 2023-11-27 786 info->fbops = &lynxfb_ops_accel_with_cursor;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 787 } else {
f7c8a046577e09d Thomas Zimmermann 2023-11-27 788 if (!g_hwcursor)
81dee67e215b23f Sudip Mukherjee 2015-03-03 789 info->fbops = &lynxfb_ops;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 790 else
f7c8a046577e09d Thomas Zimmermann 2023-11-27 791 info->fbops = &lynxfb_ops_with_cursor;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 792 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 793
81dee67e215b23f Sudip Mukherjee 2015-03-03 794 if (!g_fbmode[index]) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 @795 g_fbmode[index] = g_def_fbmode;
81dee67e215b23f Sudip Mukherjee 2015-03-03 796 if (index)
81dee67e215b23f Sudip Mukherjee 2015-03-03 797 g_fbmode[index] = g_fbmode[0];
81dee67e215b23f Sudip Mukherjee 2015-03-03 798 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 799
81dee67e215b23f Sudip Mukherjee 2015-03-03 800 for (i = 0; i < 3; i++) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 801 ret = fb_find_mode(var, info, g_fbmode[index],
81dee67e215b23f Sudip Mukherjee 2015-03-03 802 pdb[i], cdb[i], NULL, 8);
81dee67e215b23f Sudip Mukherjee 2015-03-03 803
81dee67e215b23f Sudip Mukherjee 2015-03-03 804 if (ret == 1) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 805 pr_info("success! use specified mode:%s in %s\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 806 g_fbmode[index],
81dee67e215b23f Sudip Mukherjee 2015-03-03 807 mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 808 break;
81dee67e215b23f Sudip Mukherjee 2015-03-03 809 } else if (ret == 2) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 810 pr_warn("use specified mode:%s in %s,with an ignored refresh rate\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 811 g_fbmode[index],
81dee67e215b23f Sudip Mukherjee 2015-03-03 812 mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 813 break;
81dee67e215b23f Sudip Mukherjee 2015-03-03 814 } else if (ret == 3) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 815 pr_warn("wanna use default mode\n");
4bd9503d0becdb6 Michel von Czettritz 2015-03-26 816 /*break;*/
81dee67e215b23f Sudip Mukherjee 2015-03-03 817 } else if (ret == 4) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 818 pr_warn("fall back to any valid mode\n");
81dee67e215b23f Sudip Mukherjee 2015-03-03 819 } else {
3318bb5e945f700 Michel von Czettritz 2015-03-26 820 pr_warn("ret = %d,fb_find_mode failed,with %s\n",
3318bb5e945f700 Michel von Czettritz 2015-03-26 821 ret,
3318bb5e945f700 Michel von Czettritz 2015-03-26 822 mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 823 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 824 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 825
81dee67e215b23f Sudip Mukherjee 2015-03-03 826 /* some member of info->var had been set by fb_find_mode */
81dee67e215b23f Sudip Mukherjee 2015-03-03 827
271dbae3c6a1daa Prasant Jalan 2017-04-01 828 pr_info("Member of info->var is :\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 829 "xres=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 830 "yres=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 831 "xres_virtual=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 832 "yres_virtual=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 833 "xoffset=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 834 "yoffset=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 835 "bits_per_pixel=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 836 " ...\n",
3318bb5e945f700 Michel von Czettritz 2015-03-26 837 var->xres,
3318bb5e945f700 Michel von Czettritz 2015-03-26 838 var->yres,
3318bb5e945f700 Michel von Czettritz 2015-03-26 839 var->xres_virtual,
3318bb5e945f700 Michel von Czettritz 2015-03-26 840 var->yres_virtual,
3318bb5e945f700 Michel von Czettritz 2015-03-26 841 var->xoffset,
3318bb5e945f700 Michel von Czettritz 2015-03-26 842 var->yoffset,
3318bb5e945f700 Michel von Czettritz 2015-03-26 843 var->bits_per_pixel);
81dee67e215b23f Sudip Mukherjee 2015-03-03 844
81dee67e215b23f Sudip Mukherjee 2015-03-03 845 /* set par */
81dee67e215b23f Sudip Mukherjee 2015-03-03 846 par->info = info;
81dee67e215b23f Sudip Mukherjee 2015-03-03 847
81dee67e215b23f Sudip Mukherjee 2015-03-03 848 /* set info */
e3a3f9f5123683b Mike Rapoport 2015-10-26 849 line_length = ALIGN((var->xres_virtual * var->bits_per_pixel / 8),
e3a3f9f5123683b Mike Rapoport 2015-10-26 850 crtc->line_pad);
81dee67e215b23f Sudip Mukherjee 2015-03-03 851
81dee67e215b23f Sudip Mukherjee 2015-03-03 852 info->pseudo_palette = &par->pseudo_palette[0];
cc59bde1c920ab6 Benjamin Philip 2021-07-28 853 info->screen_base = crtc->v_screen;
81dee67e215b23f Sudip Mukherjee 2015-03-03 854 pr_debug("screen_base vaddr = %p\n", info->screen_base);
81dee67e215b23f Sudip Mukherjee 2015-03-03 855 info->screen_size = line_length * var->yres_virtual;
81dee67e215b23f Sudip Mukherjee 2015-03-03 856
81dee67e215b23f Sudip Mukherjee 2015-03-03 857 /* set info->fix */
81dee67e215b23f Sudip Mukherjee 2015-03-03 858 fix->type = FB_TYPE_PACKED_PIXELS;
81dee67e215b23f Sudip Mukherjee 2015-03-03 859 fix->type_aux = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 860 fix->xpanstep = crtc->xpanstep;
81dee67e215b23f Sudip Mukherjee 2015-03-03 861 fix->ypanstep = crtc->ypanstep;
81dee67e215b23f Sudip Mukherjee 2015-03-03 862 fix->ywrapstep = crtc->ywrapstep;
81dee67e215b23f Sudip Mukherjee 2015-03-03 863 fix->accel = FB_ACCEL_SMI;
81dee67e215b23f Sudip Mukherjee 2015-03-03 864
8c475735085a7db Tim Wassink 2025-12-21 865 strscpy(fix->id, fix_id[index], sizeof(fix->id));
81dee67e215b23f Sudip Mukherjee 2015-03-03 866
fdc234d85210d91 Benjamin Philip 2021-07-28 867 fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
81dee67e215b23f Sudip Mukherjee 2015-03-03 868 pr_info("fix->smem_start = %lx\n", fix->smem_start);
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 869 /*
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 870 * according to mmap experiment from user space application,
81dee67e215b23f Sudip Mukherjee 2015-03-03 871 * fix->mmio_len should not larger than virtual size
81dee67e215b23f Sudip Mukherjee 2015-03-03 872 * (xres_virtual x yres_virtual x ByPP)
81dee67e215b23f Sudip Mukherjee 2015-03-03 873 * Below line maybe buggy when user mmap fb dev node and write
81dee67e215b23f Sudip Mukherjee 2015-03-03 874 * data into the bound over virtual size
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 875 */
81dee67e215b23f Sudip Mukherjee 2015-03-03 876 fix->smem_len = crtc->vidmem_size;
81dee67e215b23f Sudip Mukherjee 2015-03-03 877 pr_info("fix->smem_len = %x\n", fix->smem_len);
81dee67e215b23f Sudip Mukherjee 2015-03-03 878 info->screen_size = fix->smem_len;
81dee67e215b23f Sudip Mukherjee 2015-03-03 879 fix->line_length = line_length;
e359b6a863e19f2 Mike Rapoport 2015-10-26 880 fix->mmio_start = sm750_dev->vidreg_start;
81dee67e215b23f Sudip Mukherjee 2015-03-03 881 pr_info("fix->mmio_start = %lx\n", fix->mmio_start);
e359b6a863e19f2 Mike Rapoport 2015-10-26 882 fix->mmio_len = sm750_dev->vidreg_size;
81dee67e215b23f Sudip Mukherjee 2015-03-03 883 pr_info("fix->mmio_len = %x\n", fix->mmio_len);
b610e1193a917f4 Matej Dujava 2020-04-30 884
b610e1193a917f4 Matej Dujava 2020-04-30 885 lynxfb_set_visual_mode(info);
81dee67e215b23f Sudip Mukherjee 2015-03-03 886
81dee67e215b23f Sudip Mukherjee 2015-03-03 887 /* set var */
81dee67e215b23f Sudip Mukherjee 2015-03-03 888 var->activate = FB_ACTIVATE_NOW;
81dee67e215b23f Sudip Mukherjee 2015-03-03 889 var->accel_flags = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 890 var->vmode = FB_VMODE_NONINTERLACED;
81dee67e215b23f Sudip Mukherjee 2015-03-03 891
81dee67e215b23f Sudip Mukherjee 2015-03-03 892 pr_debug("#1 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 893 info->cmap.start, info->cmap.len,
81dee67e215b23f Sudip Mukherjee 2015-03-03 894 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23f Sudip Mukherjee 2015-03-03 895 info->cmap.transp);
81dee67e215b23f Sudip Mukherjee 2015-03-03 896
61c507cf652da1b Michel von Czettritz 2015-03-26 897 ret = fb_alloc_cmap(&info->cmap, 256, 0);
61c507cf652da1b Michel von Czettritz 2015-03-26 898 if (ret < 0) {
008272072d61a8c Masanari Iida 2015-05-28 899 pr_err("Could not allocate memory for cmap.\n");
81dee67e215b23f Sudip Mukherjee 2015-03-03 900 goto exit;
81dee67e215b23f Sudip Mukherjee 2015-03-03 901 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 902
81dee67e215b23f Sudip Mukherjee 2015-03-03 903 pr_debug("#2 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 904 info->cmap.start, info->cmap.len,
81dee67e215b23f Sudip Mukherjee 2015-03-03 905 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23f Sudip Mukherjee 2015-03-03 906 info->cmap.transp);
81dee67e215b23f Sudip Mukherjee 2015-03-03 907
81dee67e215b23f Sudip Mukherjee 2015-03-03 908 exit:
81dee67e215b23f Sudip Mukherjee 2015-03-03 909 lynxfb_ops_check_var(var, info);
81dee67e215b23f Sudip Mukherjee 2015-03-03 910 return ret;
81dee67e215b23f Sudip Mukherjee 2015-03-03 911 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 912
81dee67e215b23f Sudip Mukherjee 2015-03-03 913 /* chip specific g_option configuration routine */
700591a9adc8b1b Mike Rapoport 2015-10-26 914 static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
81dee67e215b23f Sudip Mukherjee 2015-03-03 915 {
81dee67e215b23f Sudip Mukherjee 2015-03-03 916 char *opt;
81dee67e215b23f Sudip Mukherjee 2015-03-03 917 int swap;
81dee67e215b23f Sudip Mukherjee 2015-03-03 918
81dee67e215b23f Sudip Mukherjee 2015-03-03 919 swap = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 920
1757d106a9ce8cc Mike Rapoport 2015-10-26 921 sm750_dev->initParm.chip_clk = 0;
1757d106a9ce8cc Mike Rapoport 2015-10-26 922 sm750_dev->initParm.mem_clk = 0;
1757d106a9ce8cc Mike Rapoport 2015-10-26 923 sm750_dev->initParm.master_clk = 0;
1757d106a9ce8cc Mike Rapoport 2015-10-26 924 sm750_dev->initParm.powerMode = 0;
1757d106a9ce8cc Mike Rapoport 2015-10-26 925 sm750_dev->initParm.setAllEngOff = 0;
1757d106a9ce8cc Mike Rapoport 2015-10-26 926 sm750_dev->initParm.resetMemory = 1;
81dee67e215b23f Sudip Mukherjee 2015-03-03 927
81dee67e215b23f Sudip Mukherjee 2015-03-03 928 /* defaultly turn g_hwcursor on for both view */
81dee67e215b23f Sudip Mukherjee 2015-03-03 929 g_hwcursor = 3;
81dee67e215b23f Sudip Mukherjee 2015-03-03 930
81dee67e215b23f Sudip Mukherjee 2015-03-03 931 if (!src || !*src) {
c56de0967a658cb Elise Lennion 2016-10-31 932 dev_warn(&sm750_dev->pdev->dev, "no specific g_option.\n");
81dee67e215b23f Sudip Mukherjee 2015-03-03 933 goto NO_PARAM;
81dee67e215b23f Sudip Mukherjee 2015-03-03 934 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 935
0fa96e39279988b Sudip Mukherjee 2015-03-10 936 while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
c56de0967a658cb Elise Lennion 2016-10-31 937 dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt);
c56de0967a658cb Elise Lennion 2016-10-31 938 dev_info(&sm750_dev->pdev->dev, "src=%s\n", src);
81dee67e215b23f Sudip Mukherjee 2015-03-03 939
144634a6b421468 Katie Dunne 2017-02-19 940 if (!strncmp(opt, "swap", strlen("swap"))) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 941 swap = 1;
144634a6b421468 Katie Dunne 2017-02-19 942 } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) {
1757d106a9ce8cc Mike Rapoport 2015-10-26 943 sm750_dev->nocrt = 1;
144634a6b421468 Katie Dunne 2017-02-19 944 } else if (!strncmp(opt, "36bit", strlen("36bit"))) {
1757d106a9ce8cc Mike Rapoport 2015-10-26 945 sm750_dev->pnltype = sm750_doubleTFT;
144634a6b421468 Katie Dunne 2017-02-19 946 } else if (!strncmp(opt, "18bit", strlen("18bit"))) {
1757d106a9ce8cc Mike Rapoport 2015-10-26 947 sm750_dev->pnltype = sm750_dualTFT;
144634a6b421468 Katie Dunne 2017-02-19 948 } else if (!strncmp(opt, "24bit", strlen("24bit"))) {
1757d106a9ce8cc Mike Rapoport 2015-10-26 949 sm750_dev->pnltype = sm750_24TFT;
144634a6b421468 Katie Dunne 2017-02-19 950 } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 951 g_hwcursor &= ~0x1;
144634a6b421468 Katie Dunne 2017-02-19 952 } else if (!strncmp(opt, "nohwc1", strlen("nohwc1"))) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 953 g_hwcursor &= ~0x2;
144634a6b421468 Katie Dunne 2017-02-19 954 } else if (!strncmp(opt, "nohwc", strlen("nohwc"))) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 955 g_hwcursor = 0;
144634a6b421468 Katie Dunne 2017-02-19 956 } else {
81dee67e215b23f Sudip Mukherjee 2015-03-03 957 if (!g_fbmode[0]) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 @958 g_fbmode[0] = opt;
cee9ba1c30d0517 Abdul Rauf 2017-01-08 959 dev_info(&sm750_dev->pdev->dev,
cee9ba1c30d0517 Abdul Rauf 2017-01-08 960 "find fbmode0 : %s\n", g_fbmode[0]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 961 } else if (!g_fbmode[1]) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 962 g_fbmode[1] = opt;
cee9ba1c30d0517 Abdul Rauf 2017-01-08 963 dev_info(&sm750_dev->pdev->dev,
cee9ba1c30d0517 Abdul Rauf 2017-01-08 964 "find fbmode1 : %s\n", g_fbmode[1]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 965 } else {
c56de0967a658cb Elise Lennion 2016-10-31 966 dev_warn(&sm750_dev->pdev->dev, "How many view you wann set?\n");
81dee67e215b23f Sudip Mukherjee 2015-03-03 967 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 968 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 969 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 970
81dee67e215b23f Sudip Mukherjee 2015-03-03 971 NO_PARAM:
e359b6a863e19f2 Mike Rapoport 2015-10-26 972 if (sm750_dev->revid != SM750LE_REVISION_ID) {
a3f92cc94c6126d Mike Rapoport 2016-01-17 973 if (sm750_dev->fb_count > 1) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 974 if (swap)
1757d106a9ce8cc Mike Rapoport 2015-10-26 975 sm750_dev->dataflow = sm750_dual_swap;
81dee67e215b23f Sudip Mukherjee 2015-03-03 976 else
1757d106a9ce8cc Mike Rapoport 2015-10-26 977 sm750_dev->dataflow = sm750_dual_normal;
81dee67e215b23f Sudip Mukherjee 2015-03-03 978 } else {
81dee67e215b23f Sudip Mukherjee 2015-03-03 979 if (swap)
1757d106a9ce8cc Mike Rapoport 2015-10-26 980 sm750_dev->dataflow = sm750_simul_sec;
81dee67e215b23f Sudip Mukherjee 2015-03-03 981 else
1757d106a9ce8cc Mike Rapoport 2015-10-26 982 sm750_dev->dataflow = sm750_simul_pri;
81dee67e215b23f Sudip Mukherjee 2015-03-03 983 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 984 } else {
81dee67e215b23f Sudip Mukherjee 2015-03-03 985 /* SM750LE only have one crt channel */
1757d106a9ce8cc Mike Rapoport 2015-10-26 986 sm750_dev->dataflow = sm750_simul_sec;
81dee67e215b23f Sudip Mukherjee 2015-03-03 987 /* sm750le do not have complex attributes */
1757d106a9ce8cc Mike Rapoport 2015-10-26 988 sm750_dev->nocrt = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 989 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 990 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 991
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] staging: sm750fb: fix const array warning for fix_id
2025-12-31 3:31 ` kernel test robot
@ 2025-12-31 8:41 ` MottiKumar
2026-01-06 10:20 ` Greg Kroah-Hartman
2026-01-06 10:21 ` Greg Kroah-Hartman
0 siblings, 2 replies; 7+ messages in thread
From: MottiKumar @ 2025-12-31 8:41 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, lkp, MottiKumar
This is version 2 of the patch. The previous version incorrectly
modified the g_fbmode array, which caused a build failure because
that array is modified at runtime.
This version leaves g_fbmode alone and instead applies the const
fix to the fix_id array, which is a read-only lookup table.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512311146.XB8ZVrTY-lkp@intel.com/
Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 7afb58561a0c..092cfbadada4 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char * const g_fbmode[] = {NULL, NULL};
+static const char *g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
@@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
"kernel HELPERS prepared vesa_modes",
};
- static const char *fix_id[2] = {
+ static const char * const fix_id[2] = {
"sm750_fb1", "sm750_fb2",
};
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] staging: sm750fb: fix const array warning for fix_id
2025-12-31 8:41 ` [PATCH v2] staging: sm750fb: fix const array warning for fix_id MottiKumar
@ 2026-01-06 10:20 ` Greg Kroah-Hartman
2026-01-06 10:21 ` Greg Kroah-Hartman
1 sibling, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2026-01-06 10:20 UTC (permalink / raw)
To: MottiKumar; +Cc: linux-staging, lkp
On Wed, Dec 31, 2025 at 02:11:30PM +0530, MottiKumar wrote:
> This is version 2 of the patch. The previous version incorrectly
> modified the g_fbmode array, which caused a build failure because
> that array is modified at runtime.
>
> This version leaves g_fbmode alone and instead applies the const
> fix to the fix_id array, which is a read-only lookup table.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512311146.XB8ZVrTY-lkp@intel.com/
>
> Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] staging: sm750fb: fix const array warning for fix_id
2025-12-31 8:41 ` [PATCH v2] staging: sm750fb: fix const array warning for fix_id MottiKumar
2026-01-06 10:20 ` Greg Kroah-Hartman
@ 2026-01-06 10:21 ` Greg Kroah-Hartman
1 sibling, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2026-01-06 10:21 UTC (permalink / raw)
To: MottiKumar; +Cc: linux-staging, lkp
On Wed, Dec 31, 2025 at 02:11:30PM +0530, MottiKumar wrote:
> This is version 2 of the patch. The previous version incorrectly
> modified the g_fbmode array, which caused a build failure because
> that array is modified at runtime.
>
> This version leaves g_fbmode alone and instead applies the const
> fix to the fix_id array, which is a read-only lookup table.
>
> Reported-by: kernel test robot <lkp@intel.com>
The kernel test robot did not report the original issue, only that your
first patch would not actually build, which implies you did not even do
that in your testing?
How was this version tested?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-01-06 10:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 12:04 [PATCH] staging: sm750fb: fix const array warning MottiKumar
2025-12-30 7:42 ` Greg KH
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
2025-12-30 12:51 ` Greg KH
2025-12-31 3:31 ` kernel test robot
2025-12-31 8:41 ` [PATCH v2] staging: sm750fb: fix const array warning for fix_id MottiKumar
2026-01-06 10:20 ` Greg Kroah-Hartman
2026-01-06 10:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox