* [PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state
@ 2026-01-04 13:25 Gideon Adjei
2026-01-05 6:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Gideon Adjei @ 2026-01-04 13:25 UTC (permalink / raw)
To: Vaibhav Hiremath
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel, Gideon Adjei
use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument
in arche_platform_set_wake_detect_state. This keeps lines under 80
columns and satisfies kernel style guidelines.
Signed-off-by: Gideon Adjei <gideonadjei.dev@gmail.com>
---
drivers/staging/greybus/arche-platform.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index 8aaff4e45660..bb9b3c3c7a2d 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
{
struct arche_platform_drvdata *arche_pdata = devid;
unsigned long flags;
+ int state;
spin_lock_irqsave(&arche_pdata->wake_lock, flags);
@@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
*/
if (arche_pdata->wake_detect_state !=
WD_STATE_COLDBOOT_START) {
- arche_platform_set_wake_detect_state(arche_pdata,
- WD_STATE_COLDBOOT_TRIG);
+ state = WD_STATE_COLDBOOT_TRIG;
+ arche_platform_set_wake_detect_state(arche_pdata, state);
spin_unlock_irqrestore(&arche_pdata->wake_lock,
flags);
return IRQ_WAKE_THREAD;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state
2026-01-04 13:25 [PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state Gideon Adjei
@ 2026-01-05 6:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-01-05 6:21 UTC (permalink / raw)
To: Gideon Adjei
Cc: Vaibhav Hiremath, Johan Hovold, Alex Elder, greybus-dev,
linux-staging, linux-kernel
On Sun, Jan 04, 2026 at 05:25:41AM -0800, Gideon Adjei wrote:
> use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument
> in arche_platform_set_wake_detect_state. This keeps lines under 80
> columns and satisfies kernel style guidelines.
>
> Signed-off-by: Gideon Adjei <gideonadjei.dev@gmail.com>
> ---
> drivers/staging/greybus/arche-platform.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index 8aaff4e45660..bb9b3c3c7a2d 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> {
> struct arche_platform_drvdata *arche_pdata = devid;
> unsigned long flags;
> + int state;
>
> spin_lock_irqsave(&arche_pdata->wake_lock, flags);
>
> @@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
> */
> if (arche_pdata->wake_detect_state !=
> WD_STATE_COLDBOOT_START) {
> - arche_platform_set_wake_detect_state(arche_pdata,
> - WD_STATE_COLDBOOT_TRIG);
> + state = WD_STATE_COLDBOOT_TRIG;
> + arche_platform_set_wake_detect_state(arche_pdata, state);
No, sorry, the original code here is just fine, don't do things like
this just to make checkpatch "quiet".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-05 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-04 13:25 [PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state Gideon Adjei
2026-01-05 6:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox