* [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c @ 2026-01-09 9:38 Nayana Mariyappa 2026-01-09 9:43 ` Greg Kroah-Hartman 2026-01-10 8:41 ` kernel test robot 0 siblings, 2 replies; 3+ messages in thread From: Nayana Mariyappa @ 2026-01-09 9:38 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Nayana Mariyappa Fix block comment alignment, remove extra blank lines, add a blank line after declarations, and avoid multiple assignments to comply with kernel coding style. No functional changes. Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com> --- drivers/staging/rtl8723bs/os_dep/osdep_service.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c index a00f9f0c85c5..c082a0359064 100644 --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c @@ -6,10 +6,10 @@ ******************************************************************************/ #include <drv_types.h> -/* -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE -* @return: one of RTW_STATUS_CODE -*/ +/** + * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE + * @return: one of RTW_STATUS_CODE + */ inline int RTW_STATUS_CODE(int error_code) { if (error_code >= 0) @@ -152,7 +152,6 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8 *src, u32 src_len) kfree(ori); } - /** * rtw_cbuf_full - test if cbuf is full * @cbuf: pointer of struct rtw_cbuf @@ -204,6 +203,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf) void *rtw_cbuf_pop(struct rtw_cbuf *cbuf) { void *buf; + if (rtw_cbuf_empty(cbuf)) return NULL; @@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size) cbuf = rtw_malloc(struct_size(cbuf, bufs, size)); if (cbuf) { - cbuf->write = cbuf->read = 0; + cbuf->write = 0; + cbuf->read = 0; cbuf->size = size; } -- 2.43.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c 2026-01-09 9:38 [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c Nayana Mariyappa @ 2026-01-09 9:43 ` Greg Kroah-Hartman 2026-01-10 8:41 ` kernel test robot 1 sibling, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2026-01-09 9:43 UTC (permalink / raw) To: Nayana Mariyappa; +Cc: linux-staging, linux-kernel On Fri, Jan 09, 2026 at 09:38:01AM +0000, Nayana Mariyappa wrote: > Fix block comment alignment, remove extra blank lines, add a blank > line after declarations, and avoid multiple assignments to comply > with kernel coding style. > > No functional changes. > > Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com> > --- > drivers/staging/rtl8723bs/os_dep/osdep_service.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c > index a00f9f0c85c5..c082a0359064 100644 > --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c > +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c > @@ -6,10 +6,10 @@ > ******************************************************************************/ > #include <drv_types.h> > > -/* > -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE > -* @return: one of RTW_STATUS_CODE > -*/ > +/** > + * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE > + * @return: one of RTW_STATUS_CODE > + */ > inline int RTW_STATUS_CODE(int error_code) > { > if (error_code >= 0) > @@ -152,7 +152,6 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8 *src, u32 src_len) > kfree(ori); > } > > - > /** > * rtw_cbuf_full - test if cbuf is full > * @cbuf: pointer of struct rtw_cbuf > @@ -204,6 +203,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf) > void *rtw_cbuf_pop(struct rtw_cbuf *cbuf) > { > void *buf; > + > if (rtw_cbuf_empty(cbuf)) > return NULL; > > @@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size) > cbuf = rtw_malloc(struct_size(cbuf, bufs, size)); > > if (cbuf) { > - cbuf->write = cbuf->read = 0; > + cbuf->write = 0; > + cbuf->read = 0; > cbuf->size = size; > } > > -- > 2.43.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c 2026-01-09 9:38 [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c Nayana Mariyappa 2026-01-09 9:43 ` Greg Kroah-Hartman @ 2026-01-10 8:41 ` kernel test robot 1 sibling, 0 replies; 3+ messages in thread From: kernel test robot @ 2026-01-10 8:41 UTC (permalink / raw) To: Nayana Mariyappa, Greg Kroah-Hartman Cc: oe-kbuild-all, linux-staging, linux-kernel, Nayana Mariyappa Hi Nayana, kernel test robot noticed the following build warnings: [auto build test WARNING on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Nayana-Mariyappa/staging-rtl8723bs-fix-coding-style-issues-in-osdep_service-c/20260109-174134 base: staging/staging-testing patch link: https://lore.kernel.org/r/20260109093801.15334-1-nayana.mariyappa%40gmail.com patch subject: [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20260110/202601101642.PaiOTqlr-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260110/202601101642.PaiOTqlr-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202601101642.PaiOTqlr-lkp@intel.com/ All warnings (new ones prefixed by >>): >> Warning: drivers/staging/rtl8723bs/os_dep/osdep_service.c:9 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-10 8:41 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-09 9:38 [PATCH] staging: rtl8723bs: fix coding style issues in osdep_service.c Nayana Mariyappa 2026-01-09 9:43 ` Greg Kroah-Hartman 2026-01-10 8:41 ` kernel test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox