Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: 2023060904@ycu.edu.cn
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	guagua210311@qq.com
Subject: Re: [PATCH 1/3] rtl8723bs: io: Add independent rtw_check_continual_io_error function
Date: Sat, 10 Jan 2026 14:22:38 +0100	[thread overview]
Message-ID: <2026011019-worried-monstrous-7837@gregkh> (raw)
In-Reply-To: <EE88D4787656615D+20260110101801.5820-2-2023060904@ycu.edu.cn>

On Sat, Jan 10, 2026 at 06:17:58PM +0800, 2023060904@ycu.edu.cn wrote:
> From: changjunzheng <guagua210311@qq.com>

Please use your real name (either in native characters, or not, but with
spaces where correct.)

> Add a new function to check if the error count exceeds the MAX_CONTINUAL_IO_ERR
> threshold. This function follows the single responsibility principle and
> prepares for the subsequent removal of the global continual_io_error variable.
> 
> Changelog v3 -> v4:
> 1. Split the single v3 patch into 4 logical patches (per Greg KH's request)
> 2. Fix all coding style errors (trailing spaces, missing assignment spaces, indentation)
> 3. Add clear, purpose-driven commit messages for each patch
> 4. Add version changelog as required by kernel documentation
> 5. Add blank line before new function declaration to comply with coding style

I think my bot pointed you at the documentation, that says this all goes
below the --- line, right?

And what about the changes from 1 -> 2 and 2 -> 3?

Please fix up and resend a new series (v5?)

Also, the subject line does not have the version in it :(

thanks,

greg k-h

  reply	other threads:[~2026-01-10 20:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260110101801.5820-1-2023060904@ycu.edu.cn>
2026-01-10 10:17 ` [PATCH 1/3] rtl8723bs: io: Add independent rtw_check_continual_io_error function 2023060904
2026-01-10 13:22   ` Greg KH [this message]
2026-01-10 10:17 ` [PATCH 2/3] rtl8723bs: sdio: Use local error_count instead of global variable 2023060904
2026-01-10 13:24   ` Greg KH
2026-01-10 10:18 ` [PATCH 3/3] rtl8723bs: io: Remove redundant global continual_io_error variable 2023060904

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026011019-worried-monstrous-7837@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=2023060904@ycu.edu.cn \
    --cc=guagua210311@qq.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox