From: Greg KH <gregkh@linuxfoundation.org>
To: Anubhav Kokane <dev.anubhavk@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix comparison order in rtw_ieee80211.c
Date: Sun, 11 Jan 2026 14:00:24 +0100 [thread overview]
Message-ID: <2026011107-confetti-fender-fe89@gregkh> (raw)
In-Reply-To: <20260111090034.9323-1-dev.anubhavk@gmail.com>
On Sun, Jan 11, 2026 at 09:00:34AM +0000, Anubhav Kokane wrote:
> Fix checkpatch warning: "Comparisons should place the constant on the
> right side of the test".
>
> Move the constant _SUCCESS to the right side of the comparison
> operator.
>
> Also fix whitespace around binary operator '+' and wrap lines to fit
> coding style limits.
>
> Signed-off-by: Anubhav Kokane <dev.anubhavk@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 8fdeeda88..f45ae5d5f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1009,7 +1009,8 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)
> pbuf = rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork->network.ie_length-12);
>
> if (pbuf && (wpa_ielen > 0)) {
> - if (_SUCCESS == rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x)) {
> + if (rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher,
> + &pairwise_cipher, &is8021x) == _SUCCESS) {
> pnetwork->bcn_info.pairwise_cipher = pairwise_cipher;
> pnetwork->bcn_info.group_cipher = group_cipher;
> pnetwork->bcn_info.is_8021x = is8021x;
> @@ -1019,7 +1020,8 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)
> pbuf = rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork->network.ie_length-12);
>
> if (pbuf && (wpa_ielen > 0)) {
> - if (_SUCCESS == rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher, &pairwise_cipher, &is8021x)) {
> + if (rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher,
> + &pairwise_cipher, &is8021x) == _SUCCESS) {
> pnetwork->bcn_info.pairwise_cipher = pairwise_cipher;
> pnetwork->bcn_info.group_cipher = group_cipher;
> pnetwork->bcn_info.is_8021x = is8021x;
> --
> 2.43.0
>
>
Does not apply to my tree anymore, due to someone else sending this
same change right before you did, sorry.
greg k-h
prev parent reply other threads:[~2026-01-11 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 9:00 [PATCH] staging: rtl8723bs: fix comparison order in rtw_ieee80211.c Anubhav Kokane
2026-01-11 13:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011107-confetti-fender-fe89@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dev.anubhavk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox