* [PATCH] staging: sm750fb: make g_fbmode a fixed-size mutable array
@ 2026-01-09 16:41 Ahmet Sezgin Duran
2026-01-11 12:59 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ahmet Sezgin Duran @ 2026-01-09 16:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, ahmet
g_fbmode is modified at runtime. Use an explicit fixed-size array to
avoid a misleading checkpatch warning.
No functional changes.
Signed-off-by: Ahmet Sezgin Duran <ahmet@sezginduran.net>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index d100b9e1d3d5..8f8feb73f61b 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char *g_fbmode[2] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: make g_fbmode a fixed-size mutable array
2026-01-09 16:41 [PATCH] staging: sm750fb: make g_fbmode a fixed-size mutable array Ahmet Sezgin Duran
@ 2026-01-11 12:59 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-01-11 12:59 UTC (permalink / raw)
To: Ahmet Sezgin Duran; +Cc: linux-staging, linux-kernel
On Fri, Jan 09, 2026 at 04:41:40PM +0000, Ahmet Sezgin Duran wrote:
> g_fbmode is modified at runtime. Use an explicit fixed-size array to
> avoid a misleading checkpatch warning.
Nah, checkpatch is wrong here. And it is a great test to see if people
actually build the changes they want us to accept, so I'll leave the
code as-is for now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-11 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 16:41 [PATCH] staging: sm750fb: make g_fbmode a fixed-size mutable array Ahmet Sezgin Duran
2026-01-11 12:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox