From: Greg KH <gregkh@linuxfoundation.org>
To: Nayana Mariyappa <nayana.mariyappa@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/4] staging: rtl8723bs: fix block comment style
Date: Mon, 12 Jan 2026 10:32:21 +0100 [thread overview]
Message-ID: <2026011200-rudder-amino-445a@gregkh> (raw)
In-Reply-To: <20260112043429.42615-2-nayana.mariyappa@gmail.com>
On Mon, Jan 12, 2026 at 04:34:26AM +0000, Nayana Mariyappa wrote:
> Fixed multi-line block comments in osdep_service.c to follow kernel
> coding style.
> No functional change.
>
> Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/osdep_service.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index a00f9f0c85c5..8f6dd3560303 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -6,10 +6,10 @@
> ******************************************************************************/
> #include <drv_types.h>
>
> -/*
> -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> -* @return: one of RTW_STATUS_CODE
> -*/
> +/**
Nit, this shouldn't be /**, but rather /* as before, as this is not a
valid kernel doc comment.
If you want to turn it into a kernel-doc statement, like I think
checkpatch is warning you about, then please do so, with the full
function name and arguments documented. But I really doubt this is
needed at all, but rather this can just be a one line comment instead.
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-12 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 4:34 [PATCH v2 0/4] staging: rtl8723bs: coding style fixes Nayana Mariyappa
2026-01-12 4:34 ` [PATCH v2 1/4] staging: rtl8723bs: fix block comment style Nayana Mariyappa
2026-01-12 9:32 ` Greg KH [this message]
2026-01-12 4:34 ` [PATCH v2 2/4] staging: rtl8723bs: remove extra blank lines Nayana Mariyappa
2026-01-12 4:34 ` [PATCH v2 3/4] staging: rtl8723bs: add blank lines after declarations Nayana Mariyappa
2026-01-12 4:34 ` [PATCH v2 4/4] staging: rtl8723bs: expand multiple assignment into separate statements Nayana Mariyappa
2026-01-12 9:33 ` [PATCH v2 0/4] staging: rtl8723bs: coding style fixes Greg KH
2026-01-12 10:48 ` Nayana Mariyappa
-- strict thread matches above, loose matches on Subject: below --
2026-01-09 11:04 Nayana Mariyappa
2026-01-09 11:04 ` [PATCH v2 1/4] staging: rtl8723bs: fix block comment style Nayana Mariyappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011200-rudder-amino-445a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nayana.mariyappa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox