From: Karthikey Kadati <karthikey3608@gmail.com>
To: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org,
gregkh@linuxfoundation.org
Cc: sakari.ailus@linux.intel.com, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev,
Karthikey Kadati <karthikey3608@gmail.com>
Subject: [PATCH v3 1/2] staging: atomisp: Remove input_system typedefs
Date: Mon, 12 Jan 2026 16:14:04 +0530 [thread overview]
Message-ID: <20260112104405.24377-1-karthikey3608@gmail.com> (raw)
Remove input_system_channel_t and input_system_input_port_t typedefs.
Replace usages with struct input_system_channel and
struct input_system_input_port respectively.
Signed-off-by: Karthikey Kadati <karthikey3608@gmail.com>
---
.../atomisp/pci/isp2401_input_system_global.h | 12 ++--
.../pci/runtime/isys/src/virtual_isys.c | 56 +++++++++----------
drivers/staging/media/atomisp/pci/sh_css.c | 4 +-
3 files changed, 35 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp2401_input_system_global.h b/drivers/staging/media/atomisp/pci/isp2401_input_system_global.h
index 4aadeb133..bce8aa999 100644
--- a/drivers/staging/media/atomisp/pci/isp2401_input_system_global.h
+++ b/drivers/staging/media/atomisp/pci/isp2401_input_system_global.h
@@ -34,8 +34,7 @@ typedef enum {
N_INPUT_SYSTEM_SOURCE_TYPE
} input_system_source_type_t;
-typedef struct input_system_channel_s input_system_channel_t;
-struct input_system_channel_s {
+struct input_system_channel {
stream2mmio_ID_t stream2mmio_id;
stream2mmio_sid_ID_t stream2mmio_sid_id;
@@ -55,8 +54,7 @@ struct input_system_channel_cfg_s {
isys2401_dma_port_cfg_t dma_dest_port_cfg;
};
-typedef struct input_system_input_port_s input_system_input_port_t;
-struct input_system_input_port_s {
+struct input_system_input_port {
input_system_source_type_t source_type;
struct {
@@ -141,9 +139,9 @@ struct virtual_input_system_stream_s {
Must be unique within one CSI RX
and lower than SH_CSS_MAX_ISYS_CHANNEL_NODES */
u8 enable_metadata;
- input_system_input_port_t input_port;
- input_system_channel_t channel;
- input_system_channel_t md_channel; /* metadata channel */
+ struct input_system_input_port input_port;
+ struct input_system_channel channel;
+ struct input_system_channel md_channel; /* metadata channel */
u8 online;
s8 linked_isys_stream_id;
u8 valid;
diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c
index e6c11d5f7..291b2fb33 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/virtual_isys.c
@@ -26,28 +26,28 @@
static bool create_input_system_channel(
isp2401_input_system_cfg_t *cfg,
bool metadata,
- input_system_channel_t *channel);
+ struct input_system_channel *channel);
static void destroy_input_system_channel(
- input_system_channel_t *channel);
+ struct input_system_channel *channel);
static bool create_input_system_input_port(
isp2401_input_system_cfg_t *cfg,
- input_system_input_port_t *input_port);
+ struct input_system_input_port *input_port);
static void destroy_input_system_input_port(
- input_system_input_port_t *input_port);
+ struct input_system_input_port *input_port);
static bool calculate_input_system_channel_cfg(
- input_system_channel_t *channel,
- input_system_input_port_t *input_port,
+ struct input_system_channel *channel,
+ struct input_system_input_port *input_port,
isp2401_input_system_cfg_t *isys_cfg,
input_system_channel_cfg_t *channel_cfg,
bool metadata);
static bool calculate_input_system_input_port_cfg(
- input_system_channel_t *channel,
- input_system_input_port_t *input_port,
+ struct input_system_channel *channel,
+ struct input_system_input_port *input_port,
isp2401_input_system_cfg_t *isys_cfg,
input_system_input_port_cfg_t *input_port_cfg);
@@ -89,8 +89,8 @@ static void release_be_lut_entry(
csi_rx_backend_lut_entry_t *entry);
static bool calculate_prbs_cfg(
- input_system_channel_t *channel,
- input_system_input_port_t *input_port,
+ struct input_system_channel *channel,
+ struct input_system_input_port *input_port,
isp2401_input_system_cfg_t *isys_cfg,
pixelgen_prbs_cfg_t *cfg);
@@ -99,7 +99,7 @@ static bool calculate_fe_cfg(
csi_rx_frontend_cfg_t *cfg);
static bool calculate_be_cfg(
- const input_system_input_port_t *input_port,
+ const struct input_system_input_port *input_port,
const isp2401_input_system_cfg_t *isys_cfg,
bool metadata,
csi_rx_backend_cfg_t *cfg);
@@ -110,13 +110,13 @@ static bool calculate_stream2mmio_cfg(
stream2mmio_cfg_t *cfg);
static bool calculate_ibuf_ctrl_cfg(
- const input_system_channel_t *channel,
- const input_system_input_port_t *input_port,
+ const struct input_system_channel *channel,
+ const struct input_system_input_port *input_port,
const isp2401_input_system_cfg_t *isys_cfg,
ibuf_ctrl_cfg_t *cfg);
static bool calculate_isys2401_dma_cfg(
- const input_system_channel_t *channel,
+ const struct input_system_channel *channel,
const isp2401_input_system_cfg_t *isys_cfg,
isys2401_dma_cfg_t *cfg);
@@ -263,7 +263,7 @@ ia_css_isys_error_t ia_css_isys_stream_calculate_cfg(
static bool create_input_system_channel(
isp2401_input_system_cfg_t *cfg,
bool metadata,
- input_system_channel_t *me)
+ struct input_system_channel *me)
{
bool rc = true;
@@ -324,7 +324,7 @@ static bool create_input_system_channel(
}
static void destroy_input_system_channel(
- input_system_channel_t *me)
+ struct input_system_channel *me)
{
release_sid(me->stream2mmio_id,
&me->stream2mmio_sid_id);
@@ -336,7 +336,7 @@ static void destroy_input_system_channel(
static bool create_input_system_input_port(
isp2401_input_system_cfg_t *cfg,
- input_system_input_port_t *me)
+ struct input_system_input_port *me)
{
csi_mipi_packet_type_t packet_type;
bool rc = true;
@@ -410,7 +410,7 @@ static bool create_input_system_input_port(
}
static void destroy_input_system_input_port(
- input_system_input_port_t *me)
+ struct input_system_input_port *me)
{
if (me->source_type == INPUT_SYSTEM_SOURCE_TYPE_SENSOR) {
release_be_lut_entry(
@@ -429,8 +429,8 @@ static void destroy_input_system_input_port(
}
static bool calculate_input_system_channel_cfg(
- input_system_channel_t *channel,
- input_system_input_port_t *input_port,
+ struct input_system_channel *channel,
+ struct input_system_input_port *input_port,
isp2401_input_system_cfg_t *isys_cfg,
input_system_channel_cfg_t *channel_cfg,
bool metadata)
@@ -480,8 +480,8 @@ static bool calculate_input_system_channel_cfg(
}
static bool calculate_input_system_input_port_cfg(
- input_system_channel_t *channel,
- input_system_input_port_t *input_port,
+ struct input_system_channel *channel,
+ struct input_system_input_port *input_port,
isp2401_input_system_cfg_t *isys_cfg,
input_system_input_port_cfg_t *input_port_cfg)
{
@@ -613,8 +613,8 @@ static void release_be_lut_entry(
}
static bool calculate_prbs_cfg(
- input_system_channel_t *channel,
- input_system_input_port_t *input_port,
+ struct input_system_channel *channel,
+ struct input_system_input_port *input_port,
isp2401_input_system_cfg_t *isys_cfg,
pixelgen_prbs_cfg_t *cfg)
{
@@ -632,7 +632,7 @@ static bool calculate_fe_cfg(
}
static bool calculate_be_cfg(
- const input_system_input_port_t *input_port,
+ const struct input_system_input_port *input_port,
const isp2401_input_system_cfg_t *isys_cfg,
bool metadata,
csi_rx_backend_cfg_t *cfg)
@@ -677,8 +677,8 @@ static bool calculate_stream2mmio_cfg(
}
static bool calculate_ibuf_ctrl_cfg(
- const input_system_channel_t *channel,
- const input_system_input_port_t *input_port,
+ const struct input_system_channel *channel,
+ const struct input_system_input_port *input_port,
const isp2401_input_system_cfg_t *isys_cfg,
ibuf_ctrl_cfg_t *cfg)
{
@@ -759,7 +759,7 @@ static bool calculate_ibuf_ctrl_cfg(
}
static bool calculate_isys2401_dma_cfg(
- const input_system_channel_t *channel,
+ const struct input_system_channel *channel,
const isp2401_input_system_cfg_t *isys_cfg,
isys2401_dma_cfg_t *cfg)
{
diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c
index 73bd87f43..ec4d15ffe 100644
--- a/drivers/staging/media/atomisp/pci/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/sh_css.c
@@ -665,7 +665,7 @@ static bool sh_css_translate_stream_cfg_to_input_system_input_port_id(
return rc;
}
-static bool sh_css_translate_stream_cfg_to_input_system_input_port_type(
+static bool sh_css_translate_stream_cfg_to_struct input_system_input_portype(
struct ia_css_stream_config *stream_cfg,
ia_css_isys_descr_t *isys_stream_descr)
{
@@ -852,7 +852,7 @@ static bool sh_css_translate_stream_cfg_to_isys_stream_descr(
"sh_css_translate_stream_cfg_to_isys_stream_descr() enter:\n");
rc = sh_css_translate_stream_cfg_to_input_system_input_port_id(stream_cfg,
isys_stream_descr);
- rc &= sh_css_translate_stream_cfg_to_input_system_input_port_type(stream_cfg,
+ rc &= sh_css_translate_stream_cfg_to_struct input_system_input_portype(stream_cfg,
isys_stream_descr);
rc &= sh_css_translate_stream_cfg_to_input_system_input_port_attr(stream_cfg,
isys_stream_descr, isys_stream_idx);
--
2.43.0
next reply other threads:[~2026-01-12 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 10:44 Karthikey Kadati [this message]
2026-01-12 10:57 ` [PATCH v3 1/2] staging: atomisp: Remove input_system typedefs Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112104405.24377-1-karthikey3608@gmail.com \
--to=karthikey3608@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox