* [PATCH v2 0/1] staging: rtl8723bs: style cleanups in rtw_mlme.c @ 2026-01-11 23:43 Lorenzo Simonelli 2026-01-11 23:43 ` [PATCH v2 1/1] " Lorenzo Simonelli 0 siblings, 1 reply; 7+ messages in thread From: Lorenzo Simonelli @ 2026-01-11 23:43 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Lorenzo Simonelli This series contains style cleanups for the rtl8723bs driver. The changes focus on removing unnecessary comparisons and trailing whitespaces in rtw_mlme.c. Signed-off-by: Lorenzo Simonelli <lorenzosimonelli02@gmail.com> --- v2: - Dropped the patch for sm750fb due to build regression. - Consolidated remaining style cleanups into a single patch. - Verified build with make M=drivers/staging/rtl8723bs/ Lorenzo Simonelli (1): staging: rtl8723bs: style cleanups in rtw_mlme.c drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.52.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/1] staging: rtl8723bs: style cleanups in rtw_mlme.c 2026-01-11 23:43 [PATCH v2 0/1] staging: rtl8723bs: style cleanups in rtw_mlme.c Lorenzo Simonelli @ 2026-01-11 23:43 ` Lorenzo Simonelli 2026-01-12 6:48 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Lorenzo Simonelli @ 2026-01-11 23:43 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Lorenzo Simonelli --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179a..d9e6778e1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -468,11 +468,11 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); - - if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { + if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length); + pmlmepriv->cur_network.network.ie_length); } } @@ -710,7 +710,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (check_fwstate(pmlmepriv, _FW_LINKED) == false) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); @@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) spin_lock_bh(&pmlmepriv->lock); - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (adapter->stapriv.asoc_sta_count == 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address); @@ -2018,7 +2018,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ return ielength; } -/* Ported from 8185: IsInPreAuthKeyList(). +/* Ported from 8185: IsInPreAuthKeyList(). * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.) * Added by Annie, 2006-05-07. * -- 2.52.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] staging: rtl8723bs: style cleanups in rtw_mlme.c 2026-01-11 23:43 ` [PATCH v2 1/1] " Lorenzo Simonelli @ 2026-01-12 6:48 ` Greg KH 0 siblings, 0 replies; 7+ messages in thread From: Greg KH @ 2026-01-12 6:48 UTC (permalink / raw) To: Lorenzo Simonelli; +Cc: linux-staging, linux-kernel On Mon, Jan 12, 2026 at 12:43:42AM +0100, Lorenzo Simonelli wrote: > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 98704179a..d9e6778e1 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -468,11 +468,11 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex > &pmlmepriv->cur_network.network, > &pmlmepriv->cur_network.network, > &pmlmepriv->cur_network.network); > - > - if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { > + if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && > + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { > update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); > rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie), > - pmlmepriv->cur_network.network.ie_length); > + pmlmepriv->cur_network.network.ie_length); > } > } > > @@ -710,7 +710,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) > rtw_set_signal_stat_timer(&adapter->recvpriv); > > if (pmlmepriv->to_join) { > - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { > + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { > if (check_fwstate(pmlmepriv, _FW_LINKED) == false) { > set_fwstate(pmlmepriv, _FW_UNDER_LINKING); > > @@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) > > spin_lock_bh(&pmlmepriv->lock); > > - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) || > - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { > + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || > + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { > if (adapter->stapriv.asoc_sta_count == 2) { > spin_lock_bh(&pmlmepriv->scanned_queue.lock); > ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address); > @@ -2018,7 +2018,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ > return ielength; > } > > -/* Ported from 8185: IsInPreAuthKeyList(). > +/* Ported from 8185: IsInPreAuthKeyList(). > * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.) > * Added by Annie, 2006-05-07. > * > -- > 2.52.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/process/submitting-patches.rst and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 0/1] staging: rtl8723bs: style cleanups in rtw_mlme.c @ 2026-01-12 9:05 Lorenzo Simonelli 2026-01-12 9:05 ` [PATCH v2 1/1] " Lorenzo Simonelli 0 siblings, 1 reply; 7+ messages in thread From: Lorenzo Simonelli @ 2026-01-12 9:05 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Lorenzo Simonelli This series contains style cleanups for the rtl8723bs driver. The changes focus on removing unnecessary comparisons and trailing whitespaces in rtw_mlme.c. Signed-off-by: Lorenzo Simonelli <lorenzosimonelli02@gmail.com> --- v2: - Dropped the patch for sm750fb due to build regression. - Consolidated remaining style cleanups into a single patch. - Verified build with make M=drivers/staging/rtl8723bs/ Lorenzo Simonelli (1): staging: rtl8723bs: style cleanups in rtw_mlme.c drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.52.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/1] staging: rtl8723bs: style cleanups in rtw_mlme.c 2026-01-12 9:05 [PATCH v2 0/1] " Lorenzo Simonelli @ 2026-01-12 9:05 ` Lorenzo Simonelli 2026-01-12 8:14 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Lorenzo Simonelli @ 2026-01-12 9:05 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Lorenzo Simonelli This patch performs style cleanups in rtw_mlme.c, specifically removing unnecessary boolean comparisons and trailing whitespaces. These changes improve adherence to the kernel coding style. Signed-off-by: Lorenzo Simonelli <lorenzosimonelli02@gmail.com> --- v2: - Dropped the patch for sm750fb due to build regression. - Consolidated remaining style cleanups into this single patch. - Verified build for rtl8723bs/core/rtw_mlme.o drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179a..d9e6778e1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -468,11 +468,11 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); - - if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { + if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length); + pmlmepriv->cur_network.network.ie_length); } } @@ -710,7 +710,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (check_fwstate(pmlmepriv, _FW_LINKED) == false) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); @@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) spin_lock_bh(&pmlmepriv->lock); - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (adapter->stapriv.asoc_sta_count == 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address); @@ -2018,7 +2018,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ return ielength; } -/* Ported from 8185: IsInPreAuthKeyList(). +/* Ported from 8185: IsInPreAuthKeyList(). * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.) * Added by Annie, 2006-05-07. * -- 2.52.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] staging: rtl8723bs: style cleanups in rtw_mlme.c 2026-01-12 9:05 ` [PATCH v2 1/1] " Lorenzo Simonelli @ 2026-01-12 8:14 ` Greg KH 0 siblings, 0 replies; 7+ messages in thread From: Greg KH @ 2026-01-12 8:14 UTC (permalink / raw) To: Lorenzo Simonelli; +Cc: linux-staging, linux-kernel On Mon, Jan 12, 2026 at 10:05:46AM +0100, Lorenzo Simonelli wrote: > This patch performs style cleanups in rtw_mlme.c, specifically > removing unnecessary boolean comparisons and trailing whitespaces. > These changes improve adherence to the kernel coding style. > > Signed-off-by: Lorenzo Simonelli <lorenzosimonelli02@gmail.com> > > --- > v2: > - Dropped the patch for sm750fb due to build regression. > - Consolidated remaining style cleanups into this single patch. As my bot said, you need to do only one-logical-thing per patch. That is not what is happening here :( Please break this up into multiple patches. thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 0/1] staging: rtl8723bs: style cleanups in rtw_mlme.c @ 2026-01-11 14:29 Lorenzo Simonelli 2026-01-11 14:29 ` [PATCH v2 1/1] " Lorenzo Simonelli 0 siblings, 1 reply; 7+ messages in thread From: Lorenzo Simonelli @ 2026-01-11 14:29 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Lorenzo Simonelli This second version of the series drops the patch for sm750fb as it introduced a build regression (pointed out by Greg K-H). This version focuses only on verified style cleanups for rtl8723bs. Changes in v2: - Dropped patch: "staging: sm750fb: fix static const char array warning" - Verified build for rtl8723bs/core/rtw_mlme.o Lorenzo Simonelli (1): staging: rtl8723bs: style cleanups in rtw_mlme.c drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.52.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/1] staging: rtl8723bs: style cleanups in rtw_mlme.c 2026-01-11 14:29 [PATCH v2 0/1] " Lorenzo Simonelli @ 2026-01-11 14:29 ` Lorenzo Simonelli 2026-01-11 13:50 ` Greg KH 0 siblings, 1 reply; 7+ messages in thread From: Lorenzo Simonelli @ 2026-01-11 14:29 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Lorenzo Simonelli --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 98704179a..d9e6778e1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -468,11 +468,11 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); - - if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { + if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length); + pmlmepriv->cur_network.network.ie_length); } } @@ -710,7 +710,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (check_fwstate(pmlmepriv, _FW_LINKED) == false) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); @@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) spin_lock_bh(&pmlmepriv->lock); - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (adapter->stapriv.asoc_sta_count == 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address); @@ -2018,7 +2018,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ return ielength; } -/* Ported from 8185: IsInPreAuthKeyList(). +/* Ported from 8185: IsInPreAuthKeyList(). * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.) * Added by Annie, 2006-05-07. * -- 2.52.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] staging: rtl8723bs: style cleanups in rtw_mlme.c 2026-01-11 14:29 ` [PATCH v2 1/1] " Lorenzo Simonelli @ 2026-01-11 13:50 ` Greg KH 0 siblings, 0 replies; 7+ messages in thread From: Greg KH @ 2026-01-11 13:50 UTC (permalink / raw) To: Lorenzo Simonelli; +Cc: linux-staging, linux-kernel On Sun, Jan 11, 2026 at 03:29:17PM +0100, Lorenzo Simonelli wrote: > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index 98704179a..d9e6778e1 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -468,11 +468,11 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex > &pmlmepriv->cur_network.network, > &pmlmepriv->cur_network.network, > &pmlmepriv->cur_network.network); > - > - if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { > + if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && > + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { > update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); > rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie), > - pmlmepriv->cur_network.network.ie_length); > + pmlmepriv->cur_network.network.ie_length); > } > } > > @@ -710,7 +710,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) > rtw_set_signal_stat_timer(&adapter->recvpriv); > > if (pmlmepriv->to_join) { > - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { > + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { > if (check_fwstate(pmlmepriv, _FW_LINKED) == false) { > set_fwstate(pmlmepriv, _FW_UNDER_LINKING); > > @@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) > > spin_lock_bh(&pmlmepriv->lock); > > - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) || > - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { > + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || > + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { > if (adapter->stapriv.asoc_sta_count == 2) { > spin_lock_bh(&pmlmepriv->scanned_queue.lock); > ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address); > @@ -2018,7 +2018,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ > return ielength; > } > > -/* Ported from 8185: IsInPreAuthKeyList(). > +/* Ported from 8185: IsInPreAuthKeyList(). > * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.) > * Added by Annie, 2006-05-07. > * > -- > 2.52.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/process/submitting-patches.rst and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-01-12 8:14 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-11 23:43 [PATCH v2 0/1] staging: rtl8723bs: style cleanups in rtw_mlme.c Lorenzo Simonelli 2026-01-11 23:43 ` [PATCH v2 1/1] " Lorenzo Simonelli 2026-01-12 6:48 ` Greg KH -- strict thread matches above, loose matches on Subject: below -- 2026-01-12 9:05 [PATCH v2 0/1] " Lorenzo Simonelli 2026-01-12 9:05 ` [PATCH v2 1/1] " Lorenzo Simonelli 2026-01-12 8:14 ` Greg KH 2026-01-11 14:29 [PATCH v2 0/1] " Lorenzo Simonelli 2026-01-11 14:29 ` [PATCH v2 1/1] " Lorenzo Simonelli 2026-01-11 13:50 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox