From: Greg KH <gregkh@linuxfoundation.org>
To: Nayana Mariyappa <nayana.mariyappa@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v4 1/4] staging: rtl8723bs: fix block comment style
Date: Mon, 12 Jan 2026 11:57:20 +0100 [thread overview]
Message-ID: <2026011246-both-jovial-afee@gregkh> (raw)
In-Reply-To: <20260112104654.45175-2-nayana.mariyappa@gmail.com>
On Mon, Jan 12, 2026 at 10:46:51AM +0000, Nayana Mariyappa wrote:
> Fixed multi-line block comments in osdep_service.c to follow kernel
> coding style. Fixing the non-kernel-doc comment has been merged into this
> patch.
> No functional change.
>
> Signed-off-by: Nayana Mariyappa <nayana.mariyappa@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/osdep_service.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index a00f9f0c85c5..9d676a61981c 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -7,9 +7,9 @@
> #include <drv_types.h>
>
> /*
> -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> -* @return: one of RTW_STATUS_CODE
> -*/
> + * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> + * @return: one of RTW_STATUS_CODE
> + */
> inline int RTW_STATUS_CODE(int error_code)
> {
> if (error_code >= 0)
> --
> 2.43.0
>
You seem to have ignored my review comment where I asked this just to be
one line. No need to have the @return: stuff, right?
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-12 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 10:46 [PATCH v4 0/4] staging: rtl8723bs: coding style fixes Nayana Mariyappa
2026-01-12 10:46 ` [PATCH v4 1/4] staging: rtl8723bs: fix block comment style Nayana Mariyappa
2026-01-12 10:57 ` Greg KH [this message]
2026-01-12 10:46 ` [PATCH v4 2/4] staging: rtl8723bs: remove extra blank lines Nayana Mariyappa
2026-01-12 10:46 ` [PATCH v4 3/4] staging: rtl8723bs: add blank lines after declarations Nayana Mariyappa
2026-01-12 10:46 ` [PATCH v4 4/4] staging: rtl8723bs: expand multiple assignment into separate statements Nayana Mariyappa
2026-01-12 10:56 ` [PATCH v4 0/4] staging: rtl8723bs: coding style fixes Greg KH
2026-01-12 11:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011246-both-jovial-afee@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nayana.mariyappa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox