From: Greg KH <gregkh@linuxfoundation.org>
To: Archit Anant <architanant5@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: fix spacing around operators
Date: Fri, 16 Jan 2026 14:07:58 +0100 [thread overview]
Message-ID: <2026011631-hungry-uncouth-0d0b@gregkh> (raw)
In-Reply-To: <20260114094949.14825-2-architanant5@gmail.com>
On Wed, Jan 14, 2026 at 03:19:47PM +0530, Archit Anant wrote:
> From: ArchitAnant <architanant5@gmail.com>
>
> Add missing spaces around mathematical and logical operators
> (+, -, /, |, ?, :) to comply with the Linux kernel coding style.
>
> Issue identified by checkpatch.pl.
>
> Signed-off-by: ArchitAnant <architanant5@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 28 ++++++++++++------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b5588a..03274738c94e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -175,7 +175,7 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
> if (!pcmdpriv->cmd_allocated_buf)
> return -ENOMEM;
>
> - pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf + CMDBUFF_ALIGN_SZ - ((SIZE_PTR)(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ-1));
> + pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf + CMDBUFF_ALIGN_SZ - ((SIZE_PTR)(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ - 1));
Why are there additional ' ' around the first '+' character?
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-16 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 9:49 [PATCH 0/3] staging: rtl8723bs: fix multiple coding style issues Archit Anant
2026-01-14 9:49 ` [PATCH 1/3] staging: rtl8723bs: fix spacing around operators Archit Anant
2026-01-16 13:07 ` Greg KH [this message]
2026-01-14 9:49 ` [PATCH 2/3] staging: rtl8723bs: remove unnecessary blank lines Archit Anant
2026-01-14 9:49 ` [PATCH 3/3] staging: rtl8723bs: fix alignment to match open parenthesis Archit Anant
2026-01-16 13:08 ` [PATCH 0/3] staging: rtl8723bs: fix multiple coding style issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011631-hungry-uncouth-0d0b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=architanant5@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox