From: Greg KH <gregkh@linuxfoundation.org>
To: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: rtl8723bs: fix line length check
Date: Tue, 27 Jan 2026 15:40:31 +0100 [thread overview]
Message-ID: <2026012713-bovine-tricolor-d747@gregkh> (raw)
In-Reply-To: <ff17af4290ee04d9a6c57777c7387c782bb779e7.1768736361.git.mahad.ibrahim.dev@gmail.com>
On Sun, Jan 18, 2026 at 04:54:45PM +0500, Mahad Ibrahim wrote:
> Fix checkpatch.pl check regarding:
> - Line length of X exceeds 100 columns
>
> Redistribute comments to multiple lines to adhere to kernel coding
> standards.
>
> Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
> index b7176a992518..fb108492efac 100644
> --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
> +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c
> @@ -60,7 +60,8 @@ static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, const
> if ((cond1 & BIT3) != 0) /* APA */
> bitMask |= 0xFF000000;
>
> - if ((cond2 & bitMask) == (driver2 & bitMask)) /* BoardType of each RF path is matched */
> + /* BoardType of each RF path is matched */
Why the extra space after /* and before BoardType?
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-27 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 11:54 [PATCH v2 0/4] staging: rtl8723bs: fix remaining checkpatch.pl Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 1/4] staging: rtl8723bs: fix open parenthesis alignment Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 2/4] staging: rtl8723bs: fix multiple blank line check Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 3/4] staging: rtl8723bs: fix missing blank line after declaration Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 4/4] staging: rtl8723bs: fix line length check Mahad Ibrahim
2026-01-27 14:40 ` Greg KH [this message]
2026-01-28 16:09 ` Mahad Ibrahim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026012713-bovine-tricolor-d747@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mahad.ibrahim.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox