From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Huang <tehsiu.huang@gmail.com>
Cc: dan.carpenter@linaro.org, straube.linux@gmail.com,
hansg@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: remove unnecessary boolean comparisons and whitespaces
Date: Tue, 27 Jan 2026 15:42:43 +0100 [thread overview]
Message-ID: <2026012726-connected-eloquence-572b@gregkh> (raw)
In-Reply-To: <20260123095733.49301-2-tehsiu.huang@gmail.com>
On Fri, Jan 23, 2026 at 01:57:32AM -0800, Michael Huang wrote:
> According to the kernel coding style, explicit comparisons with true
> or false are redundant and should be avoided. This patch removes these
> comparisons in rtw_mlme.c to improve code clarity. Additionally,
> trailing whitespaces are removed to satisfy checkpatch.pl requirements.
That is two different things in one patch, please do not do that.
Remember, only one logical change per patch.
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-27 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 0:32 [PATCH] staging: rtl8723bs: fix coding style issues in rtw_mlme.c Michael Huang
2026-01-23 8:57 ` Dan Carpenter
2026-01-23 9:57 ` [PATCH v2 0/2] staging: rtl8723bs: fix coding style and logic " Michael Huang
2026-01-23 9:57 ` [PATCH v2 1/2] staging: rtl8723bs: remove unnecessary boolean comparisons and whitespaces Michael Huang
2026-01-27 14:42 ` Greg KH [this message]
2026-01-23 9:57 ` [PATCH v2 2/2] staging: rtl8723bs: remove redundant else after break Michael Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026012726-connected-eloquence-572b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
--cc=tehsiu.huang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox