From: Ethan Tidmore <ethantidmore06@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Ethan Tidmore <ethantidmore06@gmail.com>
Subject: [PATCH v2 1/4] staging: rtl8723bs: remove dead RX info reset logic
Date: Tue, 27 Jan 2026 18:40:05 -0600 [thread overview]
Message-ID: <20260128004009.51095-2-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260128004009.51095-1-ethantidmore06@gmail.com>
The function rtw_reset_rx_info() and its associated counters in
struct debug_priv are used to track AMPDU and management frame
statistics that are never read by the driver.
Remove the unused function, the write-only struct members, and the
now-unused pdbgpriv/psdpriv pointers in rtw_free_assoc_resources()
to clean up the MLME code
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index f81a29cd6a78..411339ebab7e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -819,15 +819,6 @@ static void free_scanqueue(struct mlme_priv *pmlmepriv)
spin_unlock_bh(&scan_queue->lock);
}
-static void rtw_reset_rx_info(struct debug_priv *pdbgpriv)
-{
- pdbgpriv->dbg_rx_ampdu_drop_count = 0;
- pdbgpriv->dbg_rx_ampdu_forced_indicate_count = 0;
- pdbgpriv->dbg_rx_ampdu_loss_count = 0;
- pdbgpriv->dbg_rx_dup_mgt_frame_drop_count = 0;
- pdbgpriv->dbg_rx_ampdu_window_shift_cnt = 0;
-}
-
static void find_network(struct adapter *adapter)
{
struct wlan_network *pwlan = NULL;
@@ -848,8 +839,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue)
{
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
struct wlan_network *tgt_network = &pmlmepriv->cur_network;
- struct dvobj_priv *psdpriv = adapter->dvobj;
- struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE)) {
struct sta_info *psta;
@@ -874,7 +863,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue)
if (lock_scanned_queue)
adapter->securitypriv.key_mask = 0;
- rtw_reset_rx_info(pdbgpriv);
}
/* rtw_indicate_connect: the caller has to lock pmlmepriv->lock */
--
2.52.0
next prev parent reply other threads:[~2026-01-28 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 0:40 [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic Ethan Tidmore
2026-01-28 0:40 ` Ethan Tidmore [this message]
2026-01-28 0:40 ` [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO overflow logic Ethan Tidmore
2026-01-28 9:29 ` kernel test robot
2026-01-28 0:40 ` [PATCH v2 3/4] staging: rtl8723bs: remove dead RX sequence logic Ethan Tidmore
2026-01-28 0:40 ` [PATCH v2 4/4] staging: rtl8723bs: remove unused struct debug_priv and all counters Ethan Tidmore
2026-01-28 11:02 ` [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic Greg Kroah-Hartman
2026-01-28 13:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128004009.51095-2-ethantidmore06@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox