From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F11BA32D0C2; Wed, 28 Jan 2026 09:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769591004; cv=none; b=ZDXe6RBVYcqGIddt7+9CSNzcoitZEtAyKLlFlwYAP2sECLwvtmRdXfhTKunbEo6JQxvX/u45bDt/GrEmiycoTC/cR9CDL84ckuAQjR/QWiw5V3+ZHH9RsRDbSSVhWXu96uj6n8QPPOoi4YwzAInJ1Vf57lKt4bVdAAcRyLXxVJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769591004; c=relaxed/simple; bh=ZvAupvvr/WMYU+hMmFixA0h6HMFEsrs2ahj7ED07S8Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a3DALqeYmJAQ8nJg2XOsebn2LQLMxdnMSLFEwT27s84B9xTnSrNt88hibegFqlNy3mbwSczuOdIS3KfsItgHe+hZSNvTWmuTLZmn8FL1Yc7g/TeXXzeO2FIIOyozOCCLgvkkiaLns5vK4BfbmIdfpUEjv/DblVGsXiu+L2qtIS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xJUzDWmL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xJUzDWmL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15CE8C4CEF1; Wed, 28 Jan 2026 09:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769591003; bh=ZvAupvvr/WMYU+hMmFixA0h6HMFEsrs2ahj7ED07S8Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xJUzDWmLpQ0qEvTYAWlP7N6JSHh75wMJM+pT2Ev2av9hTUaZHxBiexo8mZKpRTYay ik2SNxfKJ4TVeplA7ga4oMmIpykCYMtsr2jBpmnqMMuuc6zzNY6+3WtIsXhY44nhJN 1hQ0isvuV+2+n0LAyzjQUwDSLdJxDrn+lG5jejjU= Date: Wed, 28 Jan 2026 10:03:20 +0100 From: Greg KH To: Waffle0823 Cc: andy@kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] fbtft: Improve damage_range to mark only changed rows Message-ID: <2026012804-pentagram-emote-d443@gregkh> References: <20260128085720.862399-1-csshin9928@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128085720.862399-1-csshin9928@gmail.com> On Wed, Jan 28, 2026 at 05:57:20PM +0900, Waffle0823 wrote: > Instead of marking the entire display as dirty, calculate > start_row and end_row based on off/len and mark only those rows. > This improves performance for partial framebuffer updates. > > Signed-off-by: Waffle0283 csshin9928@gmail.com > --- > drivers/staging/fbtft/fbtft-core.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index 8a5ccc8ae0a1..0fbdfdaaa94d 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -415,8 +415,11 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len) > { > struct fbtft_par *par = info->par; > > - /* TODO: only mark changed area update all for now */ > - par->fbtftops.mkdirty(info, -1, 0); > + __u32 width = info->var.xres; > + __u32 start_row = off / width; > + __u32 end_row = (off + len - 1) / width; > + > + par->fbtftops.mkdirty(info, start_row, end_row); > } > > static void fbtft_ops_damage_area(struct fb_info *info, u32 x, u32 y, u32 width, u32 height) > -- > 2.52.0 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot