public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: oe-kbuild-all@lists.linux.dev,
	Michael Straube <straube.linux@gmail.com>,
	Dan Carpenter <error27@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Ethan Tidmore <ethantidmore06@gmail.com>
Subject: Re: [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO  overflow logic
Date: Wed, 28 Jan 2026 17:29:01 +0800	[thread overview]
Message-ID: <202601281752.mqChL1f6-lkp@intel.com> (raw)
In-Reply-To: <20260128004009.51095-3-ethantidmore06@gmail.com>

Hi Ethan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Ethan-Tidmore/staging-rtl8723bs-remove-dead-RX-info-reset-logic/20260128-084338
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260128004009.51095-3-ethantidmore06%40gmail.com
patch subject: [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO  overflow logic
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20260128/202601281752.mqChL1f6-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260128/202601281752.mqChL1f6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601281752.mqChL1f6-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8723bs/hal/rtl8723b_dm.c: In function 'rtl8723b_HalDmWatchDog':
>> drivers/staging/rtl8723bs/hal/rtl8723b_dm.c:127:14: warning: variable 'fw_current_in_ps_mode' set but not used [-Wunused-but-set-variable]
     127 |         bool fw_current_in_ps_mode = false;
         |              ^~~~~~~~~~~~~~~~~~~~~


vim +/fw_current_in_ps_mode +127 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c

554c0a3abf216c Hans de Goede         2017-03-29  124  
554c0a3abf216c Hans de Goede         2017-03-29  125  void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
554c0a3abf216c Hans de Goede         2017-03-29  126  {
90b69822a5cb6b Fabio M. De Francesco 2021-04-11 @127  	bool fw_current_in_ps_mode = false;
554c0a3abf216c Hans de Goede         2017-03-29  128  	bool bFwPSAwake = true;
554c0a3abf216c Hans de Goede         2017-03-29  129  	u8 hw_init_completed = false;
554c0a3abf216c Hans de Goede         2017-03-29  130  	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
554c0a3abf216c Hans de Goede         2017-03-29  131  
554c0a3abf216c Hans de Goede         2017-03-29  132  	hw_init_completed = Adapter->hw_init_completed;
554c0a3abf216c Hans de Goede         2017-03-29  133  
554c0a3abf216c Hans de Goede         2017-03-29  134  	if (hw_init_completed == false)
554c0a3abf216c Hans de Goede         2017-03-29  135  		goto skip_dm;
554c0a3abf216c Hans de Goede         2017-03-29  136  
90b69822a5cb6b Fabio M. De Francesco 2021-04-11  137  	fw_current_in_ps_mode = adapter_to_pwrctl(Adapter)->fw_current_in_ps_mode;
554c0a3abf216c Hans de Goede         2017-03-29  138  	rtw_hal_get_hwreg(Adapter, HW_VAR_FWLPS_RF_ON, (u8 *)(&bFwPSAwake));
554c0a3abf216c Hans de Goede         2017-03-29  139  
554c0a3abf216c Hans de Goede         2017-03-29  140  	/* ODM */
554c0a3abf216c Hans de Goede         2017-03-29  141  	if (hw_init_completed == true) {
554c0a3abf216c Hans de Goede         2017-03-29  142  		u8 bLinked = false;
554c0a3abf216c Hans de Goede         2017-03-29  143  		u8 bsta_state = false;
14c77a18375db3 Nishka Dasgupta       2019-07-02  144  		bool bBtDisabled = true;
554c0a3abf216c Hans de Goede         2017-03-29  145  
554c0a3abf216c Hans de Goede         2017-03-29  146  		if (rtw_linked_check(Adapter)) {
554c0a3abf216c Hans de Goede         2017-03-29  147  			bLinked = true;
554c0a3abf216c Hans de Goede         2017-03-29  148  			if (check_fwstate(&Adapter->mlmepriv, WIFI_STATION_STATE))
554c0a3abf216c Hans de Goede         2017-03-29  149  				bsta_state = true;
554c0a3abf216c Hans de Goede         2017-03-29  150  		}
554c0a3abf216c Hans de Goede         2017-03-29  151  
554c0a3abf216c Hans de Goede         2017-03-29  152  		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_LINK, bLinked);
554c0a3abf216c Hans de Goede         2017-03-29  153  		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_STATION_STATE, bsta_state);
554c0a3abf216c Hans de Goede         2017-03-29  154  
554c0a3abf216c Hans de Goede         2017-03-29  155  		/* ODM_CmnInfoUpdate(&pHalData->odmpriv , ODM_CMNINFO_RSSI_MIN, pdmpriv->MinUndecoratedPWDBForDM); */
554c0a3abf216c Hans de Goede         2017-03-29  156  
d1f4b78027202d Nishka Dasgupta       2019-07-01  157  		bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
554c0a3abf216c Hans de Goede         2017-03-29  158  
a8fa78b8f49752 Javier F. Arias       2019-11-05  159  		ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED,
c3a12cc1ec4c9c Javier F. Arias       2019-11-05  160  				  !bBtDisabled);
554c0a3abf216c Hans de Goede         2017-03-29  161  
554c0a3abf216c Hans de Goede         2017-03-29  162  		ODM_DMWatchdog(&pHalData->odmpriv);
554c0a3abf216c Hans de Goede         2017-03-29  163  	}
554c0a3abf216c Hans de Goede         2017-03-29  164  
554c0a3abf216c Hans de Goede         2017-03-29  165  skip_dm:
554c0a3abf216c Hans de Goede         2017-03-29  166  	return;
554c0a3abf216c Hans de Goede         2017-03-29  167  }
554c0a3abf216c Hans de Goede         2017-03-29  168  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2026-01-28  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  0:40 [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic Ethan Tidmore
2026-01-28  0:40 ` [PATCH v2 1/4] staging: rtl8723bs: remove dead RX info reset logic Ethan Tidmore
2026-01-28  0:40 ` [PATCH v2 2/4] staging: rtl8723bs: remove dead RX FIFO overflow logic Ethan Tidmore
2026-01-28  9:29   ` kernel test robot [this message]
2026-01-28  0:40 ` [PATCH v2 3/4] staging: rtl8723bs: remove dead RX sequence logic Ethan Tidmore
2026-01-28  0:40 ` [PATCH v2 4/4] staging: rtl8723bs: remove unused struct debug_priv and all counters Ethan Tidmore
2026-01-28 11:02 ` [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic Greg Kroah-Hartman
2026-01-28 13:23 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202601281752.mqChL1f6-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox