* [PATCH] staging: media: atomisp: remove functions doing ftrace like logging
@ 2026-02-01 14:24 Adarsh Das
2026-02-03 8:09 ` Andy Shevchenko
2026-03-27 19:39 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Adarsh Das @ 2026-02-01 14:24 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Greg Kroah-Hartman
Cc: Sakari Ailus, linux-kernel, linux-media, linux-staging,
Adarsh Das
Remove ia_css_debug_dtrace() calls which only log function entry.
ftrace should be used instead.
Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
---
.../media/atomisp/pci/ia_css_isp_configs.c | 26 -------------------
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
index 38c9c62366d6..1dce9fa926ab 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
@@ -18,8 +18,6 @@ int ia_css_configure_iterator(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -41,8 +39,6 @@ int ia_css_configure_copy_output(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -66,8 +62,6 @@ int ia_css_configure_crop(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -89,8 +83,6 @@ int ia_css_configure_fpn(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -111,8 +103,6 @@ int ia_css_configure_dvs(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -133,8 +123,6 @@ int ia_css_configure_qplane(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -156,8 +144,6 @@ int ia_css_configure_output0(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -179,8 +165,6 @@ int ia_css_configure_output1(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -202,8 +186,6 @@ int ia_css_configure_output(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -225,8 +207,6 @@ int ia_css_configure_raw(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -248,8 +228,6 @@ int ia_css_configure_tnr(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -271,8 +249,6 @@ int ia_css_configure_ref(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
@@ -294,8 +270,6 @@ int ia_css_configure_vf(const struct ia_css_binary *binary,
unsigned int offset = 0;
unsigned int size = 0;
- ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
-
if (!binary->info->mem_offsets.offsets.config)
return 0;
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: atomisp: remove functions doing ftrace like logging
2026-02-01 14:24 [PATCH] staging: media: atomisp: remove functions doing ftrace like logging Adarsh Das
@ 2026-02-03 8:09 ` Andy Shevchenko
2026-03-27 19:39 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2026-02-03 8:09 UTC (permalink / raw)
To: Adarsh Das
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Sakari Ailus, linux-kernel, linux-media,
linux-staging
On Sun, Feb 1, 2026 at 4:24 PM Adarsh Das <adarshdas950@gmail.com> wrote:
>
> Remove ia_css_debug_dtrace() calls which only log function entry.
> ftrace should be used instead.
LGTM,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: atomisp: remove functions doing ftrace like logging
2026-02-01 14:24 [PATCH] staging: media: atomisp: remove functions doing ftrace like logging Adarsh Das
2026-02-03 8:09 ` Andy Shevchenko
@ 2026-03-27 19:39 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2026-03-27 19:39 UTC (permalink / raw)
To: Adarsh Das, Andy Shevchenko, Mauro Carvalho Chehab,
Greg Kroah-Hartman
Cc: Sakari Ailus, linux-kernel, linux-media, linux-staging
Hi,
On 1-Feb-26 15:24, Adarsh Das wrote:
> Remove ia_css_debug_dtrace() calls which only log function entry.
> ftrace should be used instead.
>
> Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> .../media/atomisp/pci/ia_css_isp_configs.c | 26 -------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
> index 38c9c62366d6..1dce9fa926ab 100644
> --- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
> +++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
> @@ -18,8 +18,6 @@ int ia_css_configure_iterator(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -41,8 +39,6 @@ int ia_css_configure_copy_output(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -66,8 +62,6 @@ int ia_css_configure_crop(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -89,8 +83,6 @@ int ia_css_configure_fpn(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -111,8 +103,6 @@ int ia_css_configure_dvs(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -133,8 +123,6 @@ int ia_css_configure_qplane(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -156,8 +144,6 @@ int ia_css_configure_output0(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -179,8 +165,6 @@ int ia_css_configure_output1(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -202,8 +186,6 @@ int ia_css_configure_output(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -225,8 +207,6 @@ int ia_css_configure_raw(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -248,8 +228,6 @@ int ia_css_configure_tnr(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -271,8 +249,6 @@ int ia_css_configure_ref(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -294,8 +270,6 @@ int ia_css_configure_vf(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 19:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-01 14:24 [PATCH] staging: media: atomisp: remove functions doing ftrace like logging Adarsh Das
2026-02-03 8:09 ` Andy Shevchenko
2026-03-27 19:39 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox