From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Luka Gejak <lukagejak5@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips
Date: Mon, 2 Feb 2026 09:36:51 +0100 [thread overview]
Message-ID: <2026020224-venomous-disfigure-4308@gregkh> (raw)
In-Reply-To: <20260202070752.3391-2-lukagejak5@gmail.com>
On Mon, Feb 02, 2026 at 08:07:48AM +0100, Luka Gejak wrote:
> Remove unused definitions and function declarations that were left over
> from other Realtek chips:
>
> - Remove rtl8192c_translate_rx_signal_stuff() and
> rtl8192c_query_rx_desc_status() function declarations from
> rtl8192c_recv.h. These functions are declared but never implemented
> or used in the 8723bs driver.
>
> - Remove unused RECV_BLK_SZ, RECV_BLK_CNT, and RECV_BLK_TH defines from
> rtl8192c_recv.h. These are not referenced anywhere in the driver.
>
> - Remove unused MAX_PATH_NUM_* definitions for other chips (92CS, 8188E,
> 8192E, 8812A, 8821A, 8814A, 8822B) from odm.h. Only MAX_PATH_NUM_8723B
> is actually used by the driver.
When you have to list the different things a patch does, that's a huge
hint that the change needs to be broken up into smaller patches.
Remember, each change can only do "one logical thing".
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-02 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 7:07 [PATCH v1 0/5] staging: rtl8723bs: code cleanup and style fixes Luka Gejak
2026-02-02 7:07 ` [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips Luka Gejak
2026-02-02 8:36 ` Greg Kroah-Hartman [this message]
2026-02-02 7:07 ` [PATCH v1 2/5] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info * Luka Gejak
2026-02-02 7:07 ` [PATCH v1 3/5] staging: rtl8723bs: remove NDIS type aliases Luka Gejak
2026-02-02 7:07 ` [PATCH v1 4/5] staging: rtl8723bs: remove redundant MAC_ARG macro Luka Gejak
2026-02-02 7:07 ` [PATCH v1 5/5] staging: rtl8723bs: fix LONG_LINE warnings across C files Luka Gejak
2026-02-02 8:35 ` Greg Kroah-Hartman
2026-02-02 8:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020224-venomous-disfigure-4308@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox