From: Greg KH <gregkh@linuxfoundation.org>
To: Gustavo Piaz da Silva <gustavopiazdasilva2102@gmail.com>
Cc: dan.carpenter@linaro.org, ovidiu.panait.oss@gmail.com,
gshahrouzi@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] staging: axis-fifo: align fifo depth types with OF API
Date: Tue, 3 Feb 2026 09:19:55 +0100 [thread overview]
Message-ID: <2026020311-rethink-armory-9d84@gregkh> (raw)
In-Reply-To: <20260202142047.30704-2-gustavopiazdasilva2102@gmail.com>
On Mon, Feb 02, 2026 at 11:20:46AM -0300, Gustavo Piaz da Silva wrote:
> Change has_rx_fifo and has_tx_fifo types from int to u32 in struct
> axis_fifo.
I can not parse this sentance, sorry.
> The of_property_read_u32() function expects a u32 pointer. While the
> current code might work, aligning the types avoids potential mixed-type
> issues and clarifies the data structure.
Please note that the current code does work, so to imply it doesn't
might not be the best thing.
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-03 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 14:20 [PATCH v6 0/2] staging: axis-fifo: refactor and cleanup Gustavo Piaz da Silva
2026-02-02 14:20 ` [PATCH v6 1/2] staging: axis-fifo: align fifo depth types with OF API Gustavo Piaz da Silva
2026-02-03 8:19 ` Greg KH [this message]
2026-02-02 14:20 ` [PATCH v6 2/2] staging: axis-fifo: refactor device tree parsing Gustavo Piaz da Silva
2026-02-02 19:43 ` Dan Carpenter
2026-02-03 8:19 ` [PATCH v6 0/2] staging: axis-fifo: refactor and cleanup Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020311-rethink-armory-9d84@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=gshahrouzi@gmail.com \
--cc=gustavopiazdasilva2102@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox