public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Baran Arda <baran9arda@gmail.com>
Cc: ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: axis-fifo: fix sleep while holding mutex
Date: Tue, 3 Feb 2026 13:02:20 +0100	[thread overview]
Message-ID: <2026020353-ended-graffiti-25d4@gregkh> (raw)
In-Reply-To: <20260203114858.28278-1-baran9arda@gmail.com>

On Tue, Feb 03, 2026 at 02:48:58PM +0300, Baran Arda wrote:
> The driver calls wait_event_interruptible_timeout() while holding a mutex. This can lead to a deadlock or poor performance as the mutex is held while the process is sleeping, preventing other processes from accessing the device. This patch moves the wait_event call outside of the mutex lock in both read and write operations.

What kind of tool was used to "find and fix" this "issue"?

And how was this tested?

And are you _sure_ it is correct?  (hint, I think you just broke the
driver's logic, please look closely at your patch...)

And what caused you to want to make this change to this driver?  Do you
have access to this hardware?

thanks,

greg k-h

  parent reply	other threads:[~2026-02-03 12:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 11:48 [PATCH v2] staging: axis-fifo: fix sleep while holding mutex Baran Arda
2026-02-03 12:00 ` Greg KH
2026-02-03 12:02 ` Greg KH [this message]
2026-02-03 13:44   ` Baran Arda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026020353-ended-graffiti-25d4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=baran9arda@gmail.com \
    --cc=gshahrouzi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ovidiu.panait.oss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox