* [PATCH] staging: sm750fb: rename Bpp to bpp
@ 2026-02-02 14:54 yehudis9982
2026-02-02 15:01 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: yehudis9982 @ 2026-02-02 14:54 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, yehudis9982
Rename the Bpp parameter to bpp to avoid CamelCase, as reported by
checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 046b9282b..866b12c2a 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt)
}
int sm750_hw_fillrect(struct lynx_accel *accel,
- u32 base, u32 pitch, u32 Bpp,
+ u32 base, u32 pitch, u32 bpp,
u32 x, u32 y, u32 width, u32 height,
u32 color, u32 rop)
{
@@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */
write_dpr(accel, DE_PITCH,
- ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) &
+ ((pitch / bpp << DE_PITCH_DESTINATION_SHIFT) &
DE_PITCH_DESTINATION_MASK) |
- (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
+ (pitch / bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
write_dpr(accel, DE_WINDOW_WIDTH,
- ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
+ ((pitch / bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
DE_WINDOW_WIDTH_DST_MASK) |
- (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */
+ (pitch / bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */
write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */
@@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
* @sy: Starting y coordinate of source surface
* @dBase: Address of destination: offset in frame buffer
* @dPitch: Pitch value of destination surface in BYTE
- * @Bpp: Color depth of destination surface
+ * @bpp: Color depth of destination surface
* @dx: Starting x coordinate of destination surface
* @dy: Starting y coordinate of destination surface
* @width: width of rectangle in pixel value
@@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
unsigned int sBase, unsigned int sPitch,
unsigned int sx, unsigned int sy,
unsigned int dBase, unsigned int dPitch,
- unsigned int Bpp, unsigned int dx, unsigned int dy,
+ unsigned int bpp, unsigned int dx, unsigned int dy,
unsigned int width, unsigned int height,
unsigned int rop2)
{
@@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
* pixel values. Need Byte to pixel conversion.
*/
write_dpr(accel, DE_PITCH,
- ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) &
+ ((dPitch / bpp << DE_PITCH_DESTINATION_SHIFT) &
DE_PITCH_DESTINATION_MASK) |
- (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
+ (sPitch / bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
/*
* Screen Window width in Pixels.
@@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
* for a given point.
*/
write_dpr(accel, DE_WINDOW_WIDTH,
- ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
+ ((dPitch / bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
DE_WINDOW_WIDTH_DST_MASK) |
- (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */
+ (sPitch / bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */
if (accel->de_wait() != 0)
return -1;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: sm750fb: rename Bpp to bpp 2026-02-02 14:54 [PATCH] staging: sm750fb: rename Bpp to bpp yehudis9982 @ 2026-02-02 15:01 ` Greg KH 2026-02-02 17:12 ` [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel yehudis9982 2026-02-02 16:46 ` yehudis9982 2026-02-02 16:57 ` yehudis9982 2 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2026-02-02 15:01 UTC (permalink / raw) To: yehudis9982 Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging, linux-kernel On Mon, Feb 02, 2026 at 04:54:13PM +0200, yehudis9982 wrote: > Rename the Bpp parameter to bpp to avoid CamelCase, as reported by > checkpatch.pl. > > Signed-off-by: yehudis9982 <y0533159982@gmail.com> > --- > drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 046b9282b..866b12c2a 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) > } > > int sm750_hw_fillrect(struct lynx_accel *accel, > - u32 base, u32 pitch, u32 Bpp, > + u32 base, u32 pitch, u32 bpp, What does "bpp" stand for? Perhaps spell it out further? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel 2026-02-02 15:01 ` Greg KH @ 2026-02-02 17:12 ` yehudis9982 2026-02-03 8:17 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: yehudis9982 @ 2026-02-02 17:12 UTC (permalink / raw) To: sudipm.mukherjee, teddy.wang, gregkh Cc: linux-fbdev, linux-staging, linux-kernel, yehudis9982 Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 046b9282b..3fe9429e1 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -48,7 +48,7 @@ void sm750_hw_de_init(struct lynx_accel *accel) DE_STRETCH_FORMAT_ADDRESSING_MASK | DE_STRETCH_FORMAT_SOURCE_HEIGHT_MASK; - /* DE_STRETCH bpp format need be initialized in setMode routine */ + /* DE_STRETCH bytes_per_pixel format need be initialized in setMode routine */ write_dpr(accel, DE_STRETCH_FORMAT, (read_dpr(accel, DE_STRETCH_FORMAT) & ~clr) | reg); @@ -76,7 +76,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) { u32 reg; - /* fmt=0,1,2 for 8,16,32,bpp on sm718/750/502 */ + /* fmt=0,1,2 for 8,16,32,bytes_per_pixel on sm718/750/502 */ reg = read_dpr(accel, DE_STRETCH_FORMAT); reg &= ~DE_STRETCH_FORMAT_PIXEL_FORMAT_MASK; reg |= ((fmt << DE_STRETCH_FORMAT_PIXEL_FORMAT_SHIFT) & @@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) } int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bytes_per_pixel, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop) { @@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel, write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ write_dpr(accel, DE_PITCH, - ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((pitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (pitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ write_dpr(accel, DE_WINDOW_WIDTH, - ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((pitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ + (pitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */ @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @sy: Starting y coordinate of source surface * @dBase: Address of destination: offset in frame buffer * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @bytes_per_pixel: Bytes per pixel (color depth / 8) of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int sBase, unsigned int sPitch, unsigned int sx, unsigned int sy, unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int bytes_per_pixel, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) { @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((dPitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (sPitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((dPitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (sPitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ if (accel->de_wait() != 0) return -1; -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel 2026-02-02 17:12 ` [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel yehudis9982 @ 2026-02-03 8:17 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2026-02-03 8:17 UTC (permalink / raw) To: yehudis9982 Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging, linux-kernel On Mon, Feb 02, 2026 at 07:12:43PM +0200, yehudis9982 wrote: > Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. > > Signed-off-by: yehudis9982 <y0533159982@gmail.com> > --- > drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c > index 046b9282b..3fe9429e1 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -48,7 +48,7 @@ void sm750_hw_de_init(struct lynx_accel *accel) > DE_STRETCH_FORMAT_ADDRESSING_MASK | > DE_STRETCH_FORMAT_SOURCE_HEIGHT_MASK; > > - /* DE_STRETCH bpp format need be initialized in setMode routine */ > + /* DE_STRETCH bytes_per_pixel format need be initialized in setMode routine */ > write_dpr(accel, DE_STRETCH_FORMAT, > (read_dpr(accel, DE_STRETCH_FORMAT) & ~clr) | reg); > > @@ -76,7 +76,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) > { > u32 reg; > > - /* fmt=0,1,2 for 8,16,32,bpp on sm718/750/502 */ > + /* fmt=0,1,2 for 8,16,32,bytes_per_pixel on sm718/750/502 */ > reg = read_dpr(accel, DE_STRETCH_FORMAT); > reg &= ~DE_STRETCH_FORMAT_PIXEL_FORMAT_MASK; > reg |= ((fmt << DE_STRETCH_FORMAT_PIXEL_FORMAT_SHIFT) & > @@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) > } > > int sm750_hw_fillrect(struct lynx_accel *accel, > - u32 base, u32 pitch, u32 Bpp, > + u32 base, u32 pitch, u32 bytes_per_pixel, > u32 x, u32 y, u32 width, u32 height, > u32 color, u32 rop) > { > @@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel, > > write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ > write_dpr(accel, DE_PITCH, > - ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & > + ((pitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & > DE_PITCH_DESTINATION_MASK) | > - (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ > + (pitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ > > write_dpr(accel, DE_WINDOW_WIDTH, > - ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & > + ((pitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & > DE_WINDOW_WIDTH_DST_MASK) | > - (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ > + (pitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ > > write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */ > > @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, > * @sy: Starting y coordinate of source surface > * @dBase: Address of destination: offset in frame buffer > * @dPitch: Pitch value of destination surface in BYTE > - * @Bpp: Color depth of destination surface > + * @bytes_per_pixel: Bytes per pixel (color depth / 8) of destination surface > * @dx: Starting x coordinate of destination surface > * @dy: Starting y coordinate of destination surface > * @width: width of rectangle in pixel value > @@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, > unsigned int sBase, unsigned int sPitch, > unsigned int sx, unsigned int sy, > unsigned int dBase, unsigned int dPitch, > - unsigned int Bpp, unsigned int dx, unsigned int dy, > + unsigned int bytes_per_pixel, unsigned int dx, unsigned int dy, > unsigned int width, unsigned int height, > unsigned int rop2) > { > @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, > * pixel values. Need Byte to pixel conversion. > */ > write_dpr(accel, DE_PITCH, > - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & > + ((dPitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & > DE_PITCH_DESTINATION_MASK) | > - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ > + (sPitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ > > /* > * Screen Window width in Pixels. > @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, > * for a given point. > */ > write_dpr(accel, DE_WINDOW_WIDTH, > - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & > + ((dPitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & > DE_WINDOW_WIDTH_DST_MASK) | > - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ > + (sPitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ > > if (accel->de_wait() != 0) > return -1; > -- > 2.43.0 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel 2026-02-02 14:54 [PATCH] staging: sm750fb: rename Bpp to bpp yehudis9982 2026-02-02 15:01 ` Greg KH @ 2026-02-02 16:46 ` yehudis9982 2026-02-02 16:57 ` yehudis9982 2 siblings, 0 replies; 6+ messages in thread From: yehudis9982 @ 2026-02-02 16:46 UTC (permalink / raw) To: sudipm.mukherjee, teddy.wang, gregkh Cc: linux-fbdev, linux-staging, linux-kernel, yehudis9982 Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 046b9282b..3fe9429e1 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -48,7 +48,7 @@ void sm750_hw_de_init(struct lynx_accel *accel) DE_STRETCH_FORMAT_ADDRESSING_MASK | DE_STRETCH_FORMAT_SOURCE_HEIGHT_MASK; - /* DE_STRETCH bpp format need be initialized in setMode routine */ + /* DE_STRETCH bytes_per_pixel format need be initialized in setMode routine */ write_dpr(accel, DE_STRETCH_FORMAT, (read_dpr(accel, DE_STRETCH_FORMAT) & ~clr) | reg); @@ -76,7 +76,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) { u32 reg; - /* fmt=0,1,2 for 8,16,32,bpp on sm718/750/502 */ + /* fmt=0,1,2 for 8,16,32,bytes_per_pixel on sm718/750/502 */ reg = read_dpr(accel, DE_STRETCH_FORMAT); reg &= ~DE_STRETCH_FORMAT_PIXEL_FORMAT_MASK; reg |= ((fmt << DE_STRETCH_FORMAT_PIXEL_FORMAT_SHIFT) & @@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) } int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bytes_per_pixel, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop) { @@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel, write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ write_dpr(accel, DE_PITCH, - ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((pitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (pitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ write_dpr(accel, DE_WINDOW_WIDTH, - ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((pitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ + (pitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */ @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @sy: Starting y coordinate of source surface * @dBase: Address of destination: offset in frame buffer * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @bytes_per_pixel: Bytes per pixel (color depth / 8) of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int sBase, unsigned int sPitch, unsigned int sx, unsigned int sy, unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int bytes_per_pixel, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) { @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((dPitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (sPitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((dPitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (sPitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ if (accel->de_wait() != 0) return -1; -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel 2026-02-02 14:54 [PATCH] staging: sm750fb: rename Bpp to bpp yehudis9982 2026-02-02 15:01 ` Greg KH 2026-02-02 16:46 ` yehudis9982 @ 2026-02-02 16:57 ` yehudis9982 2 siblings, 0 replies; 6+ messages in thread From: yehudis9982 @ 2026-02-02 16:57 UTC (permalink / raw) To: sudipm.mukherjee, teddy.wang, gregkh Cc: linux-fbdev, linux-staging, linux-kernel, yehudis9982 Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 046b9282b..3fe9429e1 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -48,7 +48,7 @@ void sm750_hw_de_init(struct lynx_accel *accel) DE_STRETCH_FORMAT_ADDRESSING_MASK | DE_STRETCH_FORMAT_SOURCE_HEIGHT_MASK; - /* DE_STRETCH bpp format need be initialized in setMode routine */ + /* DE_STRETCH bytes_per_pixel format need be initialized in setMode routine */ write_dpr(accel, DE_STRETCH_FORMAT, (read_dpr(accel, DE_STRETCH_FORMAT) & ~clr) | reg); @@ -76,7 +76,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) { u32 reg; - /* fmt=0,1,2 for 8,16,32,bpp on sm718/750/502 */ + /* fmt=0,1,2 for 8,16,32,bytes_per_pixel on sm718/750/502 */ reg = read_dpr(accel, DE_STRETCH_FORMAT); reg &= ~DE_STRETCH_FORMAT_PIXEL_FORMAT_MASK; reg |= ((fmt << DE_STRETCH_FORMAT_PIXEL_FORMAT_SHIFT) & @@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) } int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bytes_per_pixel, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop) { @@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel, write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ write_dpr(accel, DE_PITCH, - ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((pitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (pitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ write_dpr(accel, DE_WINDOW_WIDTH, - ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((pitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ + (pitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */ @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @sy: Starting y coordinate of source surface * @dBase: Address of destination: offset in frame buffer * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @bytes_per_pixel: Bytes per pixel (color depth / 8) of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int sBase, unsigned int sPitch, unsigned int sx, unsigned int sy, unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int bytes_per_pixel, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) { @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((dPitch / bytes_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (sPitch / bytes_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((dPitch / bytes_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (sPitch / bytes_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ if (accel->de_wait() != 0) return -1; -- 2.43.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-02-03 8:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-02-02 14:54 [PATCH] staging: sm750fb: rename Bpp to bpp yehudis9982 2026-02-02 15:01 ` Greg KH 2026-02-02 17:12 ` [PATCH v2] staging: sm750fb: rename Bpp to bytes_per_pixel yehudis9982 2026-02-03 8:17 ` Greg KH 2026-02-02 16:46 ` yehudis9982 2026-02-02 16:57 ` yehudis9982
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox