From: David Laight <david.laight.linux@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Michael Harris" <michaelharriscode@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: iio: adt7316: convert magic numbers to BIT() and GENMASK()
Date: Wed, 4 Feb 2026 10:32:39 +0000 [thread overview]
Message-ID: <20260204103239.332b66af@pumpkin> (raw)
In-Reply-To: <20260131162140.5abb833b@jic23-huawei>
On Sat, 31 Jan 2026 16:21:40 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Fri, 30 Jan 2026 23:38:28 -0800
> Michael Harris <michaelharriscode@gmail.com> wrote:
..
> > - return sysfs_emit(buf, "0x%x\n",
> > + return sysfs_emit(buf, "0x%lx\n",
> > chip->dac_config & ADT7316_DA_2VREF_CH_MASK);
> Is the compiler complaining about these? It really should be able to tell that the masks
> are small enough that the original can always print the right thing.
That will be because BIT() and GENMASK() generate 'unsigned long' values.
Sort of silly when they are used for hardware registers that are fixed width.
You can use BIT_U32() and GENMASK_U32() instead - they will be
'unsigned int'.
David
prev parent reply other threads:[~2026-02-04 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 7:38 [PATCH 0/2] correct macro issues Michael Harris
2026-01-31 7:38 ` [PATCH 1/2] staging: iio: adt7316: remove unused macros Michael Harris
2026-01-31 15:54 ` Jonathan Cameron
2026-01-31 19:12 ` Michael Harris
2026-01-31 7:38 ` [PATCH 2/2] staging: iio: adt7316: convert magic numbers to BIT() and GENMASK() Michael Harris
2026-01-31 16:21 ` Jonathan Cameron
2026-02-04 6:50 ` Michael Harris
2026-02-04 10:32 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204103239.332b66af@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=michaelharriscode@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox