[PATCH v3 1/4] staging: greybus: added comment to mutex declaration in fw-management.c

[PATCH v3 1/4] staging: greybus: added comment to mutex declaration in fw-management.c

[Rachit Dhar]

Added comment to mutex declaration, to resolve a checkpatch.pl check.

Signed-off-by: Rachit Dhar <rchtdhr@gmail.com>
---
 drivers/staging/greybus/fw-management.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
index 152949c23d65..07a0e6b63cf3 100644
--- a/drivers/staging/greybus/fw-management.c
+++ b/drivers/staging/greybus/fw-management.c
@@ -28,7 +28,7 @@ struct fw_mgmt {
 
 	/* Common id-map for interface and backend firmware requests */
 	struct ida		id_map;
-	struct mutex		mutex;
+	struct mutex		mutex; /* protects fw_mgmt->disabled, and serializes ioctl */
 	struct completion	completion;
 	struct cdev		cdev;
 	struct device		*class_device;
-- 
2.43.0

Re: [PATCH v3 1/4] staging: greybus: added comment to mutex declaration in fw-management.c

[Greg Kroah-Hartman]

On Wed, Feb 04, 2026 at 06:30:03PM +0000, Rachit Dhar wrote:
> Added comment to mutex declaration, to resolve a checkpatch.pl check.
> 
> Signed-off-by: Rachit Dhar <rchtdhr@gmail.com>
> ---
>  drivers/staging/greybus/fw-management.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
> index 152949c23d65..07a0e6b63cf3 100644
> --- a/drivers/staging/greybus/fw-management.c
> +++ b/drivers/staging/greybus/fw-management.c
> @@ -28,7 +28,7 @@ struct fw_mgmt {
>  
>  	/* Common id-map for interface and backend firmware requests */
>  	struct ida		id_map;
> -	struct mutex		mutex;
> +	struct mutex		mutex; /* protects fw_mgmt->disabled, and serializes ioctl */

How do you "know" that this is what it is for?

Fixing this type of checkpatch warning is hard, and requires lots of
documentation and checking.  If you didn't write the code originally, I
wouldn't worry about this type of issue at all, it's best for new code,
not existing code.

thanks,

greg k-h

Re: [PATCH v3 1/4] staging: greybus: added comment to mutex declaration in fw-management.c

[Rachit Dhar]

On Sat, Feb 7, 2026 at 7:08 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> How do you "know" that this is what it is for?
>
> Fixing this type of checkpatch warning is hard, and requires lots of
> documentation and checking.  If you didn't write the code originally, I
> wouldn't worry about this type of issue at all, it's best for new code,
> not existing code.

I did go through the code manually, but understand that it might be
deserving of more extensive checking and documentation to make
such a conclusion.

This patch can be dropped. Let me know if another patch series is
needed without this patch included in it.

Thanks,
Rachit