From: lukagejak5@gmail.com
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Luka Gejak <luka.gejak@linux.dev>
Subject: [PATCH v2 04/26] staging: rtl8723bs: modernize hex output in rtw_report_sec_ie
Date: Fri, 6 Feb 2026 08:54:17 +0100 [thread overview]
Message-ID: <20260206075439.103287-5-luka.gejak@linux.dev> (raw)
In-Reply-To: <20260206075439.103287-1-luka.gejak@linux.dev>
From: Luka Gejak <luka.gejak@linux.dev>
Replace the manual hex-printing loop with the standard kernel '%*ph'
format string. This simplifies the code and uses modern logging
practices.
Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 0b82b1f2f1ec..d46f5025a0a5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2071,7 +2071,7 @@ static int rtw_append_pmkid(struct adapter *Adapter, int iEntry, u8 *ie, uint ie
static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *sec_ie)
{
uint len;
- u8 *buff, *p, i;
+ u8 *buff, *p;
union iwreq_data wrqu;
buff = NULL;
@@ -2087,8 +2087,7 @@ static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *sec_ie)
len = sec_ie[1] + 2;
len = (len < IW_CUSTOM_MAX) ? len : IW_CUSTOM_MAX;
- for (i = 0; i < len; i++)
- p += scnprintf(p, IW_CUSTOM_MAX - (p - buff), "%02x", sec_ie[i]);
+ p += scnprintf(p, IW_CUSTOM_MAX - (p - buff), " %*ph", len, sec_ie);
p += scnprintf(p, IW_CUSTOM_MAX - (p - buff), ")");
--
2.52.0
next prev parent reply other threads:[~2026-02-06 7:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 7:54 [PATCH v2 00/26] staging: rtl8723bs: refactor and fix various driver issues lukagejak5
2026-02-06 7:54 ` [PATCH v2 01/26] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie lukagejak5
2026-02-07 13:45 ` Greg Kroah-Hartman
2026-02-06 7:54 ` [PATCH v2 02/26] staging: rtl8723bs: rename u1bTmp to val lukagejak5
2026-02-06 7:54 ` [PATCH v2 03/26] staging: rtl8723bs: fix spacing around operators lukagejak5
2026-02-06 7:54 ` lukagejak5 [this message]
2026-02-06 7:54 ` [PATCH v2 05/26] staging: rtl8723bs: remove dead debugging code in rtw_mlme_ext.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 06/26] staging: rtl8723bs: remove unused rtl8192c function declarations lukagejak5
2026-02-06 7:54 ` [PATCH v2 07/26] staging: rtl8723bs: remove unused RECV_BLK defines lukagejak5
2026-02-06 7:54 ` [PATCH v2 08/26] staging: rtl8723bs: remove unused MAX_PATH_NUM defines lukagejak5
2026-02-06 7:54 ` [PATCH v2 09/26] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info * lukagejak5
2026-02-06 7:54 ` [PATCH v2 10/26] staging: rtl8723bs: remove NDIS type aliases lukagejak5
2026-02-06 7:54 ` [PATCH v2 11/26] staging: rtl8723bs: remove redundant MAC_ARG macro lukagejak5
2026-02-06 7:54 ` [PATCH v2 12/26] staging: rtl8723bs: core: fix line lengths in rtw_wlan_util.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 13/26] staging: rtl8723bs: core: fix line lengths in rtw_recv.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 14/26] staging: rtl8723bs: hal: fix line lengths in HalPhyRf_8723B.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 15/26] staging: rtl8723bs: os_dep: fix line lengths in ioctl_cfg80211.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 16/26] staging: rtl8723bs: hal: fix line lengths in rtl8723b_cmd.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 17/26] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 18/26] staging: rtl8723bs: hal: fix line lengths in rtl8723b_phycfg.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 19/26] staging: rtl8723bs: core: fix various line length overflows lukagejak5
2026-02-06 7:54 ` [PATCH v2 20/26] staging: rtl8723bs: hal: " lukagejak5
2026-02-06 7:54 ` [PATCH v2 21/26] staging: rtl8723bs: os_dep: " lukagejak5
2026-02-06 7:54 ` [PATCH v2 22/26] staging: rtl8723bs: core: fix line lengths in rtw_cmd.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 23/26] staging: rtl8723bs: core: fix line lengths in rtw_mlme_ext.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 24/26] staging: rtl8723bs: core: fix line lengths in rtw_mlme.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 25/26] staging: rtl8723bs: core: fix line lengths in rtw_xmit.c lukagejak5
2026-02-06 7:54 ` [PATCH v2 26/26] staging: rtl8723bs: core: fix various line length overflows lukagejak5
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206075439.103287-5-luka.gejak@linux.dev \
--to=lukagejak5@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox