From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00051F0991;
	Sat,  7 Feb 2026 13:32:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1770471157; cv=none; b=sKtw91MxfqFLrYNkM2UVD4dl/312K5pqyTnhubxXLu28i30o5KxsJMdeWdrVoxFZltVK8ZZN7KA8j7XcvhIXA5uOKt/NJ3zfwUhoSbR11lU6T4F7yn2kALM6O3t6twIMYdUUsOhXoZE8o+iXBtoFRifFDfRUXisgRMEdv3yfoUU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1770471157; c=relaxed/simple;
	bh=EAg8D00kBWJwwhcePvUExFWJ6jNPYpUJKsPgCJHrAkA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=g3aOD/XeIuYgdImXMyx7+hb9TXBW9wsTy0uMm7SlowFmRjDSjQskbgR/MXSqngMa2QhtjUc96seNH9qRL7FH49N+03HVm6+Vz1UfNFXr5YHt1s4DLd2ldF4bs9cdpTW+6r7pgvBsNWFZQ++YZ2dpu2kXNPyq0cVSdUC3KmAXLhY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XXIUVZFX; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XXIUVZFX"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 978D2C116D0;
	Sat,  7 Feb 2026 13:32:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1770471157;
	bh=EAg8D00kBWJwwhcePvUExFWJ6jNPYpUJKsPgCJHrAkA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=XXIUVZFXVXAizSJ8Bsm4YXoFVAmSiZ0dUtYdoBb/oKWJFK6Vo3cr9ykew5oEALPDD
	 UqVGUUttBy/lICM3pDL4MmGeXHkFTdA97TLn7UR3Kjk/9TZgsARKADhVhoYCzZB+8L
	 VmNuqBc2+ZjNHH58jX5+bEEWnMLmQhtpUmOgMNvQ=
Date: Sat, 7 Feb 2026 14:32:33 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Artem Lytkin <iprintercanon@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] staging: sm750fb: remove debug and diagnostic
 prints
Message-ID: <2026020701-radar-onward-20a4@gregkh>
References: <20260204120602.6715-1-iprintercanon@gmail.com>
 <20260204120602.6715-3-iprintercanon@gmail.com>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260204120602.6715-3-iprintercanon@gmail.com>

On Wed, Feb 04, 2026 at 12:06:00PM +0000, Artem Lytkin wrote:
> @@ -811,11 +802,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>  				g_fbmode[index],
>  				mdb_desc[i]);
>  			break;
> -		} else if (ret == 3) {
> -			pr_warn("wanna use default mode\n");
> -			/*break;*/
> -		} else if (ret == 4) {
> -			pr_warn("fall back to any valid mode\n");
> +		} else if (ret == 3 || ret == 4) {
> +			continue;
>  		} else {
>  			pr_warn("ret = %d,fb_find_mode failed,with %s\n",
>  				ret,

Why delete some of these but not all?  Why delete any of them?

Consistancy matters :)

thanks,

greg k-h