Linux kernel staging patches
 help / color / mirror / Atom feed
From: Sajja Easwar Sai <eshwarsajja20@gmail.com>
To: gregkh@linuxfoundation.org
Cc: ethantidmore06@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, iryuken@duck.com,
	kernel-janitors@vger.kernel.org,
	Sajja Easwar Sai <eshwarsajja20@gmail.com>
Subject: [PATCH v3] staging: rtl8723bs: remove hardcoded dead debug code
Date: Sat,  7 Feb 2026 23:39:34 +0530	[thread overview]
Message-ID: <20260207180934.73593-1-eshwarsajja20@gmail.com> (raw)

The debug code is guarded by a constant false condition and is never
executed. Remove it to simplify the code. This also removes the now
unused variable 'pattrib'.

Signed-off-by: Sajja Easwar Sai <eshwarsajja20@gmail.com>
---
v3:
 - Removed incorrect Reported-by and Closes tags.
 - Fixed name casing in Signed-off-by to use Title Case.
 - Added blank line before return statement.
 - Included this version history.

v2:
 - Fixed build warnings found in v1.

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index ac49bfbaa..b61841bf1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -1849,7 +1849,6 @@ unsigned int OnAction_ht(struct adapter *padapter, union recv_frame *precv_frame
 unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv_frame)
 {
 	u8 *pframe = precv_frame->u.hdr.rx_data;
-	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 	struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
 	unsigned short tid;
 
@@ -1865,14 +1864,6 @@ unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv
 	default:
 		break;
 	}
-	if (0) {
-		int pp;
-
-		netdev_dbg(padapter->pnetdev, "pattrib->pktlen = %d =>", pattrib->pkt_len);
-		for (pp = 0; pp < pattrib->pkt_len; pp++)
-			pr_cont(" %02x ", pframe[pp]);
-		pr_cont("\n");
-	}
 
 	return _SUCCESS;
 }
-- 
2.53.0

             reply	other threads:[~2026-02-07 18:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-07 18:09 Sajja Easwar Sai [this message]
2026-02-07 18:26 ` [PATCH v3] staging: rtl8723bs: remove hardcoded dead debug code Ethan Tidmore
2026-02-23 14:37 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260207180934.73593-1-eshwarsajja20@gmail.com \
    --to=eshwarsajja20@gmail.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iryuken@duck.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox