[PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf() with sysfs_emit()

[PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf() with sysfs_emit()

[Neel Bullywon]

Replace sprintf() with sysfs_emit() in the protocol_id_show() sysfs
attribute function. This code is safe as-is, but replace
sprintf() with sysfs_emit() because we are trying to get rid of calls
to sprintf() as part of kernel hardening; sysfs_emit() is more
appropriate in this context.

Signed-off-by: Neel Bullywon <neelb2403@gmail.com>
---
This was compile-tested only (no VM/hardware used)

Changes in v2:
- Subject: change to imperative "Replace" (was "Replaced").
- Wording and line breaks adjusted in the commit body for clarity.

Changes in v3:
- Clarify what "safe" means (buffer is PAGE_SIZE) per Dan Carpenter's
  suggestion.
- Reflow lines to avoid awkward breaks.
---
 drivers/staging/greybus/gbphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 60cf09a302a7..55f132b09cee 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
 {
 	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
 
-	return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
+	return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
 }
 static DEVICE_ATTR_RO(protocol_id);
 

base-commit: de0674d9bc69699c497477d45172493393ae9007
-- 
2.44.0

Re: [PATCH v3] [PATCH v3] staging: greybus: gbphy: Replace sprintf() with sysfs_emit()

[Greg Kroah-Hartman]

On Wed, Feb 04, 2026 at 10:34:08PM -0500, Neel Bullywon wrote:
> Replace sprintf() with sysfs_emit() in the protocol_id_show() sysfs
> attribute function. This code is safe as-is, but replace
> sprintf() with sysfs_emit() because we are trying to get rid of calls
> to sprintf() as part of kernel hardening; sysfs_emit() is more
> appropriate in this context.
> 
> Signed-off-by: Neel Bullywon <neelb2403@gmail.com>
> ---
> This was compile-tested only (no VM/hardware used)
> 
> Changes in v2:
> - Subject: change to imperative "Replace" (was "Replaced").
> - Wording and line breaks adjusted in the commit body for clarity.
> 
> Changes in v3:
> - Clarify what "safe" means (buffer is PAGE_SIZE) per Dan Carpenter's
>   suggestion.
> - Reflow lines to avoid awkward breaks.
> ---
>  drivers/staging/greybus/gbphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 60cf09a302a7..55f132b09cee 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
>  {
>  	struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>  
> -	return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
> +	return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);

For new sysfs files, using sysfs_emit() is fine, but for existing ones,
using sprintf() is also ok, just leave them as-is please.

thanks,

greg k-h