From: Greg KH <gregkh@linuxfoundation.org>
To: Khushal Chitturi <khushalchitturi@gmail.com>
Cc: dan.carpenter@linaro.org, straube.linux@gmail.com,
hansg@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/4] staging: rtl8723bs: rename LinkDetectInfo and clean up related code
Date: Sat, 7 Feb 2026 14:11:58 +0100 [thread overview]
Message-ID: <2026020731-zipping-keenly-ae34@gregkh> (raw)
In-Reply-To: <20260201113837.8531-2-khushalchitturi@gmail.com>
On Sun, Feb 01, 2026 at 05:08:34PM +0530, Khushal Chitturi wrote:
> This patch renames LinkDetectInfo instance to link_detect_info and update
> the fields of rt_link_detect_t to follow kernel naming conventions.
> Local variables in traffic_status_watchdog were also updated for
> consistency.
Please only do one logical thing per patch. This is way too many
renames to try to verify you got it all correct here, would you like to
have to review this? :)
> Signed-off-by: Khushal Chitturi <khushalchitturi@gmail.com>
>
> ---
No need for a blank line after your signed-off-by line.
> Changelog:
> v5 -> v6: Limited the changes to LinkDetectInfo renaming.
No, you also changed the local variables. Don't make fake claims in
changelog versions :(
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-07 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 11:38 [PATCH v6 0/4] staging: rtl8723bs: coding style and refactoring cleanups Khushal Chitturi
2026-02-01 11:38 ` [PATCH v6 1/4] staging: rtl8723bs: rename LinkDetectInfo and clean up related code Khushal Chitturi
2026-02-07 13:11 ` Greg KH [this message]
2026-02-01 11:38 ` [PATCH v6 2/4] staging: rtl8723bs: convert traffic status variables to bool Khushal Chitturi
2026-02-01 11:38 ` [PATCH v6 3/4] staging: rtl8723bs: simplify boolean expressions Khushal Chitturi
2026-02-07 13:13 ` Greg KH
2026-02-01 11:38 ` [PATCH v6 4/4] staging: rtl8723bs: fix line length and alignment issues Khushal Chitturi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020731-zipping-keenly-ae34@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=hansg@kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox