public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Neel Bullywon <neelb2403@gmail.com>
Cc: David Lin <dtwlin@gmail.com>, Johan Hovold <johan@kernel.org>,
	Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: uart: migrated from IDR to XArray API
Date: Sat, 7 Feb 2026 14:25:12 +0100	[thread overview]
Message-ID: <2026020735-thumping-chemicals-c76e@gregkh> (raw)
In-Reply-To: <20260204043802.65430-1-neelb2403@gmail.com>

On Tue, Feb 03, 2026 at 11:38:02PM -0500, Neel Bullywon wrote:
> Replaced the IDR API with the XArray API for managing TTY minor numbers.
> This addresses the checkpatch warning about DEFINE_IDR being deprecated.

While I understand that some people might feel that xarrays are the
bees-knees, for something "simple" like an idr, it's overkill, right?

This is "just" a unique integer that is used for a device name, leaving
it as an idr should be just fine as there is no performance or storage
issues with it as-is.

So while I'm all for using new apis for new code, unless all usages of
idr is going to be replaced in the kernel with xarray, I don't really
feel that this is needed to be done here, sorry.

thanks,

greg k-h

      reply	other threads:[~2026-02-07 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  4:38 [PATCH] staging: greybus: uart: migrated from IDR to XArray API Neel Bullywon
2026-02-07 13:25 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026020735-thumping-chemicals-c76e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dtwlin@gmail.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=neelb2403@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox