From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ö. Efe D." <skylinesytbe@gmail.com>
Cc: "Michael Straube" <straube.linux@gmail.com>,
linux-staging@lists.linux.dev,
"Ö. Efe D." <skyline@noreply.codeberg.org>,
"Öner Efe Dasgüney" <efedasguney@protonmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c
Date: Sat, 7 Feb 2026 14:18:20 +0100 [thread overview]
Message-ID: <2026020741-barometer-implosion-338a@gregkh> (raw)
In-Reply-To: <20260202021845.265051-1-skyline@noreply.codeberg.org>
On Mon, Feb 02, 2026 at 03:18:45AM +0100, Ö. Efe D. wrote:
> Remove spaces before tabs in comments to fix checkpatch warnings:
> "please, no space before tabs"
>
> Signed-off-by: Öner Efe Dasgüney <efedasguney@protonmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 70b5b289f9cb..10c34228a595 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>
> if (bWIFICfg) { /* WMM */
>
> - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> - /* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */
> + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> + /* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */
> /* 0:ep_0 num, 1:ep_1 num */
>
> pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
> @@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
> } else { /* typical setting */
>
>
> - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> - /* 1, 1, 0, 0, 0, 0, 0, 0, 0 }; */
> + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> + /* 1, 1, 0, 0, 0, 0, 0, 0, 0 }; */
As Dan said, this patch is correct in that it fixes the coding style
issue, but now the table looks just as bad as before. How about fixing
this up properly so that it both looks correct, AND fixes the coding
style warning at the same time?
thanks,
greg k-h
prev parent reply other threads:[~2026-02-07 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 2:18 [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c Ö. Efe D.
2026-02-02 7:08 ` M.samet Duman
2026-02-02 9:34 ` Dan Carpenter
2026-02-02 9:49 ` Greg Kroah-Hartman
2026-02-02 11:39 ` Dan Carpenter
2026-02-02 9:38 ` Dan Carpenter
2026-02-07 13:18 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020741-barometer-implosion-338a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=efedasguney@protonmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=skyline@noreply.codeberg.org \
--cc=skylinesytbe@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox