[PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[Ö. Efe D.]

Remove spaces before tabs in comments to fix checkpatch warnings:
"please, no space before tabs"

Signed-off-by: Öner Efe Dasgüney <efedasguney@protonmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 70b5b289f9cb..10c34228a595 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */
 		/* 0:ep_0 num, 1:ep_1 num */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
@@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 	} else { /* typical setting */
 
 
-		/* BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   1,		1,	0,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	1,	1,	0,	0,	0,	0,	0,	0,	0	}; */
 		/* 0:ep_0 num, 1:ep_1 num */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
@@ -403,8 +403,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 
 	if (bWIFICfg) { /* for WMM */
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   1,		2,	1,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	1,	2,	1,	0,	0,	0,	0,	0,	0	}; */
 		/* 0:H, 1:N, 2:L */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
@@ -420,8 +420,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
 	} else { /* typical setting */
 
 
-		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
-		/*   2,		2,	1,	0,	0,	0,	0,	0,		0	}; */
+		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
+		/*	2,	2,	1,	0,	0,	0,	0,	0,	0	}; */
 		/* 0:H, 1:N, 2:L */
 
 		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
-- 
2.52.0

Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[M.samet Duman]

Hello Ömer,

I wanted to share a brief observation regarding the patch titled:

“Remove spaces before tabs in comments to fix checkpatch warnings”

Looking at the diff, the change is limited to whitespace alignment inside comments. There is no functional change, no meaningful impact on readability, and no effect on build or runtime behavior.

Given that scope, describing the change as a “fix” feels slightly misleading. From a reader’s point of view, this appears closer to a cosmetic or comment cleanup driven by checkpatch preferences rather than a fix addressing an actual issue.

This is not to say the change is invalid, but clearer framing would help set expectations when scanning patches on the list and later when looking at history or blame output.

Thanks for sharing the patch.

> 2026. 2. 2. 오전 5:19, Ö. Efe D. <skylinesytbe@gmail.com> 작성:
> 
> Remove spaces before tabs in comments to fix checkpatch warnings:
> "please, no space before tabs"
> 
> Signed-off-by: Öner Efe Dasgüney <efedasguney@protonmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 70b5b289f9cb..10c34228a595 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
> 
>    if (bWIFICfg) { /* WMM */
> 
> -        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> -        /*   0,        1,    0,    1,    0,    0,    0,    0,        0    }; */
> +        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> +        /*    0,    1,    0,    1,    0,    0,    0,    0,    0    }; */
>        /* 0:ep_0 num, 1:ep_1 num */
> 
>        pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
> @@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>    } else { /* typical setting */
> 
> 
> -        /* BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> -        /*   1,        1,    0,    0,    0,    0,    0,    0,        0    }; */
> +        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> +        /*    1,    1,    0,    0,    0,    0,    0,    0,    0    }; */
>        /* 0:ep_0 num, 1:ep_1 num */
> 
>        pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
> @@ -403,8 +403,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
> 
>    if (bWIFICfg) { /* for WMM */
> 
> -        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> -        /*   1,        2,    1,    0,    0,    0,    0,    0,        0    }; */
> +        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> +        /*    1,    2,    1,    0,    0,    0,    0,    0,    0    }; */
>        /* 0:H, 1:N, 2:L */
> 
>        pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
> @@ -420,8 +420,8 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>    } else { /* typical setting */
> 
> 
> -        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> -        /*   2,        2,    1,    0,    0,    0,    0,    0,        0    }; */
> +        /*    BK,    BE,    VI,    VO,    BCN,    CMD, MGT, HIGH, HCCA */
> +        /*    2,    2,    1,    0,    0,    0,    0,    0,    0    }; */
>        /* 0:H, 1:N, 2:L */
> 
>        pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0];/* VO */
> --
> 2.52.0
> 
> 

---
Best regards,  
Mehmet Samet Duman
Author of Project Tick
https://projecttick.org
https://github.com/Project-Tick

Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[Dan Carpenter]

On Mon, Feb 02, 2026 at 10:08:02AM +0300, M.samet Duman wrote:
> Hello Ömer,
> 
> I wanted to share a brief observation regarding the patch titled:
> 
> “Remove spaces before tabs in comments to fix checkpatch warnings”
> 

That's not the title.  Why would you mention the title and then get it
wrong?  I'm so puzzled by this review.  Is it AI generated?  Please
only use AI if there are bugs, don't use AI to comment on the commit
message.

https://staticthinking.wordpress.com/2026/01/27/no-ai-slop/

Line wrap your emails at 72 characters?

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[Dan Carpenter]

On Mon, Feb 02, 2026 at 03:18:45AM +0100, Ö. Efe D. wrote:
> Remove spaces before tabs in comments to fix checkpatch warnings:
> "please, no space before tabs"
> 
> Signed-off-by: Öner Efe Dasgüney <efedasguney@protonmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 70b5b289f9cb..10c34228a595 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>  
>  	if (bWIFICfg) { /* WMM */
>  
> -		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> -		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
> +		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> +		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */

These things are supposed to be aligned so that the commas on the top
line are the same as on the bottom line.  It's a table.  But it's messed
up both before and after.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[Greg Kroah-Hartman]

On Mon, Feb 02, 2026 at 12:34:42PM +0300, Dan Carpenter wrote:
> On Mon, Feb 02, 2026 at 10:08:02AM +0300, M.samet Duman wrote:
> > Hello Ömer,
> > 
> > I wanted to share a brief observation regarding the patch titled:
> > 
> > “Remove spaces before tabs in comments to fix checkpatch warnings”
> > 
> 
> That's not the title.  Why would you mention the title and then get it
> wrong?  I'm so puzzled by this review.  Is it AI generated?  Please
> only use AI if there are bugs, don't use AI to comment on the commit
> message.
> 
> https://staticthinking.wordpress.com/2026/01/27/no-ai-slop/

Oh that's so good, mind if I add it to my bot responses for when it
detects this type of thing?

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[Dan Carpenter]

On Mon, Feb 02, 2026 at 10:49:26AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 02, 2026 at 12:34:42PM +0300, Dan Carpenter wrote:
> > On Mon, Feb 02, 2026 at 10:08:02AM +0300, M.samet Duman wrote:
> > > Hello Ömer,
> > > 
> > > I wanted to share a brief observation regarding the patch titled:
> > > 
> > > “Remove spaces before tabs in comments to fix checkpatch warnings”
> > > 
> > 
> > That's not the title.  Why would you mention the title and then get it
> > wrong?  I'm so puzzled by this review.  Is it AI generated?  Please
> > only use AI if there are bugs, don't use AI to comment on the commit
> > message.
> > 
> > https://staticthinking.wordpress.com/2026/01/27/no-ai-slop/
> 
> Oh that's so good, mind if I add it to my bot responses for when it
> detects this type of thing?

Go ahead.  Absolutely.  :)

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: fix whitespace issues in hal_com.c

[Greg Kroah-Hartman]

On Mon, Feb 02, 2026 at 03:18:45AM +0100, Ö. Efe D. wrote:
> Remove spaces before tabs in comments to fix checkpatch warnings:
> "please, no space before tabs"
> 
> Signed-off-by: Öner Efe Dasgüney <efedasguney@protonmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_com.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 70b5b289f9cb..10c34228a595 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -362,8 +362,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>  
>  	if (bWIFICfg) { /* WMM */
>  
> -		/* 	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> -		/*   0,		1,	0,	1,	0,	0,	0,	0,		0	}; */
> +		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> +		/*	0,	1,	0,	1,	0,	0,	0,	0,	0	}; */
>  		/* 0:ep_0 num, 1:ep_1 num */
>  
>  		pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[1];/* VO */
> @@ -379,8 +379,8 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>  	} else { /* typical setting */
>  
>  
> -		/* BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> -		/*   1,		1,	0,	0,	0,	0,	0,	0,		0	}; */
> +		/*	BK,	BE,	VI,	VO,	BCN,	CMD, MGT, HIGH, HCCA */
> +		/*	1,	1,	0,	0,	0,	0,	0,	0,	0	}; */

As Dan said, this patch is correct in that it fixes the coding style
issue, but now the table looks just as bad as before.  How about fixing
this up properly so that it both looks correct, AND fixes the coding
style warning at the same time?

thanks,

greg k-h