From: Priit Laes <plaes@plaes.org>
Cc: Priit Laes <plaes@plaes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Thomas Gleixner <tglx@kernel.org>,
Vivek BalachandharTN <vivek.balachandhar@gmail.com>,
Minu Jin <s9430939@naver.com>,
Ethan Tidmore <ethantidmore06@gmail.com>,
Artur Stupa <arthur.stupa@gmail.com>,
Zhuoheng Li <lizhuoheng@kylinos.cn>,
Michael Huang <tehsiu.huang@gmail.com>,
Nino Zhang <ninozhang001@gmail.com>,
Yuvraj Singh Chauhan <ysinghcin@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 03/11] staging: rtl8723bs: Drop empty rtw_bug_check function
Date: Fri, 20 Feb 2026 18:15:14 +0200 [thread overview]
Message-ID: <20260220161611.2398915-4-plaes@plaes.org> (raw)
In-Reply-To: <20260220161611.2398915-1-plaes@plaes.org>
This function was just returning True.
Signed-off-by: Priit Laes <plaes@plaes.org>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 ----------
drivers/staging/rtl8723bs/include/osdep_service.h | 8 --------
2 files changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 22dc36e8e38a..7a346cbf2708 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -358,9 +358,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
u16 s_cap, d_cap;
__le16 tmps, tmpd;
- if (rtw_bug_check(dst, src, &s_cap, &d_cap) == false)
- return false;
-
memcpy((u8 *)&tmps, rtw_get_capability_from_ie(src->ies), 2);
memcpy((u8 *)&tmpd, rtw_get_capability_from_ie(dst->ies), 2);
@@ -464,11 +461,6 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex
{
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
- rtw_bug_check(&pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network);
-
if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) {
update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true);
rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie),
@@ -493,8 +485,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
list_for_each(plist, phead) {
pnetwork = list_entry(plist, struct wlan_network, list);
- rtw_bug_check(pnetwork, pnetwork, pnetwork, pnetwork);
-
if (is_same_network(&pnetwork->network, target, feature)) {
target_find = 1;
break;
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index f7b647db1a75..d6710e5835f0 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -65,14 +65,6 @@ static inline void flush_signals_thread(void)
#define rtw_warn_on(condition) WARN_ON(condition)
-static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, void *parg4)
-{
- int ret = true;
-
- return ret;
-
-}
-
extern void rtw_free_netdev(struct net_device *netdev);
/* Macros for handling unaligned memory accesses */
--
2.53.0
next prev parent reply other threads:[~2026-02-20 16:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260220161611.2398915-1-plaes@plaes.org>
2026-02-20 16:15 ` [PATCH 01/11] staging: stl8723bs: Use common round_up macro Priit Laes
2026-02-20 16:15 ` [PATCH 02/11] staging: rtl8723bs: Remove unused BIT32..BIT36 definitions Priit Laes
2026-02-20 16:15 ` Priit Laes [this message]
2026-02-20 16:15 ` [PATCH 04/11] staging: rtl8723bs: Remove unused rtw_sprintf macro Priit Laes
2026-02-20 16:15 ` [PATCH 05/11] staging: rtl8723bs: Drop unused _kfree(...) declaration Priit Laes
2026-02-20 16:15 ` [PATCH 06/11] staging: rtl8723bs: Get rid of unused _rtw_init_queue Priit Laes
2026-02-20 16:15 ` [PATCH 07/11] staging: rtl8723bs: Drop unused NDEV-related formatting macros Priit Laes
2026-02-20 16:15 ` [PATCH 08/11] staging: rtl8723bs: Drop workqueue wrapper functions Priit Laes
2026-02-20 16:15 ` [PATCH 09/11] staging: rtl8273bs: Reduce useless function wrapping in regulator code Priit Laes
2026-02-20 16:15 ` [PATCH 10/11] staging: rtl8723bs: Remove useless wrapper functions in rtw_cmd.c Priit Laes
2026-02-20 18:42 ` Ethan Tidmore
2026-02-20 17:29 ` [PATCH 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Priit Laes
2026-02-20 23:50 ` kernel test robot
2026-02-21 1:25 ` kernel test robot
2026-02-21 9:47 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220161611.2398915-4-plaes@plaes.org \
--to=plaes@plaes.org \
--cc=andriy.shevchenko@intel.com \
--cc=arthur.stupa@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lizhuoheng@kylinos.cn \
--cc=ninozhang001@gmail.com \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=tehsiu.huang@gmail.com \
--cc=tglx@kernel.org \
--cc=vivek.balachandhar@gmail.com \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox