From: Priit Laes <plaes@plaes.org>
Cc: "Priit Laes" <plaes@plaes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Archit Anant" <architanant5@gmail.com>,
"Minu Jin" <s9430939@naver.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Yuvraj Singh Chauhan" <ysinghcin@gmail.com>,
"JJ Strnad" <strnad.jj@gmail.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Julia Lawall" <julia.lawall@inria.fr>,
"William Hansen-Baird" <william.hansen.baird@gmail.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Abraham Samuel Adekunle" <abrahamadekunle50@gmail.com>,
"Rodrigo Gobbi" <rodrigo.gobbi.7@gmail.com>,
"Navaneeth K" <knavaneeth786@gmail.com>,
"Artur Stupa" <arthur.stupa@gmail.com>,
"Michael Straube" <straube.linux@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Vivek BalachandharTN" <vivek.balachandhar@gmail.com>,
"Ethan Tidmore" <ethantidmore06@gmail.com>,
"Zhuoheng Li" <lizhuoheng@kylinos.cn>,
"Michael Huang" <tehsiu.huang@gmail.com>,
"Nino Zhang" <ninozhang001@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Rogério Fernandes Pereira" <rfp2005@gmail.com>,
"Diksha Kumari" <dikshakdevgan@gmail.com>,
yingche <zxcv2569763104@gmail.com>,
"Khushal Chitturi" <khushalchitturi@gmail.com>,
"Karthikey D Kadati" <karthikey3608@gmail.com>,
"Akiyoshi Kurita" <weibu@redadmin.org>,
"Erick Karanja" <karanja99erick@gmail.com>,
"SeungJu Cheon" <suunj1331@gmail.com>,
"Sun Jian" <sun.jian.kdev@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro
Date: Sat, 21 Feb 2026 21:01:31 +0200 [thread overview]
Message-ID: <20260221190628.50273-2-plaes@plaes.org> (raw)
In-Reply-To: <20260221190628.50273-1-plaes@plaes.org>
Get rid of driver-specific _RND macro in favor of kernel one.
Signed-off-by: Priit Laes <plaes@plaes.org>
---
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 4 ++--
drivers/staging/rtl8723bs/include/osdep_service.h | 2 --
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index a1f2cbf2cf55..c5b172c2f839 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -232,7 +232,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
/* check xmit_buf size enough or not */
txlen = txdesc_size + rtw_wlan_pkt_size(pxmitframe);
if (!pxmitbuf ||
- ((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) ||
+ ((round_up(pxmitbuf->len, 8) + txlen) > max_xmit_len) ||
(k >= (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1))
) {
if (pxmitbuf) {
@@ -303,8 +303,8 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
txlen = txdesc_size + pxmitframe->attrib.last_txcmdsz;
pxmitframe->pg_num = (txlen + 127) / 128;
pxmitbuf->pg_num += (txlen + 127) / 128;
- pxmitbuf->ptail += _RND(txlen, 8); /* round to 8 bytes alignment */
- pxmitbuf->len = _RND(pxmitbuf->len, 8) + txlen;
+ pxmitbuf->ptail += round_up(txlen, 8);
+ pxmitbuf->len = round_up(pxmitbuf->len, 8) + txlen;
}
if (k != 1)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index c9cb20c61a2b..6bfb8c0e519c 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -401,7 +401,7 @@ static u32 sdio_read_port(
hal_sdio_get_cmd_addr_8723b(adapter, addr, hal->SdioRxFIFOCnt++, &addr);
if (cnt > psdio->block_transfer_len)
- cnt = _RND(cnt, psdio->block_transfer_len);
+ cnt = round_up(cnt, psdio->block_transfer_len);
err = _sd_read(intfhdl, addr, cnt, mem);
@@ -448,7 +448,7 @@ static u32 sdio_write_port(
hal_sdio_get_cmd_addr_8723b(adapter, addr, cnt >> 2, &addr);
if (cnt > psdio->block_transfer_len)
- cnt = _RND(cnt, psdio->block_transfer_len);
+ cnt = round_up(cnt, psdio->block_transfer_len);
err = sd_write(intfhdl, addr, cnt, xmitbuf->pdata);
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 955e8678dc26..404f81756b27 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -78,8 +78,6 @@ static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, void *par
}
-#define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r))
-
extern void rtw_free_netdev(struct net_device *netdev);
/* Macros for handling unaligned memory accesses */
--
2.53.0
next prev parent reply other threads:[~2026-02-21 19:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 19:01 [PATCH v2 00/11] staging: stl8723bs: Various cleanups Priit Laes
2026-02-21 19:01 ` Priit Laes [this message]
2026-02-21 19:41 ` [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro Vivek BalachandharTN
2026-02-23 7:09 ` Dan Carpenter
2026-02-23 10:43 ` Priit Laes
2026-02-23 11:40 ` Julia Lawall
2026-02-23 11:50 ` Andy Shevchenko
2026-02-23 12:16 ` Julia Lawall
2026-02-23 13:48 ` Andy Shevchenko
2026-02-23 14:43 ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 02/11] staging: rtl8723bs: Remove unused BIT32..BIT36 definitions Priit Laes
2026-02-21 19:01 ` [PATCH v2 03/11] staging: rtl8723bs: Drop empty rtw_bug_check function Priit Laes
2026-02-21 19:01 ` [PATCH v2 04/11] staging: rtl8723bs: Remove unused rtw_sprintf macro Priit Laes
2026-02-21 19:01 ` [PATCH v2 05/11] staging: rtl8723bs: Drop unused _kfree(...) declaration Priit Laes
2026-02-21 19:01 ` [PATCH v2 06/11] staging: rtl8723bs: Get rid of unused _rtw_init_queue Priit Laes
2026-02-21 19:01 ` [PATCH v2 07/11] staging: rtl8723bs: Drop unused NDEV-related formatting macros Priit Laes
2026-02-21 19:01 ` [PATCH v2 08/11] staging: rtl8723bs: Drop workqueue wrapper functions Priit Laes
2026-02-21 19:01 ` [PATCH v2 09/11] staging: rtl8273bs: Simplify regulatory initialization functions Priit Laes
2026-02-23 7:17 ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 10/11] staging: rtl8723bs: Clean up wrapper functions Priit Laes
2026-02-21 20:20 ` Vivek BalachandharTN
2026-02-23 7:25 ` Dan Carpenter
[not found] ` <CAPsOcukZNc3oR=FmAjCdC6NrUV=1CaggQNGPoC2oxuH_P2R0hQ@mail.gmail.com>
2026-02-23 7:50 ` Andy Shevchenko
2026-02-21 19:01 ` [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Priit Laes
2026-02-23 7:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260221190628.50273-2-plaes@plaes.org \
--to=plaes@plaes.org \
--cc=abrahamadekunle50@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=architanant5@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dikshakdevgan@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=karanja99erick@gmail.com \
--cc=karthikey3608@gmail.com \
--cc=khushalchitturi@gmail.com \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lizhuoheng@kylinos.cn \
--cc=mingo@kernel.org \
--cc=ninozhang001@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rfp2005@gmail.com \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=strnad.jj@gmail.com \
--cc=sun.jian.kdev@gmail.com \
--cc=suunj1331@gmail.com \
--cc=tehsiu.huang@gmail.com \
--cc=tglx@kernel.org \
--cc=vivek.balachandhar@gmail.com \
--cc=weibu@redadmin.org \
--cc=william.hansen.baird@gmail.com \
--cc=ysinghcin@gmail.com \
--cc=zxcv2569763104@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox