From: Greg KH <gregkh@linuxfoundation.org>
To: Yuho Choi <yqc5929@psu.edu>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
tgkim@psu.edu
Subject: Re: [PATCH v3] staging: rtl8192u: ieee80211_rx: free rxb on reorder alloc failure
Date: Mon, 23 Feb 2026 14:52:20 +0100 [thread overview]
Message-ID: <2026022304-speculate-extrovert-f467@gregkh> (raw)
In-Reply-To: <20260213134834.14056-1-yqc5929@psu.edu>
On Fri, Feb 13, 2026 at 08:48:34AM -0500, Yuho Choi wrote:
> RxReorderIndicatePacket() allocates prxbIndicateArray with kmalloc_array().
> If the allocation fails, the function returns without freeing the incoming
> prxb and its subframes.
>
> With JOHN_NOCPY enabled, this leaks the original skb as well because skb
> ownership is transferred to rxb->subframes[] and ieee80211_rx() does not
> free skb in that configuration.
>
> Free all prxb->subframes[] and prxb before returning on the allocation
> failure path.
>
> Signed-off-by: Yuho Choi <yqc5929@psu.edu>
> ---
> Changes since v2:
> - Included this changelog as requested to document version history.
>
> Changes since v1:
> - Corrected the sender's email address, which was misconfigured in the initial submission.
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 8 +++++++-
This file is not in 7.0-rc1 at all, what branch did you make this
against?
thanks,
greg k-h
parent reply other threads:[~2026-02-23 13:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260213134834.14056-1-yqc5929@psu.edu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022304-speculate-extrovert-f467@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tgkim@psu.edu \
--cc=yqc5929@psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox