* [PATCH] staging: nvec: fix block comment style in nvec_interrupt()
@ 2026-02-23 14:31 yykkibbb
2026-02-23 14:39 ` Greg KH
2026-02-24 4:49 ` [PATCH v2] " Kibaek Yoo
0 siblings, 2 replies; 4+ messages in thread
From: yykkibbb @ 2026-02-23 14:31 UTC (permalink / raw)
To: marvin24, gregkh
Cc: ac100, linux-tegra, linux-staging, linux-kernel, yykkibbb
Fix multi-line block comment to use the preferred kernel comment style
with leading asterisks on each line and a trailing */ on a separate
line, as reported by checkpatch.pl.
Signed-off-by: yykkibbb <psykibaek@gmail.com>
---
drivers/staging/nvec/nvec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08..62013019a 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -659,8 +659,10 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
nvec_tx_set(nvec);
to_send = nvec->tx->data[0];
nvec->tx->pos = 1;
- /* delay ACK due to AP20 HW Bug
- do not replace by usleep_range */
+ /*
+ * delay ACK due to AP20 HW Bug
+ * do not replace by usleep_range
+ */
udelay(33);
} else if (status == (I2C_SL_IRQ)) {
nvec->rx->data[1] = received;
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: nvec: fix block comment style in nvec_interrupt()
2026-02-23 14:31 [PATCH] staging: nvec: fix block comment style in nvec_interrupt() yykkibbb
@ 2026-02-23 14:39 ` Greg KH
2026-02-24 4:49 ` [PATCH v2] " Kibaek Yoo
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-02-23 14:39 UTC (permalink / raw)
To: yykkibbb; +Cc: marvin24, ac100, linux-tegra, linux-staging, linux-kernel
On Mon, Feb 23, 2026 at 11:31:01PM +0900, yykkibbb wrote:
> Fix multi-line block comment to use the preferred kernel comment style
> with leading asterisks on each line and a trailing */ on a separate
> line, as reported by checkpatch.pl.
>
> Signed-off-by: yykkibbb <psykibaek@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index e9af66a08..62013019a 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -659,8 +659,10 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> nvec_tx_set(nvec);
> to_send = nvec->tx->data[0];
> nvec->tx->pos = 1;
> - /* delay ACK due to AP20 HW Bug
> - do not replace by usleep_range */
> + /*
> + * delay ACK due to AP20 HW Bug
> + * do not replace by usleep_range
> + */
> udelay(33);
> } else if (status == (I2C_SL_IRQ)) {
> nvec->rx->data[1] = received;
> --
> 2.50.1 (Apple Git-155)
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] staging: nvec: fix block comment style in nvec_interrupt()
2026-02-23 14:31 [PATCH] staging: nvec: fix block comment style in nvec_interrupt() yykkibbb
2026-02-23 14:39 ` Greg KH
@ 2026-02-24 4:49 ` Kibaek Yoo
2026-02-24 5:21 ` Ethan Tidmore
1 sibling, 1 reply; 4+ messages in thread
From: Kibaek Yoo @ 2026-02-24 4:49 UTC (permalink / raw)
To: marvin24, gregkh
Cc: ac100, linux-tegra, linux-staging, linux-kernel, Kibaek Yoo
Fix multi-line block comment to use the preferred kernel comment style
with leading asterisks on each line and a trailing */ on a separate
line, as reported by checkpatch.pl.
Signed-off-by: Kibaek Yoo <psykibaek@gmail.com>
---
drivers/staging/nvec/nvec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08..62013019a 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -659,8 +659,10 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
nvec_tx_set(nvec);
to_send = nvec->tx->data[0];
nvec->tx->pos = 1;
- /* delay ACK due to AP20 HW Bug
- do not replace by usleep_range */
+ /*
+ * delay ACK due to AP20 HW Bug
+ * do not replace by usleep_range
+ */
udelay(33);
} else if (status == (I2C_SL_IRQ)) {
nvec->rx->data[1] = received;
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: nvec: fix block comment style in nvec_interrupt()
2026-02-24 4:49 ` [PATCH v2] " Kibaek Yoo
@ 2026-02-24 5:21 ` Ethan Tidmore
0 siblings, 0 replies; 4+ messages in thread
From: Ethan Tidmore @ 2026-02-24 5:21 UTC (permalink / raw)
To: Kibaek Yoo, marvin24, gregkh
Cc: ac100, linux-tegra, linux-staging, linux-kernel
On Mon Feb 23, 2026 at 10:49 PM CST, Kibaek Yoo wrote:
> Fix multi-line block comment to use the preferred kernel comment style
> with leading asterisks on each line and a trailing */ on a separate
> line, as reported by checkpatch.pl.
>
> Signed-off-by: Kibaek Yoo <psykibaek@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-24 5:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-23 14:31 [PATCH] staging: nvec: fix block comment style in nvec_interrupt() yykkibbb
2026-02-23 14:39 ` Greg KH
2026-02-24 4:49 ` [PATCH v2] " Kibaek Yoo
2026-02-24 5:21 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox