Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mariyam Shahid <mariyam.shahid135@gmail.com>
Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Replace comparison to false with !
Date: Tue, 24 Feb 2026 10:11:29 -0800	[thread overview]
Message-ID: <2026022410-upswing-gurgle-532d@gregkh> (raw)
In-Reply-To: <20260223170708.9627-1-mariyam.shahid135@gmail.com>

On Mon, Feb 23, 2026 at 10:07:07PM +0500, Mariyam Shahid wrote:
> Replace comparisons to false with their logical negation
> to fix checkpatch warnings.
> 
> Signed-off-by: Mariyam Shahid <mariyam.shahid135@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index ebe73abab892..0192543cdec0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  
>  		rtw_ht_use_default_setting(padapter);
>  
> -		if (pmlmepriv->htpriv.sgi_20m == false)
> +		if (!pmlmepriv->htpriv.sgi_20m)
>  			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
>  
> -		if (pmlmepriv->htpriv.sgi_40m == false)
> +		if (!pmlmepriv->htpriv.sgi_40m)
>  			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
>  
>  		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
> -- 
> 2.43.0
> 

This doesn't apply to my tree as someone else sent this change before
you and I applied it, sorry.

thanks,

greg k-h

  parent reply	other threads:[~2026-02-24 18:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 17:07 [PATCH] staging: rtl8723bs: Replace comparison to false with ! Mariyam Shahid
2026-02-23 18:22 ` Ethan Tidmore
2026-02-24 18:11 ` Greg KH [this message]
2026-02-26  9:13   ` Mariyam Shahid
2026-02-26  9:24     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026022410-upswing-gurgle-532d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=ethantidmore06@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mariyam.shahid135@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox