* [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c [not found] <20260223200006.145296-1-tomasz.unger.ref@yahoo.pl> @ 2026-02-23 20:00 ` tomasz.unger 2026-02-23 20:00 ` [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format tomasz.unger 2026-02-24 5:22 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c Ethan Tidmore 0 siblings, 2 replies; 6+ messages in thread From: tomasz.unger @ 2026-02-23 20:00 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Tomasz Unger From: Tomasz Unger <tomasz.unger@yahoo.pl> Fix spelling mistakes in comments found by codespell: - alloction => allocation - overwirte => overwrite - indx => index Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> --- v3: Split into two separate patches as requested by Greg Kroah-Hartman. v2: Added multi-line comment format, changed to codespell. drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 3242978da36c..74c31a97f093 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -572,7 +572,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid) if ((((mlmeinfo->state & 0x03) == WIFI_FW_AP_STATE) || ((mlmeinfo->state & 0x03) == WIFI_FW_ADHOC_STATE)) && !sta) { - /* AP/Ad-hoc mode group key: static alloction to default key by key ID */ + /* AP/Ad-hoc mode group key: static allocation to default key by key ID */ if (kid > 3) { netdev_dbg(adapter->pnetdev, FUNC_ADPT_FMT " group key with invalid key id:%u\n", @@ -597,7 +597,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid) i = _rtw_camid_search(adapter, addr, kid); if (i >= 0) { - /* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwirte group only(ex: rekey) */ + /* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwrite group only(ex: rekey) */ if (sta || _rtw_camid_is_gk(adapter, i)) cam_id = i; else @@ -704,7 +704,7 @@ static void sort_wmm_ac_params(u32 *inx, u32 *edca) { u32 i, j, change_inx = false; - /* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */ + /* entry index: 0->vo, 1->vi, 2->be, 3->bk. */ for (i = 0; i < 4; i++) { for (j = i + 1; j < 4; j++) { /* compare CW and AIFS */ -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format 2026-02-23 20:00 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c tomasz.unger @ 2026-02-23 20:00 ` tomasz.unger 2026-02-24 5:25 ` Ethan Tidmore 2026-02-24 5:22 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c Ethan Tidmore 1 sibling, 1 reply; 6+ messages in thread From: tomasz.unger @ 2026-02-23 20:00 UTC (permalink / raw) To: gregkh; +Cc: linux-staging, linux-kernel, Tomasz Unger From: Tomasz Unger <tomasz.unger@yahoo.pl> Convert a long single-line comment to multi-line format as per coding-style.rst. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> --- v3: Split into two separate patches as requested by Greg Kroah-Hartman. v2: Added multi-line comment format, changed to codespell. drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 74c31a97f093..cffb1a9d36fa 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -597,7 +597,9 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid) i = _rtw_camid_search(adapter, addr, kid); if (i >= 0) { - /* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwrite group only(ex: rekey) */ + /* Fix issue that pairwise and group key have same key id. + * Pairwise key first, group key can overwrite group only(ex: rekey) + */ if (sta || _rtw_camid_is_gk(adapter, i)) cam_id = i; else -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format 2026-02-23 20:00 ` [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format tomasz.unger @ 2026-02-24 5:25 ` Ethan Tidmore 2026-02-24 17:59 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Ethan Tidmore @ 2026-02-24 5:25 UTC (permalink / raw) To: tomasz.unger, gregkh; +Cc: linux-staging, linux-kernel On Mon Feb 23, 2026 at 2:00 PM CST, tomasz.unger wrote: > From: Tomasz Unger <tomasz.unger@yahoo.pl> > > Convert a long single-line comment to multi-line format > as per coding-style.rst. > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > v3: Split into two separate patches as requested by Greg Kroah-Hartman. > v2: Added multi-line comment format, changed to codespell. > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > index 74c31a97f093..cffb1a9d36fa 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > @@ -597,7 +597,9 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid) > > i = _rtw_camid_search(adapter, addr, kid); > if (i >= 0) { > - /* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwrite group only(ex: rekey) */ > + /* Fix issue that pairwise and group key have same key id. > + * Pairwise key first, group key can overwrite group only(ex: rekey) > + */ Almost, the correct format is this: /* * Fix issue ... * ... */ Thanks, ET ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format 2026-02-24 5:25 ` Ethan Tidmore @ 2026-02-24 17:59 ` Greg KH 2026-02-24 18:54 ` Ethan Tidmore 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2026-02-24 17:59 UTC (permalink / raw) To: Ethan Tidmore; +Cc: tomasz.unger, linux-staging, linux-kernel On Mon, Feb 23, 2026 at 11:25:47PM -0600, Ethan Tidmore wrote: > On Mon Feb 23, 2026 at 2:00 PM CST, tomasz.unger wrote: > > From: Tomasz Unger <tomasz.unger@yahoo.pl> > > > > Convert a long single-line comment to multi-line format > > as per coding-style.rst. > > > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > > --- > > v3: Split into two separate patches as requested by Greg Kroah-Hartman. > > v2: Added multi-line comment format, changed to codespell. > > > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > > index 74c31a97f093..cffb1a9d36fa 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > > @@ -597,7 +597,9 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid) > > > > i = _rtw_camid_search(adapter, addr, kid); > > if (i >= 0) { > > - /* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwrite group only(ex: rekey) */ > > + /* Fix issue that pairwise and group key have same key id. > > + * Pairwise key first, group key can overwrite group only(ex: rekey) > > + */ > > Almost, the correct format is this: > > /* > * Fix issue ... > * ... > */ Except for the network stack/drivers. So this _is_ correct, as this is a network driver. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format 2026-02-24 17:59 ` Greg KH @ 2026-02-24 18:54 ` Ethan Tidmore 0 siblings, 0 replies; 6+ messages in thread From: Ethan Tidmore @ 2026-02-24 18:54 UTC (permalink / raw) To: Greg KH, Ethan Tidmore; +Cc: tomasz.unger, linux-staging, linux-kernel On Tue Feb 24, 2026 at 11:59 AM CST, Greg KH wrote: > On Mon, Feb 23, 2026 at 11:25:47PM -0600, Ethan Tidmore wrote: >> On Mon Feb 23, 2026 at 2:00 PM CST, tomasz.unger wrote: >> > From: Tomasz Unger <tomasz.unger@yahoo.pl> >> > >> > Convert a long single-line comment to multi-line format >> > as per coding-style.rst. >> > >> > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> >> > --- >> > v3: Split into two separate patches as requested by Greg Kroah-Hartman. >> > v2: Added multi-line comment format, changed to codespell. >> > >> > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c >> > index 74c31a97f093..cffb1a9d36fa 100644 >> > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c >> > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c >> > @@ -597,7 +597,9 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid) >> > >> > i = _rtw_camid_search(adapter, addr, kid); >> > if (i >= 0) { >> > - /* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwrite group only(ex: rekey) */ >> > + /* Fix issue that pairwise and group key have same key id. >> > + * Pairwise key first, group key can overwrite group only(ex: rekey) >> > + */ >> >> Almost, the correct format is this: >> >> /* >> * Fix issue ... >> * ... >> */ > > Except for the network stack/drivers. So this _is_ correct, as this is > a network driver. Oops, sorry about that. I thought it was just net/ that applied. Thanks, ET ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c 2026-02-23 20:00 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c tomasz.unger 2026-02-23 20:00 ` [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format tomasz.unger @ 2026-02-24 5:22 ` Ethan Tidmore 1 sibling, 0 replies; 6+ messages in thread From: Ethan Tidmore @ 2026-02-24 5:22 UTC (permalink / raw) To: tomasz.unger, gregkh; +Cc: linux-staging, linux-kernel On Mon Feb 23, 2026 at 2:00 PM CST, tomasz.unger wrote: > From: Tomasz Unger <tomasz.unger@yahoo.pl> > > Fix spelling mistakes in comments found by codespell: > - alloction => allocation > - overwirte => overwrite > - indx => index > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- LGTM. Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com> Thanks, ET ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-02-24 18:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260223200006.145296-1-tomasz.unger.ref@yahoo.pl>
2026-02-23 20:00 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c tomasz.unger
2026-02-23 20:00 ` [PATCH v3 2/2] staging: rtl8723bs: convert single-line comment to multi-line format tomasz.unger
2026-02-24 5:25 ` Ethan Tidmore
2026-02-24 17:59 ` Greg KH
2026-02-24 18:54 ` Ethan Tidmore
2026-02-24 5:22 ` [PATCH v3 1/2] staging: rtl8723bs: fix spelling mistakes in rtw_wlan_util.c Ethan Tidmore
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox