From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8F33E8C70; Wed, 25 Feb 2026 15:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772034502; cv=none; b=ZLXvK9NMZeF+EVrfU3pGJ1euDwy7BC0o2fCgjeIvGbBwNp2TG3atNoQUAV1A3UL8TJ///70ySMfOZDZU+nxRGjoZORHLy6vk5vmK4nPEy8HJjZBau3JFzCub26jNhJM7V/3J/x3uofxyW0bK5nVVgRpIBxeBzl2FT5zzQaD629c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772034502; c=relaxed/simple; bh=6GuxGlr/x2sDUhrOUoKxuETzpAMarpkGQJ7hxkW/8qM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XGqjGdkLj80kNqRafxykcOOr23tJr37JY4y62qDD4nOCdOx7MkqlAN79PNHv6YQwzxMNMEiNKMd5Ui4OH6Fvo2qwYu2V3RnHiBsy2Iu845yWkSXcJhjv1wRSCPYy6Y7vxraUn30N8Zq/8MC/7mEAkxG0VV4DMg1//A6Pr0e7vpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=w7XnLof4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="w7XnLof4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1552C116D0; Wed, 25 Feb 2026 15:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1772034501; bh=6GuxGlr/x2sDUhrOUoKxuETzpAMarpkGQJ7hxkW/8qM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=w7XnLof4zZKnNWUGHmVQlu+tqXPTmF+hPmjjJJN3T+C17llLmYVNBm+xhhGD3nFI9 9/wmaC7tMLK4ydVmPQhWJUIt4ITVUFoX8QED+L7WK8jKy2Jsfw5pRoq9PP/P2hEsy5 gi+W2sKzA3QWX1b39OHQoff1xoFjiSdpfhRKqMeU= Date: Wed, 25 Feb 2026 07:48:13 -0800 From: Greg Kroah-Hartman To: Luka Gejak Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/21] staging: rtl8723bs: os_dep: fix line lengths in ioctl_cfg80211.c Message-ID: <2026022521-arguable-peddling-b1ce@gregkh> References: <20260224132748.12336-1-luka.gejak@linux.dev> <20260224132748.12336-11-luka.gejak@linux.dev> <2026022520-flanked-effects-14cc@gregkh> <2026022516-huddle-diffuser-8219@gregkh> <68E7EB83-D0BB-4B5A-B703-903AB9E3B39C@linux.dev> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68E7EB83-D0BB-4B5A-B703-903AB9E3B39C@linux.dev> On Wed, Feb 25, 2026 at 04:17:20PM +0100, Luka Gejak wrote: > On February 25, 2026 4:14:37 PM GMT+01:00, Greg Kroah-Hartman wrote: > >On Wed, Feb 25, 2026 at 04:08:02PM +0100, Luka Gejak wrote: > >> On February 25, 2026 3:56:50 PM GMT+01:00, Greg Kroah-Hartman wrote: > >> >On Wed, Feb 25, 2026 at 09:58:07AM +0300, Dan Carpenter wrote: > >> >> On Tue, Feb 24, 2026 at 02:27:37PM +0100, luka.gejak@linux.dev wrote: > >> >> > From: Luka Gejak > >> >> > > >> >> > Break long lines exceeding 100 characters to comply with kernel coding > >> >> > style. > >> >> > > >> >> > Signed-off-by: Luka Gejak > >> >> > --- > >> >> > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 134 ++++++++++++------ > >> >> > 1 file changed, 94 insertions(+), 40 deletions(-) > >> >> > > >> >> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > >> >> > index 51725c302458..c04af493f24d 100644 > >> >> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > >> >> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > >> >> > @@ -127,8 +127,10 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc( > >> >> > if (!spt_band) > >> >> > goto exit; > >> >> > > >> >> > - spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) + sizeof(struct ieee80211_supported_band)); > >> >> > - spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) + sizeof(struct ieee80211_channel) * n_channels); > >> >> > + spt_band->channels = (struct ieee80211_channel *)(((u8 *)spt_band) + > >> >> > + sizeof(struct ieee80211_supported_band)); > >> >> > + spt_band->bitrates = (struct ieee80211_rate *)(((u8 *)spt_band->channels) + > >> >> > + sizeof(struct ieee80211_channel) * n_channels); > >> >> > spt_band->band = band; > >> >> > spt_band->n_channels = n_channels; > >> >> > spt_band->n_bitrates = n_bitrates; > >> >> > @@ -207,7 +209,8 @@ int rtw_ieee80211_channel_to_frequency(int chan) > >> >> > } > >> >> > > >> >> > #define MAX_BSSINFO_LEN 1000 > >> >> > -struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wlan_network *pnetwork) > >> >> > +struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, > >> >> > + struct wlan_network *pnetwork) > >> >> > { > >> >> > struct ieee80211_channel *notify_channel; > >> >> > struct cfg80211_bss *bss = NULL; > >> >> > @@ -248,7 +251,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter *padapter, struct wl > >> >> > u32 wpsielen = 0; > >> >> > u8 *wpsie = NULL; > >> >> > > >> >> > - wpsie = rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen); > >> >> > + u8 *ies = pnetwork->network.ies + _FIXED_IE_LENGTH_; > >> >> > + uint ie_len = pnetwork->network.ie_length - _FIXED_IE_LENGTH_; > >> >> > + > >> >> > >> >> No spaces in the middle of a declaration block, please. > >> > > >> >Wait, that's not described in the changelog either! > >> > > >> >I'll go just drop this whole series, thanks Dan for the better review > >> >than I gave it. I'll blame the jet-lag... > >> > > >> >thanks, > >> > > >> >greg k-h > >> > >> Hi Greg, > >> What about 13 patches already in staging-testing? > > > >I just now dropped them all, sorry. > > > >Please rebase your whole series and resubmit. > > > >thanks, > > > >greg k-h > > Should I make any modifications, per Dan's advice? Yes, just always consider what Dan says is always correct, I sure do :) So as-is, these patches are not ok and should be reworked. thanks, greg k-h