Re: [PATCH 12/12] staging: rtl8723bs: remove unnecessary casts in ioctl_cfg80211.c

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Feb 26, 2026 at 02:02:56PM +0400, Giorgi Tchankvetadze wrote:
> Remove unnecessary pointer casts in memset(), memcpy(), and memcmp()
> calls. These functions accept void * arguments, so explicit casts
> are not needed.
> 
> No functional change. Object code verified identical before and after.
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 46 ++++++++++---------
>  1 file changed, 25 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 7cb0c6f22bf3..eafedf91fa6e 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -93,9 +93,8 @@ static struct ieee80211_channel rtw_2ghz_channels[] = {
>  
>  static void rtw_2g_channels_init(struct ieee80211_channel *channels)
>  {
> -	memcpy((void *)channels, (void *)rtw_2ghz_channels,
> -	       sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM
> -	);
> +	memcpy(channels, rtw_2ghz_channels,
> +	       sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM);

You changed the style at the same time.  While overall a good thing,
please only do one type of change at once.

thanks,

greg k-h