[PATCH] staging: nvec: fix block comment style in nvec.c

[PATCH] staging: nvec: fix block comment style in nvec.c

[Oskar Ray-Frayssinet]

Fix block comment formatting to use * on subsequent lines
and */ on a separate line as required by kernel coding style.

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 drivers/staging/nvec/nvec.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08448..ee2715df3b48 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -646,7 +646,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 			nvec->state = 2;
 		}
 		break;
-	case 2:		/* first byte after command */
+	case 2:		/* First byte after command */
 		if (status == (I2C_SL_IRQ | RNW | RCVD)) {
 			if (nvec->rx->data[0] != 0x01) {
 				dev_err(nvec->dev,
@@ -659,8 +659,9 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 			nvec_tx_set(nvec);
 			to_send = nvec->tx->data[0];
 			nvec->tx->pos = 1;
-			/* delay ACK due to AP20 HW Bug
-			   do not replace by usleep_range */
+			/* Delay ACK due to AP20 HW Bug
+			 * do not replace by usleep_range
+			 */
 			udelay(33);
 		} else if (status == (I2C_SL_IRQ)) {
 			nvec->rx->data[1] = received;
-- 
2.43.0

Re: [PATCH] staging: nvec: fix block comment style in nvec.c

[Greg KH]

On Wed, Mar 04, 2026 at 08:18:53PM +0100, Oskar Ray-Frayssinet wrote:
> Fix block comment formatting to use * on subsequent lines
> and */ on a separate line as required by kernel coding style.
> 
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index e9af66a08448..ee2715df3b48 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -646,7 +646,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  			nvec->state = 2;
>  		}
>  		break;
> -	case 2:		/* first byte after command */
> +	case 2:		/* First byte after command */

THis change is not what you document above as being changed :(

[PATCH v3] staging: nvec: fix block comment style in nvec.c

[Oskar Ray-Frayssinet]

Fix block comment formatting to use * on subsequent lines
and */ on a separate line as required by kernel coding style.

Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
 drivers/staging/nvec/nvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e70fafc095f2..0e655f79ea4a 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -659,7 +659,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 			nvec_tx_set(nvec);
 			to_send = nvec->tx->data[0];
 			nvec->tx->pos = 1;
-			/* Delay ACK due to AP20 HW Bug
+			/* delay ACK due to AP20 HW Bug
 			 * do not replace by usleep_range
 			 */
 			udelay(33);
-- 
2.43.0

Re: [PATCH v3] staging: nvec: fix block comment style in nvec.c

[Greg KH]

On Mon, Mar 09, 2026 at 11:07:18PM +0100, Oskar Ray-Frayssinet wrote:
> Fix block comment formatting to use * on subsequent lines
> and */ on a separate line as required by kernel coding style.
> 
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index e70fafc095f2..0e655f79ea4a 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -659,7 +659,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  			nvec_tx_set(nvec);
>  			to_send = nvec->tx->data[0];
>  			nvec->tx->pos = 1;
> -			/* Delay ACK due to AP20 HW Bug
> +			/* delay ACK due to AP20 HW Bug
>  			 * do not replace by usleep_range
>  			 */
>  			udelay(33);
> -- 
> 2.43.0
> 
> 

This change is not what you documented is changing :(

Re: [PATCH v3] staging: nvec: fix block comment style in nvec.c

[Oskar Ray-Frayssinet]

On Wed, Mar 18, 2026 at 3:59 PM Greg Kroah-Hartman wrote:
> This change is not what you documented is changing :(

You are right, I apologize. The commit message was incorrect.
The actual change was reverting an accidental capitalization
introduced in v1. I will drop this patch.

Best regards,
Oskar Ray-Frayssinet

Re: [PATCH v3] staging: nvec: fix block comment style in nvec.c

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]

On Wed, Mar 18, 2026 at 03:59:43PM +0100, Greg KH wrote:
> On Mon, Mar 09, 2026 at 11:07:18PM +0100, Oskar Ray-Frayssinet wrote:
> > Fix block comment formatting to use * on subsequent lines
> > and */ on a separate line as required by kernel coding style.
> > 
> > Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> > ---
> >  drivers/staging/nvec/nvec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> > index e70fafc095f2..0e655f79ea4a 100644
> > --- a/drivers/staging/nvec/nvec.c
> > +++ b/drivers/staging/nvec/nvec.c
> > @@ -659,7 +659,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> >  			nvec_tx_set(nvec);
> >  			to_send = nvec->tx->data[0];
> >  			nvec->tx->pos = 1;
> > -			/* Delay ACK due to AP20 HW Bug
> > +			/* delay ACK due to AP20 HW Bug
> >  			 * do not replace by usleep_range
> >  			 */
> >  			udelay(33);
> > -- 
> > 2.43.0
> > 
> > 
> 
> This change is not what you documented is changing :(

Hm... this is the 8th version of this patch that I've seen.

I don't know why there was a flurry of these. The checkpatch warning
certainly isn't new, so maybe this was a new wave of janitors or
something? Or maybe people using AI agents to get into kernel
development. Not that it matters much, but it's not a pattern that I've
seen before.

Also, the fact that 7 out of the 8 versions came in after the first had
already landed in linux-next:

  29e79c66b3cc ("staging: nvec: fix block comment style in nvec_interrupt()")

suggests that people aren't using linux-next as their baseline. Do we
need to be stricter in this regard? Seems a bit wasteful for you to have
to spend so much time looking at duplicates, even though it seems like
your automation did a lot of the work.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH] staging: nvec: fix block comment style in nvec.c

[Martin Bojorquez]

Block comments should use * on subsequent lines and a trailing */
on a separate line, as required by the kernel coding style.

Signed-off-by: Martin Bojorquez <dihed1973@gmail.com>
---
 drivers/staging/nvec/nvec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08448..0e655f79ea4a 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -660,7 +660,8 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 			to_send = nvec->tx->data[0];
 			nvec->tx->pos = 1;
 			/* delay ACK due to AP20 HW Bug
-			   do not replace by usleep_range */
+			 * do not replace by usleep_range
+			 */
 			udelay(33);
 		} else if (status == (I2C_SL_IRQ)) {
 			nvec->rx->data[1] = received;
-- 
2.53.0

Re: [PATCH] staging: nvec: fix block comment style in nvec.c

[Greg KH]

On Tue, Mar 17, 2026 at 05:01:14AM -0700, Martin Bojorquez wrote:
> Block comments should use * on subsequent lines and a trailing */
> on a separate line, as required by the kernel coding style.
> 
> Signed-off-by: Martin Bojorquez <dihed1973@gmail.com>
> ---
>  drivers/staging/nvec/nvec.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index e9af66a08448..0e655f79ea4a 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -660,7 +660,8 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  			to_send = nvec->tx->data[0];
>  			nvec->tx->pos = 1;
>  			/* delay ACK due to AP20 HW Bug
> -			   do not replace by usleep_range */
> +			 * do not replace by usleep_range
> +			 */
>  			udelay(33);
>  		} else if (status == (I2C_SL_IRQ)) {
>  			nvec->rx->data[1] = received;
> -- 
> 2.53.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] staging: nvec: fix block comment style in nvec.c

[Alexandru Hossu]

Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
---
 drivers/staging/nvec/nvec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08..0e655f79e 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -660,7 +660,8 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 			to_send = nvec->tx->data[0];
 			nvec->tx->pos = 1;
 			/* delay ACK due to AP20 HW Bug
-			   do not replace by usleep_range */
+			 * do not replace by usleep_range
+			 */
 			udelay(33);
 		} else if (status == (I2C_SL_IRQ)) {
 			nvec->rx->data[1] = received;
-- 
2.43.0

Re: [PATCH] staging: nvec: fix block comment style in nvec.c

[Greg KH]

On Wed, Mar 04, 2026 at 02:07:01PM +0100, Alexandru Hossu wrote:
> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
> ---

No changelog text :(

[PATCH] staging: nvec: fix block comment style in nvec.c

[Alexandru Hossu]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

Fix block comment style in nvec.c to comply with kernel
coding style guidelines.

Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>

[-- Attachment #2: 0001-staging-nvec-fix-block-comment-style-in-nvec.c.patch --]
[-- Type: text/plain, Size: 902 bytes --]

From 2bffc2680eeab8d0f4a07c1749a60bc1c034483e Mon Sep 17 00:00:00 2001
From: Alexandru Hossu <hossu.alexandru@gmail.com>
Date: Wed, 4 Mar 2026 11:20:47 +0100
Subject: [PATCH] staging: nvec: fix block comment style in nvec.c

Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
---
 drivers/staging/nvec/nvec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index e9af66a08..0e655f79e 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -660,7 +660,8 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 			to_send = nvec->tx->data[0];
 			nvec->tx->pos = 1;
 			/* delay ACK due to AP20 HW Bug
-			   do not replace by usleep_range */
+			 * do not replace by usleep_range
+			 */
 			udelay(33);
 		} else if (status == (I2C_SL_IRQ)) {
 			nvec->rx->data[1] = received;
-- 
2.43.0