* [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_suspend_common
@ 2026-03-08 22:19 Gustavo Arantes
2026-03-09 13:36 ` Bryant Boatright
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Arantes @ 2026-03-08 22:19 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Gustavo Arantes
Replace msleep(1) with usleep_range(1000, 2000) in rtw_suspend_common(),
since msleep() for values less than 20ms may not sleep for the intended
duration as documented in Documentation/timers/timers-howto.rst.
Signed-off-by: Gustavo Arantes <dev.gustavoa@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f2d64b05debb..47b1c791ec8c 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -1091,7 +1091,7 @@ void rtw_suspend_common(struct adapter *padapter)
pwrpriv->bInSuspend = true;
while (pwrpriv->bips_processing)
- msleep(1);
+ usleep_range(1000, 2000);
if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved))
return;
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_suspend_common
2026-03-08 22:19 [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_suspend_common Gustavo Arantes
@ 2026-03-09 13:36 ` Bryant Boatright
2026-03-09 14:03 ` Gustavo Oliveira Arantes
0 siblings, 1 reply; 3+ messages in thread
From: Bryant Boatright @ 2026-03-09 13:36 UTC (permalink / raw)
To: Gustavo Arantes; +Cc: gregkh, linux-staging, linux-kernel
On Sun, Mar 08, 2026 at 07:19:50PM -0300, Gustavo Arantes wrote:
> Replace msleep(1) with usleep_range(1000, 2000) in rtw_suspend_common(),
> since msleep() for values less than 20ms may not sleep for the intended
> duration as documented in Documentation/timers/timers-howto.rst.
This has been addressed in a thread recently and Gred said to drop the patch [1].
Best,
Bryant Boatright
[1] https://lore.kernel.org/linux-staging/20260214173139.49094-1-ofekalm100@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_suspend_common
2026-03-09 13:36 ` Bryant Boatright
@ 2026-03-09 14:03 ` Gustavo Oliveira Arantes
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo Oliveira Arantes @ 2026-03-09 14:03 UTC (permalink / raw)
To: Bryant Boatright; +Cc: gregkh, linux-staging, linux-kernel
On Mon, Mar 9, 2026 at 10:36 AM Bryant Boatright
<bryant.boatright@proton.me> wrote:
> This has been addressed in a thread recently and Gred said to drop the patch [1].
> [1] https://lore.kernel.org/linux-staging/20260214173139.49094-1-ofekalm100@gmail.com/
Thanks for pointing that out. I'll drop both usleep_range patches.
Best regards,
Gustavo.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-09 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-08 22:19 [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_suspend_common Gustavo Arantes
2026-03-09 13:36 ` Bryant Boatright
2026-03-09 14:03 ` Gustavo Oliveira Arantes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox