Re: [PATCH] staging: greybus: standardize data type and fix alignment to parentheses

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 01, 2026 at 03:21:54PM +0530, Prithvi Tambewagh wrote:
> Standardize code in the file:
> drivers/staging/greybus/Documentation/firmware/authenticate.c
> by making the following changes:
> 
> 1. Remove redundant 'int' from 'unsigned long long int' as suggested by
>    checkpatch when printing the obtained device UID:
>    printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
> 
> 2. Fix alignment of multi-line printf statement to match opening
>    parentheses:
>    printf("Authenticated, result (%02x), sig-size (%02x)\n",
>           authenticate.result_code, authenticate.signature_size);
> 
> Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
> ---
>  drivers/staging/greybus/Documentation/firmware/authenticate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c
> index 3d2c6f88a138..ba4b16b04557 100644
> --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c
> +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c
> @@ -58,7 +58,7 @@ int main(int argc, char *argv[])
>  		goto close_fd;
>  	}
>  
> -	printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid));
> +	printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
>  
>  	/* Get certificate */
>  	printf("Get IMS certificate\n");
> @@ -85,7 +85,7 @@ int main(int argc, char *argv[])
>  	}
>  
>  	printf("Authenticated, result (%02x), sig-size (%02x)\n",
> -		authenticate.result_code, authenticate.signature_size);
> +	       authenticate.result_code, authenticate.signature_size);
>  
>  close_fd:
>  	close(fd);
> 
> base-commit: eb71ab2bf72260054677e348498ba995a057c463
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot